ARM: OMAP: hsmmc: add max_freq field

PATCH New Daniel Mack 2 participants 2 messages Feb 19, 2012

Subsystems (5)

Arm (32-bit) Arm sub-architectures MMC, SD and SDIO OMAP2+ support +1 more subsystems

lore

Share & tools

lore

Daniel Mack

author

2012-02-19 12:20 UTC #0 lore raw

PATCH 1/1 ARM: OMAP: hsmmc: add max_freq field

External circuitry like level shifters may limit the maximum operation speed of the hsmmc controller. Add a field to struct omap2_hsmmc_info so boards can adjust the setting on demand.

Signed-off-by Daniel Mack <[email protected]>

Acked-by Tony Lindgren <[email protected]>

Cc Chris Ball <[email protected]>

Cc Cousson, Benoit <[email protected]>

---

This trivial patch is in my queue for some time already, and Tony acked on it awhile back. I was told to take Chris Ball in the loop as there is currently no OMAP MMC maintainer.

This still applies cleanly to 3.3-rc4. Chris, can you queue this?

 arch/arm/mach-omap2/hsmmc.c   |    1 +
 arch/arm/mach-omap2/hsmmc.h   |    2 ++
 drivers/mmc/host/omap_hsmmc.c |    8 ++++++--
 3 files changed, 9 insertions(+), 2 deletions(-)

arch/arm/mach-omap2/hsmmc.c +1 -0

index f4a1020..4c7bc36 100644
@@ -298,6 +298,7 @@ static int __init omap_hsmmc_pdata_init(struct omap2_hsmmc_info *c,
 	mmc->slots[0].caps = c->caps;
 	mmc->slots[0].internal_clock = !c->ext_clock;
 	mmc->dma_mask = 0xffffffff;
+	mmc->max_freq = c->max_freq;
 	if (cpu_is_omap44xx())
 		mmc->reg_offset = OMAP4_MMC_REG_OFFSET;
 	else

arch/arm/mach-omap2/hsmmc.h +2 -0

index f757e78..65a8c12 100644
@@ -25,6 +25,8 @@ struct omap2_hsmmc_info {
 	char	*name;		/* or NULL for default */
 	struct device *dev;	/* returned: pointer to mmc adapter */
 	int	ocr_mask;	/* temporary HACK */
+	int	max_freq;	/* maximum clock, if constrained by external
+				 * circuitry, or 0 for default */
 	/* Remux (pad configuration) when powering on/off */
 	void (*remux)(struct device *dev, int slot, int power_on);
 	/* init some special card */

drivers/mmc/host/omap_hsmmc.c +6 -2

index 101cd31..8215ef9 100644
@@ -1927,8 +1927,12 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
 	if (mmc_slot(host).vcc_aux_disable_is_sleep)
 		mmc_slot(host).no_off = 1;
 
-	mmc->f_min	= OMAP_MMC_MIN_CLOCK;
-	mmc->f_max	= OMAP_MMC_MAX_CLOCK;
+	mmc->f_min = OMAP_MMC_MIN_CLOCK;
+
+	if (pdata->max_freq > 0)
+		mmc->f_max = pdata->max_freq;
+	else
+		mmc->f_max = OMAP_MMC_MAX_CLOCK;
 
 	spin_lock_init(&host->irq_lock);

Signature · 1 line

1.7.7.4

Chris Ball

2012-02-19 16:16 UTC #1 lore raw

PATCH 1/1 ARM: OMAP: hsmmc: add max_freq field

Hi,

Quoted 8 lines · Daniel Mack

External circuitry like level shifters may limit the maximum operation speed of the hsmmc controller. Add a field to struct omap2_hsmmc_info so boards can adjust the setting on demand.
Signed-off-by Daniel Mack <[email protected]>
Acked-by Tony Lindgren <[email protected]>
Cc Chris Ball <[email protected]>
Cc Cousson, Benoit <[email protected]>

Quoted 7 lines

---
This trivial patch is in my queue for some time already, and Tony acked on it awhile back. I was told to take Chris Ball in the loop as there is currently no OMAP MMC maintainer.
This still applies cleanly to 3.3-rc4. Chris, can you queue this?

Thanks, queued in mmc-next now. (The arch/arm/mach-omap2/hsmmc.c change did not apply cleanly, though; I fixed that.)

- Chris.

Signature · 2 lines

Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child