TDA1997x: fix tda1997x_query_dv_timings() return value
Subsystems (2)
PATCH 1/1 TDA1997x: fix tda1997x_query_dv_timings() return value
Signed-off-by Krzysztof Hałasa <[email protected]>
drivers/media/i2c/tda1997x.c +3 -2
@@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_subdev *sd, struct v4l2_dv_timings *timings) {struct tda1997x_state *state =to_state (sd); +int ret;v4l_dbg (1 , debug, state->client,"%s\n" , __func__);memset (timings,0 ,sizeof (struct v4l2_dv_timings ));mutex_lock (&state->lock); -tda1997x_detect_std (state, timings); + ret =tda1997x_detect_std (state, timings);mutex_unlock (&state->lock); -return 0 ; +return ret; }static const struct v4l2_subdev_video_ops tda1997x_video_ops = {
Tim Harvey
maintainerQuoted 15 lines · Krzysztof Hałasa
Signed-off-by Krzysztof Hałasa <[email protected]>drivers/media/i2c/tda1997x.c +1
-0@@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_subdev *sd, struct v4l2_dv_timings *timings) {struct tda1997x_state *state =to_state (sd); +int ret;v4l_dbg (1 , debug, state->client,"%s\n" , __func__);memset (timings,0 ,sizeof (struct v4l2_dv_timings ));
drivers/media/i2c/tda1997x.c static int tda1997x_query_dv_timings(struct v4l2_subdev *sd, · line 1709
Quoted 10 lines
drivers/media/i2c/tda1997x.c +2
-2mutex_lock (&state->lock); -tda1997x_detect_std (state, timings); + ret =tda1997x_detect_std (state, timings);mutex_unlock (&state->lock); -return 0 ; +return ret; }static const struct v4l2_subdev_video_ops tda1997x_video_ops = {
Krzysztof,
Patch looks good to me but needs a commit log.
Best regards,
Tim