Skip to contentSkip to conversation

TDA1997x: fix tda1997x_query_dv_timings() return value

PATCH In review Krzysztof Hałasa 2 participants 2 messages Jul 26, 2021 – Aug 19, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TDA1997x: fix tda1997x_query_dv_timings() return value

drivers/media/i2c/tda1997x.c +3 -2
index 043cc8275d00..cbfe58e413e9 100644
@@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_subdev *sd,
 				     struct v4l2_dv_timings *timings)
 {
 	struct tda1997x_state *state = to_state(sd);
+	int ret;
 
 	v4l_dbg(1, debug, state->client, "%s\n", __func__);
 	memset(timings, 0, sizeof(struct v4l2_dv_timings));
 	mutex_lock(&state->lock);
-	tda1997x_detect_std(state, timings);
+	ret = tda1997x_detect_std(state, timings);
 	mutex_unlock(&state->lock);
 
-	return 0;
+	return ret;
 }
 
 static const struct v4l2_subdev_video_ops tda1997x_video_ops = {
maintainer
#1 lore raw
Quoted 15 lines · Krzysztof Hałasa
drivers/media/i2c/tda1997x.c +1 -0
index 043cc8275d00..cbfe58e413e9 100644
@@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_subdev *sd,
                                     struct v4l2_dv_timings *timings)
 {
        struct tda1997x_state *state = to_state(sd);
+       int ret;
 
        v4l_dbg(1, debug, state->client, "%s\n", __func__);
        memset(timings, 0, sizeof(struct v4l2_dv_timings));

drivers/media/i2c/tda1997x.c static int tda1997x_query_dv_timings(struct v4l2_subdev *sd, · line 1709

Quoted 10 lines
drivers/media/i2c/tda1997x.c +2 -2
        mutex_lock(&state->lock);
-       tda1997x_detect_std(state, timings);
+       ret = tda1997x_detect_std(state, timings);
        mutex_unlock(&state->lock);
 
-       return 0;
+       return ret;
 }
 
 static const struct v4l2_subdev_video_ops tda1997x_video_ops = {

Krzysztof,

Patch looks good to me but needs a commit log.

Best regards,

Tim