Skip to contentSkip to conversation

fix LINK_ZERO parsing in cdsymlinks.c

PATCH In review Olivier Blin 4 participants 5 messages Sep 6, 2005 – Sep 8, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix LINK_ZERO parsing in cdsymlinks.c

Hi,

The following patch from J.A. Magallon fixes LINK_ZERO parsing in cdsymlinks.c

Regards

Signature · 3 lines
Olivier Blin
Mandriva
Mandrakesoft becomes Mandriva
#1 lore raw

I demand that Olivier Blin may or may not have written...

Quoted 2 lines

The following patch from J.A. Magallon fixes LINK_ZERO parsing in cdsymlinks.c

Good catch...

I'm attaching that patch *uncompressed* and with appropriate adjustments to the comments at the start of the file.

Signature · 6 lines
| Darren Salt | nr. Ashington, | d youmustbejoking,demon,co,uk
| Debian,     | Northumberland | s zap,tartarus,org
| RISC OS     | Toon Army      | @
|   One brown paper bag, recently used.

If you notice this notice, you'll notice this notice is not worth noticing.
extras/cdsymlinks.c renamed from extras/cdsymlinks.c~ +4 -3
@@ -12,11 +12,12 @@
  * (this last one is "just in case")
  *
  * (c) 2004, 2005 Darren Salt <[email protected]>
+ *                and contributors
  *
  * Contributors:
  *  - J A Magallon <[email protected]> (bug fixes)
  *
- * Last modified: 2005-02-15
+ * Last modified: 2005-09-06
  */
 
 #define _GNU_SOURCE
@@ -301,8 +302,8 @@
           }
           else if (!strncmp (p.we_wordv[0], "NUMBERED_LINKS=", 15))
             numbered_links = atoi (p.we_wordv[0] + 15);
-          else if (!strncmp (p.we_wordv[0], "LINK_ZERO=", 15))
-            link_zero = atoi (p.we_wordv[0] + 15);
+          else if (!strncmp (p.we_wordv[0], "LINK_ZERO=", 10))
+            link_zero = atoi (p.we_wordv[0] + 10);
           break;
 	}
 	/* fall through */
#2 lore raw
In reply to Olivier Blin
Quoted 9 lines · Darren Salt

I demand that Olivier Blin may or may not have written...

Quoted 2 lines

The following patch from J.A. Magallon fixes LINK_ZERO parsing in cdsymlinks.c

Good catch...

I'm attaching that patch *uncompressed* and with appropriate adjustments to the comments at the start of the file.

This file is obsoleted by the cdrom_id program. Mind if we just delete the cdsymlinks stuff from the udev tree as it isn't needed anymore?

thanks,

greg k-h

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

#3 lore raw
In reply to Olivier Blin

I demand that Greg KH may or may not have written...

Quoted 10 lines · Darren Salt
Quoted 6 lines

I demand that Olivier Blin may or may not have written...

Quoted 2 lines

The following patch from J.A. Magallon fixes LINK_ZERO parsing in cdsymlinks.c

Good catch...
I'm attaching that patch *uncompressed* and with appropriate adjustments to the comments at the start of the file.

This file is obsoleted by the cdrom_id program. Mind if we just delete the cdsymlinks stuff from the udev tree as it isn't needed anymore?

I'd prefer to have them log some "obsoleted, will be removed in version xxx" messages for a couple of releases. (Output on stderr?)

BTW, I'm not sure that the behaviour of cdrom_id and its associated rules concerning links for a device for which symlinks already exists is right; although, as it stands, it'll only be a problem if udev gets duplicate events (or /dev isn't a tmpfs mount or similar).

Signature · 17 lines
| Darren Salt | d youmustbejoking,demon,co,uk | nr. Ashington,
| Debian,     | s zap,tartarus,org            | Northumberland
| RISC OS     | @                             | Toon Army
|   <URL:http://www.youmustbejoking.demon.co.uk/progs.packages.html>

Captain, permission to hook up blender attachments to Mr Spock.


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
#4 lore raw
In reply to Olivier Blin
Quoted 10 lines · Darren Salt

I demand that Greg KH may or may not have written...

Quoted 7 lines · Darren Salt
Quoted 6 lines

I demand that Olivier Blin may or may not have written...

Quoted 2 lines

The following patch from J.A. Magallon fixes LINK_ZERO parsing in cdsymlinks.c

Good catch...
I'm attaching that patch *uncompressed* and with appropriate adjustments to the comments at the start of the file.

Quoted 5 lines
Quoted 2 lines

This file is obsoleted by the cdrom_id program. Mind if we just delete the cdsymlinks stuff from the udev tree as it isn't needed anymore?

I'd prefer to have them log some "obsoleted, will be removed in version xxx" messages for a couple of releases. (Output on stderr?)

The program is still available in the old releases. The packagers can pick it up from there if needed. We only ship *_id programs from now on to have a consistent way to do device naming. IMPORT'ed variables are accesible for later rules to match against and they are also stored in the udev database to be queried by other programs any time later.

Quoted 4 lines

BTW, I'm not sure that the behaviour of cdrom_id and its associated rules concerning links for a device for which symlinks already exists is right; although, as it stands, it'll only be a problem if udev gets duplicate events (or /dev isn't a tmpfs mount or similar).

Unknown links are always overwritten if they are not registered in the udev database. Duplicate events should create the same nodes and links.

If you miss some feature, please add it to the cdrom_id program now.

Thanks,
Kay

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel