WAN: Fix a TX IRQ causing BUG() in PC300 and PCI200SYN drivers.
Subsystems (3)
Krzysztof Halasa
maintainerPATCH 1/1 WAN: Fix a TX IRQ causing BUG() in PC300 and PCI200SYN drivers.
We must not wake the TX queue without free TX descriptors. sca_xmit() expects at least one free descriptor and BUGs otherwise.
Problem reported and fix tested by Bernie Innocenti and Ward Vandewege.
Signed-off-by Krzysztof Hałasa <[email protected]>
drivers/net/wan/hd64572.c +4 -1
@@ -293,6 +293,7 @@ static inline void sca_tx_done(port_t *port)struct net_device *dev = port->netdev;card_t * card = port->card;u8 stat; +unsigned count =0 ;spin_lock (&port->lock);
@@ -316,10 +317,12 @@ static inline void sca_tx_done(port_t *port) dev->stats.tx_bytes +=readw (&desc->len); }writeb (0 , &desc->stat);/* Free descriptor */ + count++; port->txlast = (port->txlast +1 ) % card->tx_ring_buffers; } -netif_wake_queue (dev); +if (count) +netif_wake_queue (dev);spin_unlock (&port->lock); }
From: Krzysztof Halasa <[email protected]>
Date: Sun, 12 Dec 2010 23:06:47 +0100
Quoted 6 lines
We must not wake the TX queue without free TX descriptors.
sca_xmit()expects at least one free descriptor and BUGs otherwise.Problem reported and fix tested by Bernie Innocenti and Ward Vandewege.
Signed-off-by Krzysztof Hałasa <[email protected]>
Applied.