Switch to sync registration for IPU subdevs
Steve Longerbeam
maintainerv2 cover Switch to sync registration for IPU subdevs
Switch to sync registration for the IPU internal sub-devices, re-organize modules, and a few other miscellaneous cleanups.
History:
v2:
- Added a patch that improves the pipeline upstream/downstream search functions, which no longer require the media device.
- Add a patch to remove getting media device from v4l2_dev driver data.
Steve Longerbeam (8):
media: staging/imx: Switch to sync registration for IPU subdevs
media: staging/imx: Pass device to alloc/free_dma_buf
media: staging/imx: Move add_video_device into capture_device_register Revert "media: imx: Set capture compose rectangle in
capture_device_set_format"
media: staging/imx: Remove capture_device_set_format
media: staging/imx: Re-organize modules
media: staging/imx: Improve pipeline searching
media: staging/imx: Don't set driver data for v4l2_dev
drivers/staging/media/imx/Makefile | 18 +- drivers/staging/media/imx/imx-ic-common.c | 68 +-- drivers/staging/media/imx/imx-ic-prp.c | 36 +- drivers/staging/media/imx/imx-ic-prpencvf.c | 88 ++-- drivers/staging/media/imx/imx-ic.h | 6 +- drivers/staging/media/imx/imx-media-capture.c | 75 ++- drivers/staging/media/imx/imx-media-csi.c | 45 +- .../staging/media/imx/imx-media-dev-common.c | 346 +++++++++++++- drivers/staging/media/imx/imx-media-dev.c | 449 +----------------- drivers/staging/media/imx/imx-media-fim.c | 9 - .../staging/media/imx/imx-media-internal-sd.c | 357 ++++++-------- drivers/staging/media/imx/imx-media-of.c | 41 +- drivers/staging/media/imx/imx-media-utils.c | 170 +++---- drivers/staging/media/imx/imx-media-vdic.c | 84 +--- drivers/staging/media/imx/imx-media.h | 113 +++-- drivers/staging/media/imx/imx7-media-csi.c | 43 +- 16 files changed, 848 insertions(+), 1100 deletions(-)
Signature · 1 line
2.17.1
Steve Longerbeam
maintainerPATCH v2 1/8 media: staging/imx: Switch to sync registration for IPU subdevs
Because the IPU sub-devices VDIC and IC are not present in the device-tree, platform devices were created for them instead. This allowed these sub-devices to be added to the media device's async notifier and registered asynchronously along with the other sub-devices that do have a device-tree presence (CSI and devices external to the IPU and SoC).
But that approach isn't really necessary. The IPU sub-devices don't actually require a backing device (sd->dev is allowed to be NULL). And that approach can't get around the fact that the IPU sub-devices are not part of a device hierarchy, which makes it awkward to retrieve the parent IPU of these devices.
By registering them synchronously, they can be registered from the CSI async bound notifier, so the init function for them can be given the CSI subdev, who's dev->parent is the IPU. That is a somewhat cleaner way to retrieve the parent IPU.
So convert to synchronous registration for the VDIC and IC task sub-devices, at the time a CSI sub-device is bound. There is no longer a backing device for them (sd->dev is NULL), but that's ok. Also set the VDIC/IC sub-device owner as the IPU, so that a reference can be taken on the IPU module.
--- drivers/staging/media/imx/imx-ic-common.c | 70 ++-- drivers/staging/media/imx/imx-ic-prp.c | 34 +- drivers/staging/media/imx/imx-ic-prpencvf.c | 70 ++-- drivers/staging/media/imx/imx-ic.h | 7 +- drivers/staging/media/imx/imx-media-capture.c | 7 +- drivers/staging/media/imx/imx-media-csi.c | 2 +- drivers/staging/media/imx/imx-media-dev.c | 121 +----- .../staging/media/imx/imx-media-internal-sd.c | 356 ++++++++---------- drivers/staging/media/imx/imx-media-of.c | 38 +- drivers/staging/media/imx/imx-media-vdic.c | 85 ++--- drivers/staging/media/imx/imx-media.h | 67 ++-- drivers/staging/media/imx/imx7-media-csi.c | 3 +- 12 files changed, 325 insertions(+), 535 deletions(-)
drivers/staging/media/imx/imx-ic-common.c +25 -45
@@ -8,8 +8,6 @@* the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. */ -#include <linux/module.h> -#include <linux/platform_device.h> #include <media/v4l2-device.h> #include <media/v4l2-subdev.h> #include "imx-media.h"
@@ -24,23 +22,25 @@ static struct imx_ic_ops *ic_ops[IC_NUM_OPS] = { [IC_TASK_VIEWFINDER] = &imx_ic_prpencvf_ops, }; -static int imx_ic_probe (struct platform_device *pdev) +struct v4l2_subdev *imx_media_ic_register (struct imx_media_dev *imxmd, +struct device *ipu_dev, +struct ipu_soc *ipu, +u32 grp_id) { -struct imx_media_ipu_internal_sd_pdata *pdata; +struct v4l2_device *v4l2_dev = &imxmd->v4l2_dev;struct imx_ic_priv *priv;int ret; - priv =devm_kzalloc (&pdev->dev,sizeof (*priv),GFP_KERNEL ); + priv =devm_kzalloc (ipu_dev,sizeof (*priv),GFP_KERNEL );if (!priv) -return -ENOMEM ; +return ERR_PTR (-ENOMEM ); -platform_set_drvdata (pdev, &priv->sd); - priv->dev = &pdev->dev; + priv->ipu_dev = ipu_dev; + priv->ipu = ipu; + priv->md = imxmd; -/* get our ipu_id, grp_id and IC task id */ - pdata = priv->dev->platform_data; - priv->ipu_id = pdata->ipu_id; -switch (pdata->grp_id) { +/* get our IC task id */ +switch (grp_id) {case IMX_MEDIA_GRP_ID_IPU_IC_PRP : priv->task_id =IC_TASK_PRP ;break ;
@@ -51,7 +51,7 @@ static int imx_ic_probe(struct platform_device *pdev) priv->task_id =IC_TASK_VIEWFINDER ;break ;default : -return -EINVAL ; +return ERR_PTR (-EINVAL ); }v4l2_subdev_init (&priv->sd, ic_ops[priv->task_id]->subdev_ops);
@@ -59,55 +59,35 @@ static int imx_ic_probe(struct platform_device *pdev) priv->sd.internal_ops = ic_ops[priv->task_id]->internal_ops; priv->sd.entity.ops = ic_ops[priv->task_id]->entity_ops; priv->sd.entity.function =MEDIA_ENT_F_PROC_VIDEO_SCALER ; - priv->sd.dev = &pdev->dev; - priv->sd.owner =THIS_MODULE ; + priv->sd.owner = ipu_dev->driver->owner; priv->sd.flags =V4L2_SUBDEV_FL_HAS_DEVNODE |V4L2_SUBDEV_FL_HAS_EVENTS ; - priv->sd.grp_id = pdata->grp_id; -strscpy (priv->sd.name, pdata->sd_name,sizeof (priv->sd.name)); + priv->sd.grp_id = grp_id; +imx_media_grp_id_to_sd_name (priv->sd.name,sizeof (priv->sd.name), + priv->sd.grp_id,ipu_get_num (ipu)); ret = ic_ops[priv->task_id]->init (priv);if (ret) -return ret; +return ERR_PTR (ret); - ret =v4l2_async_register_subdev (&priv->sd); -if (ret) + ret =v4l2_device_register_subdev (v4l2_dev, &priv->sd); +if (ret) { ic_ops[priv->task_id]->remove (priv); +return ERR_PTR (ret); + } -return ret; +return &priv->sd; } -static int imx_ic_remove (struct platform_device *pdev) +int imx_media_ic_unregister (struct v4l2_subdev *sd) { -struct v4l2_subdev *sd =platform_get_drvdata (pdev); struct imx_ic_priv *priv = container_of(sd, struct imx_ic_priv, sd);v4l2_info (sd,"Removing\n" ); ic_ops[priv->task_id]->remove (priv); -v4l2_async_unregister_subdev (sd); +v4l2_device_unregister_subdev (sd);media_entity_cleanup (&sd->entity);return 0 ; } - -static const struct platform_device_id imx_ic_ids[] = { - { .name ="imx-ipuv3-ic" }, - { }, -}; -MODULE_DEVICE_TABLE (platform, imx_ic_ids); - -static struct platform_driver imx_ic_driver = { - .probe = imx_ic_probe, - .remove = imx_ic_remove, - .id_table = imx_ic_ids, - .driver = { - .name ="imx-ipuv3-ic" , - }, -}; -module_platform_driver (imx_ic_driver); - -MODULE_DESCRIPTION ("i.MX IC subdev driver" ); -MODULE_AUTHOR ("Steve Longerbeam <[email protected]>" ); -MODULE_LICENSE ("GPL" ); -MODULE_ALIAS ("platform:imx-ipuv3-ic" );
drivers/staging/media/imx/imx-ic-prp.c +13 -21
@@ -39,16 +39,12 @@#define S_ALIGN 1/* multiple of 2 */ struct prp_priv { -struct imx_media_dev *md;struct imx_ic_priv *ic_priv;struct media_pad pad[PRP_NUM_PADS ];/* lock to protect all members below */ struct mutex lock; -/* IPU units we require */ -struct ipu_soc *ipu; -struct v4l2_subdev *src_sd;struct v4l2_subdev *sink_sd_prpenc;struct v4l2_subdev *sink_sd_prpvf;
@@ -66,7 +62,7 @@ static inline struct prp_priv *sd_to_priv(struct v4l2_subdev *sd) {struct imx_ic_priv *ic_priv =v4l2_get_subdevdata (sd); -return ic_priv->prp_priv; +return ic_priv->task_priv; }static int prp_start (struct prp_priv *priv)
@@ -74,12 +70,10 @@ static int prp_start(struct prp_priv *priv)struct imx_ic_priv *ic_priv = priv->ic_priv;bool src_is_vdic; - priv->ipu = priv->md->ipu[ic_priv->ipu_id]; -/* set IC to receive from CSI or VDI depending on source */ src_is_vdic = !!(priv->src_sd->grp_id &IMX_MEDIA_GRP_ID_IPU_VDIC ); -ipu_set_ic_src_mux (priv->ipu, priv->csi_id, src_is_vdic); +ipu_set_ic_src_mux (ic_priv->ipu, priv->csi_id, src_is_vdic);return 0 ; }
@@ -220,12 +214,12 @@ static int prp_link_setup(struct media_entity *entity, {struct v4l2_subdev *sd =media_entity_to_v4l2_subdev (entity);struct imx_ic_priv *ic_priv =v4l2_get_subdevdata (sd); -struct prp_priv *priv = ic_priv->prp_priv; +struct prp_priv *priv = ic_priv->task_priv;struct v4l2_subdev *remote_sd;int ret =0 ; -dev_dbg (ic_priv->dev,"link setup %s -> %s" , remote->entity->name, - local->entity->name); +dev_dbg (ic_priv->ipu_dev,"%s: link setup %s -> %s" , + ic_priv->sd.name, remote->entity->name, local->entity->name); remote_sd =media_entity_to_v4l2_subdev (remote->entity);
@@ -299,7 +293,7 @@ static int prp_link_validate(struct v4l2_subdev *sd, struct v4l2_subdev_format *sink_fmt) {struct imx_ic_priv *ic_priv =v4l2_get_subdevdata (sd); -struct prp_priv *priv = ic_priv->prp_priv; +struct prp_priv *priv = ic_priv->task_priv;struct v4l2_subdev *csi;int ret;
@@ -308,7 +302,7 @@ static int prp_link_validate(struct v4l2_subdev *sd,if (ret)return ret; - csi =imx_media_find_upstream_subdev (priv->md, &ic_priv->sd.entity, + csi =imx_media_find_upstream_subdev (ic_priv->md, &ic_priv->sd.entity,IMX_MEDIA_GRP_ID_IPU_CSI );if (IS_ERR (csi)) csi =NULL ;
@@ -355,7 +349,7 @@ static int prp_link_validate(struct v4l2_subdev *sd,static int prp_s_stream (struct v4l2_subdev *sd,int enable) {struct imx_ic_priv *ic_priv =v4l2_get_subdevdata (sd); -struct prp_priv *priv = ic_priv->prp_priv; +struct prp_priv *priv = ic_priv->task_priv;int ret =0 ;mutex_lock (&priv->lock);
@@ -372,7 +366,8 @@ static int prp_s_stream(struct v4l2_subdev *sd, int enable)if (priv->stream_count != !enable) goto update_count; -dev_dbg (ic_priv->dev,"stream %s\n" , enable ?"ON" :"OFF" ); +dev_dbg (ic_priv->ipu_dev,"%s: stream %s\n" , sd->name, + enable ?"ON" :"OFF" );if (enable) ret =prp_start (priv);
@@ -444,9 +439,6 @@ static int prp_registered(struct v4l2_subdev *sd)int i, ret;u32 code; -/* get media device */ - priv->md =dev_get_drvdata (sd->v4l2_dev->dev); -for (i =0 ; i <PRP_NUM_PADS ; i++) { priv->pad[i].flags = (i ==PRP_SINK_PAD ) ?MEDIA_PAD_FL_SINK :MEDIA_PAD_FL_SOURCE ;
@@ -498,12 +490,12 @@ static int prp_init(struct imx_ic_priv *ic_priv) {struct prp_priv *priv; - priv =devm_kzalloc (ic_priv->dev,sizeof (*priv),GFP_KERNEL ); + priv =devm_kzalloc (ic_priv->ipu_dev,sizeof (*priv),GFP_KERNEL );if (!priv)return -ENOMEM ;mutex_init (&priv->lock); - ic_priv->prp_priv = priv; + ic_priv->task_priv = priv; priv->ic_priv = ic_priv;return 0 ;
@@ -511,7 +503,7 @@ static int prp_init(struct imx_ic_priv *ic_priv)static void prp_remove (struct imx_ic_priv *ic_priv) { -struct prp_priv *priv = ic_priv->prp_priv; +struct prp_priv *priv = ic_priv->task_priv;mutex_destroy (&priv->lock); }
drivers/staging/media/imx/imx-ic-prpencvf.c +34 -36
222 lines not on this page · raw message
drivers/staging/media/imx/imx-ic.h +3 -4
@@ -14,11 +14,11 @@#include <media/v4l2-subdev.h> struct imx_ic_priv { -struct device *dev; +struct device *ipu_dev; +struct ipu_soc *ipu; +struct imx_media_dev *md;struct v4l2_subdev sd; -int ipu_id;int task_id; -void *prp_priv;void *task_priv; };
@@ -33,6 +33,5 @@ struct imx_ic_ops {extern struct imx_ic_ops imx_ic_prp_ops;extern struct imx_ic_ops imx_ic_prpencvf_ops; -extern struct imx_ic_ops imx_ic_pp_ops;#endif
drivers/staging/media/imx/imx-media-capture.c +4 -3
@@ -804,18 +804,19 @@ void imx_media_capture_device_unregister(struct imx_media_video_dev *vdev)EXPORT_SYMBOL_GPL (imx_media_capture_device_unregister);struct imx_media_video_dev * -imx_media_capture_device_init (struct v4l2_subdev *src_sd,int pad) +imx_media_capture_device_init (struct device *dev,struct v4l2_subdev *src_sd, +int pad) {struct capture_priv *priv;struct video_device *vfd; - priv =devm_kzalloc (src_sd->dev,sizeof (*priv),GFP_KERNEL ); + priv =devm_kzalloc (dev,sizeof (*priv),GFP_KERNEL );if (!priv)return ERR_PTR (-ENOMEM ); priv->src_sd = src_sd; priv->src_sd_pad = pad; - priv->dev = src_sd->dev; + priv->dev = dev;mutex_init (&priv->mutex);spin_lock_init (&priv->q_lock);
drivers/staging/media/imx/imx-media-csi.c +1 -1
@@ -1987,7 +1987,7 @@ static int imx_csi_probe(struct platform_device *pdev)imx_media_grp_id_to_sd_name (priv->sd.name,sizeof (priv->sd.name), priv->sd.grp_id,ipu_get_num (priv->ipu)); - priv->vdev =imx_media_capture_device_init (&priv->sd, + priv->vdev =imx_media_capture_device_init (priv->sd.dev, &priv->sd,CSI_SRC_PAD_IDMAC );if (IS_ERR (priv->vdev))return PTR_ERR (priv->vdev);
drivers/staging/media/imx/imx-media-dev.c +12 -109
171 lines not on this page · raw message
drivers/staging/media/imx/imx-media-internal-sd.c +156 -200
487 lines not on this page · raw message
drivers/staging/media/imx/imx-media-of.c +14 -24
@@ -23,6 +23,9 @@int imx_media_of_add_csi (struct imx_media_dev *imxmd,struct device_node *csi_np) { +struct v4l2_async_subdev *asd; +int ret =0 ; +if (!of_device_is_available (csi_np)) {dev_dbg (imxmd->md.dev,"%s: %pOFn not enabled\n" , __func__, csi_np);
@@ -30,18 +33,25 @@ int imx_media_of_add_csi(struct imx_media_dev *imxmd, }/* add CSI fwnode to async notifier */ -return imx_media_add_async_subdev (imxmd,of_fwnode_handle (csi_np), -NULL ); + asd =v4l2_async_notifier_add_fwnode_subdev (&imxmd->notifier, +of_fwnode_handle (csi_np), +sizeof (*asd)); +if (IS_ERR (asd)) { + ret =PTR_ERR (asd); +if (ret == -EEXIST ) +dev_dbg (imxmd->md.dev,"%s: already added %pOFn\n" , + __func__, csi_np); + } + +return ret; }EXPORT_SYMBOL_GPL (imx_media_of_add_csi);int imx_media_add_of_subdevs (struct imx_media_dev *imxmd,struct device_node *np) { -bool ipu_found[2 ] = {false, false};struct device_node *csi_np;int i, ret; -u32 ipu_id;for (i =0 ; ; i++) { csi_np =of_parse_phandle (np,"ports" , i);
@@ -59,31 +69,11 @@ int imx_media_add_of_subdevs(struct imx_media_dev *imxmd,/* other error, can't continue */ goto err_out; } - - ret =of_alias_get_id (csi_np->parent,"ipu" ); -if (ret <0 ) - goto err_out; -if (ret >1 ) { - ret = -EINVAL ; - goto err_out; - } - - ipu_id = ret; - -if (!ipu_found[ipu_id]) { - ret =imx_media_add_ipu_internal_subdevs (imxmd, - ipu_id); -if (ret) - goto err_out; - } - - ipu_found[ipu_id] = true; }return 0 ; err_out: -imx_media_remove_ipu_internal_subdevs (imxmd);of_node_put (csi_np);return ret; }
drivers/staging/media/imx/imx-media-vdic.c +26 -59
160 lines not on this page · raw message
drivers/staging/media/imx/imx-media.h +35 -32
107 lines not on this page · raw message
drivers/staging/media/imx/imx7-media-csi.c +2 -1
@@ -1292,7 +1292,8 @@ static int imx7_csi_probe(struct platform_device *pdev) csi->sd.grp_id =IMX_MEDIA_GRP_ID_CSI ;snprintf (csi->sd.name,sizeof (csi->sd.name),"csi" ); - csi->vdev =imx_media_capture_device_init (&csi->sd,IMX7_CSI_PAD_SRC ); + csi->vdev =imx_media_capture_device_init (csi->sd.dev, &csi->sd, +IMX7_CSI_PAD_SRC );if (IS_ERR (csi->vdev))return PTR_ERR (csi->vdev);
Signature · 1 line
2.17.1
Re: [PATCH v2 1/8] media: staging/imx: Switch to sync registration for IPU subdevs
Hi Steve,
Quoted 18 lines · Steve Longerbeam
Because the IPU sub-devices VDIC and IC are not present in the device-tree, platform devices were created for them instead. This allowed these sub-devices to be added to the media device's async notifier and registered asynchronously along with the other sub-devices that do have a device-tree presence (CSI and devices external to the IPU and SoC).
But that approach isn't really necessary. The IPU sub-devices don't actually require a backing device (
sd->devis allowed to be NULL). And that approach can't get around the fact that the IPU sub-devices are not part of a device hierarchy, which makes it awkward to retrieve the parent IPU of these devices.By registering them synchronously, they can be registered from the CSI async bound notifier, so the init function for them can be given the CSI subdev, who's
dev->parentis the IPU. That is a somewhat cleaner way to retrieve the parent IPU.
Quoted 7 lines
So convert to synchronous registration for the VDIC and IC task sub-devices, at the time a CSI sub-device is bound. There is no longer a backing device for them (
sd->devis NULL), but that's ok. Also set the VDIC/IC sub-device owner as the IPU, so that a reference can be taken on the IPU module.Signed-off-by Steve Longerbeam <[email protected]>
I am trying to bisect when my capture starts to fail to work with this series, since they are so many changes and reorg that I got lost on some of them. But... see below.
Quoted 16 lines
--- drivers/staging/media/imx/imx-ic-common.c | 70 ++-- drivers/staging/media/imx/imx-ic-prp.c | 34 +- drivers/staging/media/imx/imx-ic-prpencvf.c | 70 ++-- drivers/staging/media/imx/imx-ic.h | 7 +- drivers/staging/media/imx/imx-media-capture.c | 7 +- drivers/staging/media/imx/imx-media-csi.c | 2 +- drivers/staging/media/imx/imx-media-dev.c | 121 +----- .../staging/media/imx/imx-media-internal-sd.c | 356 ++++++++---------- drivers/staging/media/imx/imx-media-of.c | 38 +- drivers/staging/media/imx/imx-media-vdic.c | 85 ++--- drivers/staging/media/imx/imx-media.h | 67 ++-- drivers/staging/media/imx/imx7-media-csi.c | 3 +- 12 files changed, 325 insertions(+), 535 deletions(-)drivers/staging/media/imx/imx-media-vdic.c +1
-0+ dev_dbg(priv->ipu_dev, "%s: link setup %s -> %s",
<snip>
Quoted 101 lines
drivers/staging/media/imx/imx-media-vdic.c +20
-34+ sd->name, remote->entity->name, local->entity->name);mutex_lock (&priv->lock);@@ -864,9 +856,6 @@ static int vdic_registered(struct v4l2_subdev *sd)int i, ret;u32 code; -/* get media device */ - priv->md =dev_get_drvdata (sd->v4l2_dev->dev); -for (i =0 ; i <VDIC_NUM_PADS ; i++) { priv->pad[i].flags = (i ==VDIC_SRC_PAD_DIRECT ) ?MEDIA_PAD_FL_SOURCE :MEDIA_PAD_FL_SINK ;@@ -938,77 +927,55 @@ static const struct v4l2_subdev_internal_ops vdic_internal_ops = { .unregistered = vdic_unregistered, }; -static int imx_vdic_probe (struct platform_device *pdev) +struct v4l2_subdev *imx_media_vdic_register (struct imx_media_dev *imxmd, +struct device *ipu_dev, +struct ipu_soc *ipu, +u32 grp_id) { -struct imx_media_ipu_internal_sd_pdata *pdata; +struct v4l2_device *v4l2_dev = &imxmd->v4l2_dev;struct vdic_priv *priv;int ret; - priv =devm_kzalloc (&pdev->dev,sizeof (*priv),GFP_KERNEL ); + priv =devm_kzalloc (ipu_dev,sizeof (*priv),GFP_KERNEL );if (!priv) -return -ENOMEM ; +return ERR_PTR (-ENOMEM ); -platform_set_drvdata (pdev, &priv->sd); - priv->dev = &pdev->dev; - - pdata = priv->dev->platform_data; - priv->ipu_id = pdata->ipu_id; + priv->ipu_dev = ipu_dev; + priv->ipu = ipu; + priv->md = imxmd;v4l2_subdev_init (&priv->sd, &vdic_subdev_ops);v4l2_set_subdevdata (&priv->sd, priv); priv->sd.internal_ops = &vdic_internal_ops; priv->sd.entity.ops = &vdic_entity_ops; priv->sd.entity.function =MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER ; - priv->sd.dev = &pdev->dev; - priv->sd.owner =THIS_MODULE ; + priv->sd.owner = ipu_dev->driver->owner; priv->sd.flags =V4L2_SUBDEV_FL_HAS_DEVNODE ; -/* get our group id */ - priv->sd.grp_id = pdata->grp_id; -strscpy (priv->sd.name, pdata->sd_name,sizeof (priv->sd.name)); + priv->sd.grp_id = grp_id; +imx_media_grp_id_to_sd_name (priv->sd.name,sizeof (priv->sd.name), + priv->sd.grp_id,ipu_get_num (ipu));mutex_init (&priv->lock); - ret =v4l2_async_register_subdev (&priv->sd); + ret =v4l2_device_register_subdev (v4l2_dev, &priv->sd);if (ret) goto free; -return 0 ; +return &priv->sd; free:mutex_destroy (&priv->lock); -return ret; +return ERR_PTR (ret); } -static int imx_vdic_remove (struct platform_device *pdev) +int imx_media_vdic_unregister (struct v4l2_subdev *sd) { -struct v4l2_subdev *sd =platform_get_drvdata (pdev);struct vdic_priv *priv =v4l2_get_subdevdata (sd);v4l2_info (sd,"Removing\n" ); -v4l2_async_unregister_subdev (sd); +v4l2_device_unregister_subdev (sd);mutex_destroy (&priv->lock);media_entity_cleanup (&sd->entity);return 0 ; } - -static const struct platform_device_id imx_vdic_ids[] = { - { .name ="imx-ipuv3-vdic" }, - { }, -}; -MODULE_DEVICE_TABLE (platform, imx_vdic_ids); - -static struct platform_driver imx_vdic_driver = { - .probe = imx_vdic_probe, - .remove = imx_vdic_remove, - .id_table = imx_vdic_ids,
drivers/staging/media/imx/imx-media-vdic.c static const struct v4l2_subdev_internal_ops vdic_internal_ops = { · line 1014
Quoted 10 lines
drivers/staging/media/imx/imx-media-vdic.c +0
-10- .driver = { - .name = "imx-ipuv3-vdic", - }, -}; -module_platform_driver (imx_vdic_driver); - -MODULE_DESCRIPTION ("i.MX VDIC subdev driver" ); -MODULE_AUTHOR ("Steve Longerbeam <[email protected]>" ); -MODULE_LICENSE ("GPL" ); -MODULE_ALIAS ("platform:imx-ipuv3-vdic" );
This breaks compilation until patch 6/8. I think you need to make some makefile changes also in this patch.
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/media/imx/imx-media-ic.o see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/media/imx/imx-media-vdic.o see include/linux/module.h for more information
ERROR: "imx_media_ic_register" [drivers/staging/media/imx/imx-media.ko] undefined!
ERROR: "imx_media_vdic_register" [drivers/staging/media/imx/imx-media.ko] undefined!
ERROR: "imx_media_vdic_unregister" [drivers/staging/media/imx/imx-media.ko] undefined!
ERROR: "imx_media_ic_unregister" [drivers/staging/media/imx/imx-media.ko] undefined! make[2]: *** [scripts/Makefile.modpost:91: __modpost] Error 1
make[1]: *** [/dev/shm/linux-git/Makefile:1263: modules] Error 2
make: *** [Makefile:170: sub-make] Error 2
---
Cheers,
Rui
Steve Longerbeam
maintainerRe: [PATCH v2 1/8] media: staging/imx: Switch to sync registration for IPU subdevs
Thanks Rui for catching the bisect problem, I will fix for v3.
Steve
Quoted 179 lines · Rui Miguel Silva
Hi Steve,
Quoted 18 lines · Steve Longerbeam
Because the IPU sub-devices VDIC and IC are not present in the device-tree, platform devices were created for them instead. This allowed these sub-devices to be added to the media device's async notifier and registered asynchronously along with the other sub-devices that do have a device-tree presence (CSI and devices external to the IPU and SoC).
But that approach isn't really necessary. The IPU sub-devices don't actually require a backing device (
sd->devis allowed to be NULL). And that approach can't get around the fact that the IPU sub-devices are not part of a device hierarchy, which makes it awkward to retrieve the parent IPU of these devices.By registering them synchronously, they can be registered from the CSI async bound notifier, so the init function for them can be given the CSI subdev, who's
dev->parentis the IPU. That is a somewhat cleaner way to retrieve the parent IPU.Quoted 7 lines
So convert to synchronous registration for the VDIC and IC task sub-devices, at the time a CSI sub-device is bound. There is no longer a backing device for them (
sd->devis NULL), but that's ok. Also set the VDIC/IC sub-device owner as the IPU, so that a reference can be taken on the IPU module.Signed-off-by Steve Longerbeam <[email protected]>I am trying to bisect when my capture starts to fail to work with this series, since they are so many changes and reorg that I got lost on some of them. But... see below.
Quoted 16 lines
--- drivers/staging/media/imx/imx-ic-common.c | 70 ++-- drivers/staging/media/imx/imx-ic-prp.c | 34 +- drivers/staging/media/imx/imx-ic-prpencvf.c | 70 ++-- drivers/staging/media/imx/imx-ic.h | 7 +- drivers/staging/media/imx/imx-media-capture.c | 7 +- drivers/staging/media/imx/imx-media-csi.c | 2 +- drivers/staging/media/imx/imx-media-dev.c | 121 +----- .../staging/media/imx/imx-media-internal-sd.c | 356 ++++++++---------- drivers/staging/media/imx/imx-media-of.c | 38 +- drivers/staging/media/imx/imx-media-vdic.c | 85 ++--- drivers/staging/media/imx/imx-media.h | 67 ++-- drivers/staging/media/imx/imx7-media-csi.c | 3 +- 12 files changed, 325 insertions(+), 535 deletions(-)drivers/staging/media/imx/imx-media-vdic.c +1
-0+ dev_dbg(priv->ipu_dev, "%s: link setup %s -> %s",<snip>
Quoted 101 lines
drivers/staging/media/imx/imx-media-vdic.c +20
-34+ sd->name, remote->entity->name, local->entity->name);mutex_lock (&priv->lock);@@ -864,9 +856,6 @@ static int vdic_registered(struct v4l2_subdev *sd)int i, ret;u32 code; -/* get media device */ - priv->md =dev_get_drvdata (sd->v4l2_dev->dev); -for (i =0 ; i <VDIC_NUM_PADS ; i++) { priv->pad[i].flags = (i ==VDIC_SRC_PAD_DIRECT ) ?MEDIA_PAD_FL_SOURCE :MEDIA_PAD_FL_SINK ;@@ -938,77 +927,55 @@ static const struct v4l2_subdev_internal_ops vdic_internal_ops = { .unregistered = vdic_unregistered, }; -static int imx_vdic_probe (struct platform_device *pdev) +struct v4l2_subdev *imx_media_vdic_register (struct imx_media_dev *imxmd, +struct device *ipu_dev, +struct ipu_soc *ipu, +u32 grp_id) { -struct imx_media_ipu_internal_sd_pdata *pdata; +struct v4l2_device *v4l2_dev = &imxmd->v4l2_dev;struct vdic_priv *priv;int ret; - priv =devm_kzalloc (&pdev->dev,sizeof (*priv),GFP_KERNEL ); + priv =devm_kzalloc (ipu_dev,sizeof (*priv),GFP_KERNEL );if (!priv) -return -ENOMEM ; +return ERR_PTR (-ENOMEM ); -platform_set_drvdata (pdev, &priv->sd); - priv->dev = &pdev->dev; - - pdata = priv->dev->platform_data; - priv->ipu_id = pdata->ipu_id; + priv->ipu_dev = ipu_dev; + priv->ipu = ipu; + priv->md = imxmd;v4l2_subdev_init (&priv->sd, &vdic_subdev_ops);v4l2_set_subdevdata (&priv->sd, priv); priv->sd.internal_ops = &vdic_internal_ops; priv->sd.entity.ops = &vdic_entity_ops; priv->sd.entity.function =MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER ; - priv->sd.dev = &pdev->dev; - priv->sd.owner =THIS_MODULE ; + priv->sd.owner = ipu_dev->driver->owner; priv->sd.flags =V4L2_SUBDEV_FL_HAS_DEVNODE ; -/* get our group id */ - priv->sd.grp_id = pdata->grp_id; -strscpy (priv->sd.name, pdata->sd_name,sizeof (priv->sd.name)); + priv->sd.grp_id = grp_id; +imx_media_grp_id_to_sd_name (priv->sd.name,sizeof (priv->sd.name), + priv->sd.grp_id,ipu_get_num (ipu));mutex_init (&priv->lock); - ret =v4l2_async_register_subdev (&priv->sd); + ret =v4l2_device_register_subdev (v4l2_dev, &priv->sd);if (ret) goto free; -return 0 ; +return &priv->sd; free:mutex_destroy (&priv->lock); -return ret; +return ERR_PTR (ret); } -static int imx_vdic_remove (struct platform_device *pdev) +int imx_media_vdic_unregister (struct v4l2_subdev *sd) { -struct v4l2_subdev *sd =platform_get_drvdata (pdev);struct vdic_priv *priv =v4l2_get_subdevdata (sd);v4l2_info (sd,"Removing\n" ); -v4l2_async_unregister_subdev (sd); +v4l2_device_unregister_subdev (sd);mutex_destroy (&priv->lock);media_entity_cleanup (&sd->entity);return 0 ; } - -static const struct platform_device_id imx_vdic_ids[] = { - { .name ="imx-ipuv3-vdic" }, - { }, -}; -MODULE_DEVICE_TABLE (platform, imx_vdic_ids); - -static struct platform_driver imx_vdic_driver = { - .probe = imx_vdic_probe, - .remove = imx_vdic_remove, - .id_table = imx_vdic_ids,drivers/staging/media/imx/imx-media-vdic.c static const struct v4l2_subdev_internal_ops vdic_internal_ops = { · line 1014
Quoted 10 lines
drivers/staging/media/imx/imx-media-vdic.c +0
-10- .driver = { - .name = "imx-ipuv3-vdic", - }, -}; -module_platform_driver (imx_vdic_driver); - -MODULE_DESCRIPTION ("i.MX VDIC subdev driver" ); -MODULE_AUTHOR ("Steve Longerbeam <[email protected]>" ); -MODULE_LICENSE ("GPL" ); -MODULE_ALIAS ("platform:imx-ipuv3-vdic" );This breaks compilation until patch 6/8. I think you need to make some makefile changes also in this patch.
WARNING: modpost: missing
MODULE_LICENSE()indrivers/staging/media/imx/imx-media-ic.oseeinclude/linux/module.hfor more information
WARNING: modpost: missingMODULE_LICENSE()indrivers/staging/media/imx/imx-media-vdic.oseeinclude/linux/module.hfor more information
ERROR: "imx_media_ic_register" [drivers/staging/media/imx/imx-media.ko] undefined!
ERROR: "imx_media_vdic_register" [drivers/staging/media/imx/imx-media.ko] undefined!
ERROR: "imx_media_vdic_unregister" [drivers/staging/media/imx/imx-media.ko] undefined!
ERROR: "imx_media_ic_unregister" [drivers/staging/media/imx/imx-media.ko] undefined! make[2]: *** [scripts/Makefile.modpost:91:__modpost] Error 1
make[1]: *** [/dev/shm/linux-git/Makefile:1263: modules] Error 2
make: *** [Makefile:170: sub-make] Error 2---
Cheers,
Rui
Steve Longerbeam
maintainerPATCH v2 2/8 media: staging/imx: Pass device to alloc/free_dma_buf
In reply to Steve LongerbeamAllocate and free a DMA coherent buffer in imx_media_alloc/free_dma_buf() from the given device. This allows DMA alloc and free using a device that is backed by real hardware, which for the imx5/6/7 CSI is the CSI unit, and for the internal IPU sub-devices, is the parent IPU.
--- drivers/staging/media/imx/imx-ic-prpencvf.c | 18 +++++++++--------- drivers/staging/media/imx/imx-media-csi.c | 6 +++--- drivers/staging/media/imx/imx-media-utils.c | 13 ++++++------- drivers/staging/media/imx/imx-media.h | 4 ++-- drivers/staging/media/imx/imx7-media-csi.c | 4 ++-- 5 files changed, 22 insertions(+), 23 deletions(-)
drivers/staging/media/imx/imx-ic-prpencvf.c +9 -9
@@ -464,13 +464,13 @@ static int prp_setup_rotation(struct prp_priv *priv) incc = priv->cc[PRPENCVF_SINK_PAD ]; outcc = vdev->cc; - ret =imx_media_alloc_dma_buf (ic_priv->md, &priv->rot_buf[0 ], + ret =imx_media_alloc_dma_buf (ic_priv->ipu_dev, &priv->rot_buf[0 ], outfmt->sizeimage);if (ret) {v4l2_err (&ic_priv->sd,"failed to alloc rot_buf[0], %d\n" , ret);return ret; } - ret =imx_media_alloc_dma_buf (ic_priv->md, &priv->rot_buf[1 ], + ret =imx_media_alloc_dma_buf (ic_priv->ipu_dev, &priv->rot_buf[1 ], outfmt->sizeimage);if (ret) {v4l2_err (&ic_priv->sd,"failed to alloc rot_buf[1], %d\n" , ret);
@@ -543,9 +543,9 @@ static int prp_setup_rotation(struct prp_priv *priv) unsetup_vb2:prp_unsetup_vb2_buf (priv,VB2_BUF_STATE_QUEUED ); free_rot1: -imx_media_free_dma_buf (ic_priv->md, &priv->rot_buf[1 ]); +imx_media_free_dma_buf (ic_priv->ipu_dev, &priv->rot_buf[1 ]); free_rot0: -imx_media_free_dma_buf (ic_priv->md, &priv->rot_buf[0 ]); +imx_media_free_dma_buf (ic_priv->ipu_dev, &priv->rot_buf[0 ]);return ret; }
@@ -563,8 +563,8 @@ static void prp_unsetup_rotation(struct prp_priv *priv)ipu_ic_disable (priv->ic); -imx_media_free_dma_buf (ic_priv->md, &priv->rot_buf[0 ]); -imx_media_free_dma_buf (ic_priv->md, &priv->rot_buf[1 ]); +imx_media_free_dma_buf (ic_priv->ipu_dev, &priv->rot_buf[0 ]); +imx_media_free_dma_buf (ic_priv->ipu_dev, &priv->rot_buf[1 ]); }static int prp_setup_norotation (struct prp_priv *priv)
@@ -656,7 +656,7 @@ static int prp_start(struct prp_priv *priv) outfmt = &vdev->fmt.fmt.pix; - ret =imx_media_alloc_dma_buf (ic_priv->md, &priv->underrun_buf, + ret =imx_media_alloc_dma_buf (ic_priv->ipu_dev, &priv->underrun_buf, outfmt->sizeimage);if (ret) goto out_put_ipu;
@@ -726,7 +726,7 @@ static int prp_start(struct prp_priv *priv) out_unsetup:prp_unsetup (priv,VB2_BUF_STATE_QUEUED ); out_free_underrun: -imx_media_free_dma_buf (ic_priv->md, &priv->underrun_buf); +imx_media_free_dma_buf (ic_priv->ipu_dev, &priv->underrun_buf); out_put_ipu:prp_put_ipu_resources (priv);return ret;
@@ -763,7 +763,7 @@ static void prp_stop(struct prp_priv *priv)prp_unsetup (priv,VB2_BUF_STATE_ERROR ); -imx_media_free_dma_buf (ic_priv->md, &priv->underrun_buf); +imx_media_free_dma_buf (ic_priv->ipu_dev, &priv->underrun_buf);/* cancel the EOF timeout timer */ del_timer_sync (&priv->eof_timeout_timer);
drivers/staging/media/imx/imx-media-csi.c +3 -3
@@ -612,7 +612,7 @@ static int csi_idmac_start(struct csi_priv *priv) outfmt = &vdev->fmt.fmt.pix; - ret =imx_media_alloc_dma_buf (priv->md, &priv->underrun_buf, + ret =imx_media_alloc_dma_buf (priv->dev, &priv->underrun_buf, outfmt->sizeimage);if (ret) goto out_put_ipu;
@@ -666,7 +666,7 @@ static int csi_idmac_start(struct csi_priv *priv) out_unsetup:csi_idmac_unsetup (priv,VB2_BUF_STATE_QUEUED ); out_free_dma_buf: -imx_media_free_dma_buf (priv->md, &priv->underrun_buf); +imx_media_free_dma_buf (priv->dev, &priv->underrun_buf); out_put_ipu:csi_idmac_put_ipu_resources (priv);return ret;
@@ -698,7 +698,7 @@ static void csi_idmac_stop(struct csi_priv *priv)csi_idmac_unsetup (priv,VB2_BUF_STATE_ERROR ); -imx_media_free_dma_buf (priv->md, &priv->underrun_buf); +imx_media_free_dma_buf (priv->dev, &priv->underrun_buf);/* cancel the EOF timeout timer */ del_timer_sync (&priv->eof_timeout_timer);
drivers/staging/media/imx/imx-media-utils.c +6 -7
@@ -679,29 +679,28 @@ int imx_media_ipu_image_to_mbus_fmt(struct v4l2_mbus_framefmt *mbus, }EXPORT_SYMBOL_GPL (imx_media_ipu_image_to_mbus_fmt); -void imx_media_free_dma_buf (struct imx_media_dev *imxmd, +void imx_media_free_dma_buf (struct device *dev,struct imx_media_dma_buf *buf) {if (buf->virt) -dma_free_coherent (imxmd->md.dev, buf->len, - buf->virt, buf->phys); +dma_free_coherent (dev, buf->len, buf->virt, buf->phys); buf->virt =NULL ; buf->phys =0 ; }EXPORT_SYMBOL_GPL (imx_media_free_dma_buf); -int imx_media_alloc_dma_buf (struct imx_media_dev *imxmd, +int imx_media_alloc_dma_buf (struct device *dev,struct imx_media_dma_buf *buf,int size) { -imx_media_free_dma_buf (imxmd, buf); +imx_media_free_dma_buf (dev, buf); buf->len =PAGE_ALIGN (size); - buf->virt =dma_alloc_coherent (imxmd->md.dev, buf->len, &buf->phys, + buf->virt =dma_alloc_coherent (dev, buf->len, &buf->phys,GFP_DMA |GFP_KERNEL );if (!buf->virt) { -dev_err (imxmd->md.dev,"failed to alloc dma buffer\n" ); +dev_err (dev,"%s: failed\n" , __func__);return -ENOMEM ; }
drivers/staging/media/imx/imx-media.h +2 -2
@@ -208,9 +208,9 @@ struct imx_media_dma_buf {unsigned long len; }; -void imx_media_free_dma_buf (struct imx_media_dev *imxmd, +void imx_media_free_dma_buf (struct device *dev,struct imx_media_dma_buf *buf); -int imx_media_alloc_dma_buf (struct imx_media_dev *imxmd, +int imx_media_alloc_dma_buf (struct device *dev,struct imx_media_dma_buf *buf,int size);
drivers/staging/media/imx/imx7-media-csi.c +2 -2
@@ -714,7 +714,7 @@ static int imx7_csi_dma_start(struct imx7_csi *csi)struct v4l2_pix_format *out_pix = &vdev->fmt.fmt.pix;int ret; - ret =imx_media_alloc_dma_buf (csi->imxmd, &csi->underrun_buf, + ret =imx_media_alloc_dma_buf (csi->dev, &csi->underrun_buf, out_pix->sizeimage);if (ret <0 ) {v4l2_warn (&csi->sd,"consider increasing the CMA area\n" );
@@ -754,7 +754,7 @@ static void imx7_csi_dma_stop(struct imx7_csi *csi)imx7_csi_dma_unsetup_vb2_buf (csi,VB2_BUF_STATE_ERROR ); -imx_media_free_dma_buf (csi->imxmd, &csi->underrun_buf); +imx_media_free_dma_buf (csi->dev, &csi->underrun_buf); }static int imx7_csi_configure (struct imx7_csi *csi)
Signature · 1 line
2.17.1
Steve Longerbeam
maintainerPATCH v2 3/8 media: staging/imx: Move add_video_device into capture_device_register
In reply to Steve LongerbeamMove imx_media_add_video_device() into imx_media_capture_device_register(). Also the former has no error conditions to convert to void.
--- drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ----- drivers/staging/media/imx/imx-media-capture.c | 3 +++ drivers/staging/media/imx/imx-media-csi.c | 7 +------ drivers/staging/media/imx/imx-media-utils.c | 9 ++++----- drivers/staging/media/imx/imx-media.h | 4 ++-- drivers/staging/media/imx/imx7-media-csi.c | 12 +----------- 6 files changed, 11 insertions(+), 29 deletions(-)
drivers/staging/media/imx/imx-ic-prpencvf.c +0 -5
@@ -1241,7 +1241,6 @@ static int prp_s_frame_interval(struct v4l2_subdev *sd,static int prp_registered (struct v4l2_subdev *sd) {struct prp_priv *priv =sd_to_priv (sd); -struct imx_ic_priv *ic_priv = priv->ic_priv;int i, ret;u32 code;
@@ -1271,10 +1270,6 @@ static int prp_registered(struct v4l2_subdev *sd)if (ret)return ret; - ret =imx_media_add_video_device (ic_priv->md, priv->vdev); -if (ret) - goto unreg; - ret =prp_init_controls (priv);if (ret) goto unreg;
drivers/staging/media/imx/imx-media-capture.c +3 -0
@@ -780,6 +780,9 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev) vfd->ctrl_handler = &priv->ctrl_hdlr; +/* add vdev to the video device list */ +imx_media_add_video_device (priv->md, vdev); +return 0 ; unreg:video_unregister_device (vfd);
drivers/staging/media/imx/imx-media-csi.c +1 -6
@@ -1820,13 +1820,8 @@ static int csi_registered(struct v4l2_subdev *sd)if (ret) goto free_fim; - ret =imx_media_add_video_device (priv->md, priv->vdev); -if (ret) - goto unreg; -return 0 ; -unreg: -imx_media_capture_device_unregister (priv->vdev); + free_fim:if (priv->fim)imx_media_fim_free (priv->fim);
drivers/staging/media/imx/imx-media-utils.c +4 -5
@@ -767,18 +767,17 @@ imx_media_find_subdev_by_devname(struct imx_media_dev *imxmd,EXPORT_SYMBOL_GPL (imx_media_find_subdev_by_devname);/* -* Adds a video device to the master video device list. This is called by -* an async subdev that owns a video device when it is registered. +* Adds a video device to the master video device list. This is called +* when a video device is registered. */ -int imx_media_add_video_device (struct imx_media_dev *imxmd, -struct imx_media_video_dev *vdev) +void imx_media_add_video_device (struct imx_media_dev *imxmd, +struct imx_media_video_dev *vdev) {mutex_lock (&imxmd->mutex);list_add_tail (&vdev->list, &imxmd->vdev_list);mutex_unlock (&imxmd->mutex); -return 0 ; }EXPORT_SYMBOL_GPL (imx_media_add_video_device);
drivers/staging/media/imx/imx-media.h +2 -2
@@ -189,8 +189,8 @@ imx_media_find_subdev_by_fwnode(struct imx_media_dev *imxmd,struct v4l2_subdev *imx_media_find_subdev_by_devname (struct imx_media_dev *imxmd,const char *devname); -int imx_media_add_video_device (struct imx_media_dev *imxmd, -struct imx_media_video_dev *vdev); +void imx_media_add_video_device (struct imx_media_dev *imxmd, +struct imx_media_video_dev *vdev);int imx_media_find_mipi_csi2_channel (struct imx_media_dev *imxmd,struct media_entity *start_entity); struct media_pad *
drivers/staging/media/imx/imx7-media-csi.c +1 -11
@@ -1126,17 +1126,7 @@ static int imx7_csi_registered(struct v4l2_subdev *sd)if (ret <0 )return ret; - ret =imx_media_capture_device_register (csi->vdev); -if (ret <0 ) -return ret; - - ret =imx_media_add_video_device (csi->imxmd, csi->vdev); -if (ret <0 ) { -imx_media_capture_device_unregister (csi->vdev); -return ret; - } - -return 0 ; +return imx_media_capture_device_register (csi->vdev); }static void imx7_csi_unregistered (struct v4l2_subdev *sd)
Signature · 1 line
2.17.1
Steve Longerbeam
maintainerPATCH v2 4/8 Revert "media: imx: Set capture compose rectangle in capture_device_set_format"
In reply to Steve LongerbeamRvert this commit, as imx_media_capture_device_set_format() will be removed.
This reverts commit 5964cbd8692252615370b77eb96764dd70c2f837.
--- drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++-- drivers/staging/media/imx/imx-media-capture.c | 24 +++++++++---------- drivers/staging/media/imx/imx-media-csi.c | 5 ++-- drivers/staging/media/imx/imx-media-utils.c | 20 ++++------------ drivers/staging/media/imx/imx-media.h | 6 ++--- 5 files changed, 23 insertions(+), 37 deletions(-)
drivers/staging/media/imx/imx-ic-prpencvf.c +2 -3
@@ -910,7 +910,6 @@ static int prp_set_fmt(struct v4l2_subdev *sd,const struct imx_media_pixfmt *cc;struct v4l2_pix_format vdev_fmt;struct v4l2_mbus_framefmt *fmt; -struct v4l2_rect vdev_compose;int ret =0 ;if (sdformat->pad >=PRPENCVF_NUM_PADS )
@@ -952,11 +951,11 @@ static int prp_set_fmt(struct v4l2_subdev *sd, priv->cc[sdformat->pad] = cc;/* propagate output pad format to capture device */ -imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &vdev_compose, +imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &priv->format_mbus[PRPENCVF_SRC_PAD ], priv->cc[PRPENCVF_SRC_PAD ]);mutex_unlock (&priv->lock); -imx_media_capture_device_set_format (vdev, &vdev_fmt, &vdev_compose); +imx_media_capture_device_set_format (vdev, &vdev_fmt);return 0 ; out:
drivers/staging/media/imx/imx-media-capture.c +12 -12
@@ -205,8 +205,7 @@ static int capture_g_fmt_vid_cap(struct file *file, void *fh,static int __capture_try_fmt_vid_cap (struct capture_priv *priv,struct v4l2_subdev_format *fmt_src, -struct v4l2_format *f, -struct v4l2_rect *compose) +struct v4l2_format *f) {const struct imx_media_pixfmt *cc, *cc_src;
@@ -246,8 +245,7 @@ static int __capture_try_fmt_vid_cap(struct capture_priv *priv, } } -imx_media_mbus_fmt_to_pix_fmt (&f->fmt.pix, compose, - &fmt_src->format, cc); +imx_media_mbus_fmt_to_pix_fmt (&f->fmt.pix, &fmt_src->format, cc);return 0 ; }
@@ -265,7 +263,7 @@ static int capture_try_fmt_vid_cap(struct file *file, void *fh,if (ret)return ret; -return __capture_try_fmt_vid_cap (priv, &fmt_src, f,NULL ); +return __capture_try_fmt_vid_cap (priv, &fmt_src, f); } static int capture_s_fmt_vid_cap(struct file *file, void *fh,
@@ -273,7 +271,6 @@ static int capture_s_fmt_vid_cap(struct file *file, void *fh, {struct capture_priv *priv =video_drvdata (file);struct v4l2_subdev_format fmt_src; -struct v4l2_rect compose;int ret;if (vb2_is_busy (&priv->q)) {
@@ -287,14 +284,17 @@ static int capture_s_fmt_vid_cap(struct file *file, void *fh,if (ret)return ret; - ret =__capture_try_fmt_vid_cap (priv, &fmt_src, f, &compose); + ret =__capture_try_fmt_vid_cap (priv, &fmt_src, f);if (ret)return ret; priv->vdev.fmt.fmt.pix = f->fmt.pix; priv->vdev.cc =imx_media_find_format (f->fmt.pix.pixelformat,CS_SEL_ANY , true); - priv->vdev.compose = compose; + priv->vdev.compose.left =0 ; + priv->vdev.compose.top =0 ; + priv->vdev.compose.width = fmt_src.format.width; + priv->vdev.compose.height = fmt_src.format.height;return 0 ; }
@@ -655,8 +655,7 @@ static struct video_device capture_videodev = { };void imx_media_capture_device_set_format (struct imx_media_video_dev *vdev, -const struct v4l2_pix_format *pix, -const struct v4l2_rect *compose) +struct v4l2_pix_format *pix) {struct capture_priv *priv =to_capture_priv (vdev);
@@ -664,7 +663,6 @@ void imx_media_capture_device_set_format(struct imx_media_video_dev *vdev, priv->vdev.fmt.fmt.pix = *pix; priv->vdev.cc =imx_media_find_format (pix->pixelformat,CS_SEL_ANY , true); - priv->vdev.compose = *compose;mutex_unlock (&priv->mutex); }EXPORT_SYMBOL_GPL (imx_media_capture_device_set_format);
@@ -770,8 +768,10 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev) } vdev->fmt.type =V4L2_BUF_TYPE_VIDEO_CAPTURE ; -imx_media_mbus_fmt_to_pix_fmt (&vdev->fmt.fmt.pix, &vdev->compose, +imx_media_mbus_fmt_to_pix_fmt (&vdev->fmt.fmt.pix, &fmt_src.format,NULL ); + vdev->compose.width = fmt_src.format.width; + vdev->compose.height = fmt_src.format.height; vdev->cc =imx_media_find_format (vdev->fmt.fmt.pix.pixelformat,CS_SEL_ANY , false);
drivers/staging/media/imx/imx-media-csi.c +2 -3
@@ -1512,7 +1512,6 @@ static int csi_set_fmt(struct v4l2_subdev *sd,struct v4l2_pix_format vdev_fmt;struct v4l2_mbus_framefmt *fmt;struct v4l2_rect *crop, *compose; -struct v4l2_rect vdev_compose;int ret;if (sdformat->pad >=CSI_NUM_PADS )
@@ -1568,11 +1567,11 @@ static int csi_set_fmt(struct v4l2_subdev *sd, priv->cc[sdformat->pad] = cc;/* propagate IDMAC output pad format to capture device */ -imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &vdev_compose, +imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &priv->format_mbus[CSI_SRC_PAD_IDMAC ], priv->cc[CSI_SRC_PAD_IDMAC ]);mutex_unlock (&priv->lock); -imx_media_capture_device_set_format (vdev, &vdev_fmt, &vdev_compose); +imx_media_capture_device_set_format (vdev, &vdev_fmt);return 0 ; out:
drivers/staging/media/imx/imx-media-utils.c +5 -15
@@ -577,8 +577,7 @@ void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt,EXPORT_SYMBOL_GPL (imx_media_fill_default_mbus_fields);int imx_media_mbus_fmt_to_pix_fmt (struct v4l2_pix_format *pix, -struct v4l2_rect *compose, -const struct v4l2_mbus_framefmt *mbus, +struct v4l2_mbus_framefmt *mbus,const struct imx_media_pixfmt *cc) {u32 width;
@@ -625,17 +624,6 @@ int imx_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, pix->sizeimage = cc->planar ? ((stride * pix->height * cc->bpp) >>3 ) : stride * pix->height; -/* -* set capture compose rectangle, which is fixed to the -* source subdevice mbus format. -*/ -if (compose) { - compose->left =0 ; - compose->top =0 ; - compose->width = mbus->width; - compose->height = mbus->height; - } -return 0 ; }EXPORT_SYMBOL_GPL (imx_media_mbus_fmt_to_pix_fmt);
@@ -647,11 +635,13 @@ int imx_media_mbus_fmt_to_ipu_image(struct ipu_image *image,memset (image,0 ,sizeof (*image)); - ret =imx_media_mbus_fmt_to_pix_fmt (&image->pix, &image->rect, - mbus,NULL ); + ret =imx_media_mbus_fmt_to_pix_fmt (&image->pix, mbus,NULL );if (ret)return ret; + image->rect.width = mbus->width; + image->rect.height = mbus->height; +return 0 ; }EXPORT_SYMBOL_GPL (imx_media_mbus_fmt_to_ipu_image);
drivers/staging/media/imx/imx-media.h +2 -4
@@ -174,8 +174,7 @@ void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt,struct v4l2_mbus_framefmt *fmt, bool ic_route);int imx_media_mbus_fmt_to_pix_fmt (struct v4l2_pix_format *pix, -struct v4l2_rect *compose, -const struct v4l2_mbus_framefmt *mbus, +struct v4l2_mbus_framefmt *mbus,const struct imx_media_pixfmt *cc);int imx_media_mbus_fmt_to_ipu_image (struct ipu_image *image,struct v4l2_mbus_framefmt *mbus);
@@ -280,8 +279,7 @@ void imx_media_capture_device_unregister(struct imx_media_video_dev *vdev);struct imx_media_buffer *imx_media_capture_device_next_buf (struct imx_media_video_dev *vdev);void imx_media_capture_device_set_format (struct imx_media_video_dev *vdev, -const struct v4l2_pix_format *pix, -const struct v4l2_rect *compose); +struct v4l2_pix_format *pix);void imx_media_capture_device_error (struct imx_media_video_dev *vdev);/* subdev group ids */
Signature · 1 line
2.17.1
Re: [PATCH v2 4/8] Revert "media: imx: Set capture compose rectangle in capture_device_set_format"
Hi Steve,
Quoted 210 lines · Steve Longerbeam
Rvert this commit, as
imx_media_capture_device_set_format()will be removed.This reverts commit
5964cbd8692252615370b77eb96764dd70c2f837.Signed-off-by Steve Longerbeam <[email protected]>--- drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++-- drivers/staging/media/imx/imx-media-capture.c | 24 +++++++++---------- drivers/staging/media/imx/imx-media-csi.c | 5 ++-- drivers/staging/media/imx/imx-media-utils.c | 20 ++++------------ drivers/staging/media/imx/imx-media.h | 6 ++--- 5 files changed, 23 insertions(+), 37 deletions(-)drivers/staging/media/imx/imx-ic-prpencvf.c +2
-3@@ -910,7 +910,6 @@ static int prp_set_fmt(struct v4l2_subdev *sd,const struct imx_media_pixfmt *cc;struct v4l2_pix_format vdev_fmt;struct v4l2_mbus_framefmt *fmt; -struct v4l2_rect vdev_compose;int ret =0 ;if (sdformat->pad >=PRPENCVF_NUM_PADS )@@ -952,11 +951,11 @@ static int prp_set_fmt(struct v4l2_subdev *sd, priv->cc[sdformat->pad] = cc;/* propagate output pad format to capture device */ -imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &vdev_compose, +imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &priv->format_mbus[PRPENCVF_SRC_PAD ], priv->cc[PRPENCVF_SRC_PAD ]);mutex_unlock (&priv->lock); -imx_media_capture_device_set_format (vdev, &vdev_fmt, &vdev_compose); +imx_media_capture_device_set_format (vdev, &vdev_fmt);return 0 ; out:drivers/staging/media/imx/imx-media-capture.c +12
-12@@ -205,8 +205,7 @@ static int capture_g_fmt_vid_cap(struct file *file, void *fh,static int __capture_try_fmt_vid_cap (struct capture_priv *priv,struct v4l2_subdev_format *fmt_src, -struct v4l2_format *f, -struct v4l2_rect *compose) +struct v4l2_format *f) {const struct imx_media_pixfmt *cc, *cc_src;@@ -246,8 +245,7 @@ static int __capture_try_fmt_vid_cap(struct capture_priv *priv, } } -imx_media_mbus_fmt_to_pix_fmt (&f->fmt.pix, compose, - &fmt_src->format, cc); +imx_media_mbus_fmt_to_pix_fmt (&f->fmt.pix, &fmt_src->format, cc);return 0 ; }@@ -265,7 +263,7 @@ static int capture_try_fmt_vid_cap(struct file *file, void *fh,if (ret)return ret; -return __capture_try_fmt_vid_cap (priv, &fmt_src, f,NULL ); +return __capture_try_fmt_vid_cap (priv, &fmt_src, f); } static int capture_s_fmt_vid_cap(struct file *file, void *fh,@@ -273,7 +271,6 @@ static int capture_s_fmt_vid_cap(struct file *file, void *fh, {struct capture_priv *priv =video_drvdata (file);struct v4l2_subdev_format fmt_src; -struct v4l2_rect compose;int ret;if (vb2_is_busy (&priv->q)) {@@ -287,14 +284,17 @@ static int capture_s_fmt_vid_cap(struct file *file, void *fh,if (ret)return ret; - ret =__capture_try_fmt_vid_cap (priv, &fmt_src, f, &compose); + ret =__capture_try_fmt_vid_cap (priv, &fmt_src, f);if (ret)return ret; priv->vdev.fmt.fmt.pix = f->fmt.pix; priv->vdev.cc =imx_media_find_format (f->fmt.pix.pixelformat,CS_SEL_ANY , true); - priv->vdev.compose = compose; + priv->vdev.compose.left =0 ; + priv->vdev.compose.top =0 ; + priv->vdev.compose.width = fmt_src.format.width; + priv->vdev.compose.height = fmt_src.format.height;return 0 ; }@@ -655,8 +655,7 @@ static struct video_device capture_videodev = { };void imx_media_capture_device_set_format (struct imx_media_video_dev *vdev, -const struct v4l2_pix_format *pix, -const struct v4l2_rect *compose) +struct v4l2_pix_format *pix) {struct capture_priv *priv =to_capture_priv (vdev);@@ -664,7 +663,6 @@ void imx_media_capture_device_set_format(struct imx_media_video_dev *vdev, priv->vdev.fmt.fmt.pix = *pix; priv->vdev.cc =imx_media_find_format (pix->pixelformat,CS_SEL_ANY , true); - priv->vdev.compose = *compose;mutex_unlock (&priv->mutex); }EXPORT_SYMBOL_GPL (imx_media_capture_device_set_format);@@ -770,8 +768,10 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev) } vdev->fmt.type =V4L2_BUF_TYPE_VIDEO_CAPTURE ; -imx_media_mbus_fmt_to_pix_fmt (&vdev->fmt.fmt.pix, &vdev->compose, +imx_media_mbus_fmt_to_pix_fmt (&vdev->fmt.fmt.pix, &fmt_src.format,NULL ); + vdev->compose.width = fmt_src.format.width; + vdev->compose.height = fmt_src.format.height; vdev->cc =imx_media_find_format (vdev->fmt.fmt.pix.pixelformat,CS_SEL_ANY , false);drivers/staging/media/imx/imx-media-csi.c +2
-3@@ -1512,7 +1512,6 @@ static int csi_set_fmt(struct v4l2_subdev *sd,struct v4l2_pix_format vdev_fmt;struct v4l2_mbus_framefmt *fmt;struct v4l2_rect *crop, *compose; -struct v4l2_rect vdev_compose;int ret;if (sdformat->pad >=CSI_NUM_PADS )@@ -1568,11 +1567,11 @@ static int csi_set_fmt(struct v4l2_subdev *sd, priv->cc[sdformat->pad] = cc;/* propagate IDMAC output pad format to capture device */ -imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &vdev_compose, +imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &priv->format_mbus[CSI_SRC_PAD_IDMAC ], priv->cc[CSI_SRC_PAD_IDMAC ]);mutex_unlock (&priv->lock); -imx_media_capture_device_set_format (vdev, &vdev_fmt, &vdev_compose); +imx_media_capture_device_set_format (vdev, &vdev_fmt);return 0 ; out:drivers/staging/media/imx/imx-media-utils.c +5
-15@@ -577,8 +577,7 @@ void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt,EXPORT_SYMBOL_GPL (imx_media_fill_default_mbus_fields);int imx_media_mbus_fmt_to_pix_fmt (struct v4l2_pix_format *pix, -struct v4l2_rect *compose, -const struct v4l2_mbus_framefmt *mbus, +struct v4l2_mbus_framefmt *mbus,const struct imx_media_pixfmt *cc) {u32 width;@@ -625,17 +624,6 @@ int imx_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, pix->sizeimage = cc->planar ? ((stride * pix->height * cc->bpp) >>3 ) : stride * pix->height; -/* -* set capture compose rectangle, which is fixed to the -* source subdevice mbus format. -*/ -if (compose) { - compose->left =0 ; - compose->top =0 ; - compose->width = mbus->width; - compose->height = mbus->height; - } -return 0 ; }EXPORT_SYMBOL_GPL (imx_media_mbus_fmt_to_pix_fmt);@@ -647,11 +635,13 @@ int imx_media_mbus_fmt_to_ipu_image(struct ipu_image *image,memset (image,0 ,sizeof (*image)); - ret =imx_media_mbus_fmt_to_pix_fmt (&image->pix, &image->rect, - mbus,NULL ); + ret =imx_media_mbus_fmt_to_pix_fmt (&image->pix, mbus,NULL );if (ret)return ret; + image->rect.width = mbus->width; + image->rect.height = mbus->height; +return 0 ; }EXPORT_SYMBOL_GPL (imx_media_mbus_fmt_to_ipu_image);drivers/staging/media/imx/imx-media.h +0
-0
drivers/staging/media/imx/imx-media.h void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt, · line 178
Quoted 7 lines
drivers/staging/media/imx/imx-media.h +1
-2@@ -174,8 +174,7 @@ void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt,struct v4l2_mbus_framefmt *fmt, bool ic_route);int imx_media_mbus_fmt_to_pix_fmt (struct v4l2_pix_format *pix, -struct v4l2_rect *compose, -const struct v4l2_mbus_framefmt *mbus, +struct v4l2_mbus_framefmt *mbus,const struct imx_media_pixfmt *cc);
Also here you change this function arguments and only remove it from imx7-media-csi.c in the next patch, triggering:
vers/staging/media/imx/imx7-media-csi.c: In function 'imx7_csi_set_fmt':drivers/staging/media/imx/imx7-media-csi.c:1089:43: error: passing argument 2 of 'imx_media_mbus_fmt_to_pix_fmt' from incompatible pointer type [-Werror=incompatible-pointer-types]
imx_media_mbus_fmt_to_pix_fmt(&vdev_fmt, &vdev_compose,
^~~~~~~~~~~~~
In file included from drivers/staging/media/imx/imx7-media-csi.c:30:drivers/staging/media/imx/imx-media.h:177:34: note: expected 'struct v4l2_mbus_framefmt *' but argument is of type 'struct v4l2_rect *'
struct v4l2_mbus_framefmt *mbus,
~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~drivers/staging/media/imx/imx7-media-csi.c:1090:11: error: passing argument 3 of 'imx_media_mbus_fmt_to_pix_fmt' from incompatible pointer type [-Werror=incompatible-pointer-types]
&csi->format_mbus[IMX7_CSI_PAD_SRC],
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/staging/media/imx/imx7-media-csi.c:30:
drivers/staging/media/imx/imx-media.h:178:38: note: expected 'const struct imx_media_pixfmt *' but argument is of type 'struct v4l2_mbus_framefmt *'
const struct imx_media_pixfmt *cc);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~drivers/staging/media/imx/imx7-media-csi.c:1089:2: error: too many arguments to function 'imx_media_mbus_fmt_to_pix_fmt'
imx_media_mbus_fmt_to_pix_fmt(&vdev_fmt, &vdev_compose,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/staging/media/imx/imx7-media-csi.c:30:drivers/staging/media/imx/imx-media.h:176:5: note: declared here
int imx_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/media/imx/imx7-media-csi.c:1093:2: error: too many arguments to function 'imx_media_capture_device_set_format'
imx_media_capture_device_set_format(vdev, &vdev_fmt, &vdev_compose); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/staging/media/imx/imx7-media-csi.c:30:drivers/staging/media/imx/imx-media.h:281:6: note: declared here
void imx_media_capture_device_set_format(struct imx_media_video_dev *vdev,
---
Cheers,
Rui
Steve Longerbeam
maintainerRe: [PATCH v2 4/8] Revert "media: imx: Set capture compose rectangle in capture_device_set_format"
Yes, because the reverted commit was merged before the imx7 support, I will fix this for v3.
Steve
Quoted 256 lines · Rui Miguel Silva
Hi Steve,
Quoted 210 lines · Steve Longerbeam
Rvert this commit, as
imx_media_capture_device_set_format()will be removed.This reverts commit
5964cbd8692252615370b77eb96764dd70c2f837.Signed-off-by Steve Longerbeam <[email protected]>--- drivers/staging/media/imx/imx-ic-prpencvf.c | 5 ++-- drivers/staging/media/imx/imx-media-capture.c | 24 +++++++++---------- drivers/staging/media/imx/imx-media-csi.c | 5 ++-- drivers/staging/media/imx/imx-media-utils.c | 20 ++++------------ drivers/staging/media/imx/imx-media.h | 6 ++--- 5 files changed, 23 insertions(+), 37 deletions(-)drivers/staging/media/imx/imx-ic-prpencvf.c +2
-3@@ -910,7 +910,6 @@ static int prp_set_fmt(struct v4l2_subdev *sd,const struct imx_media_pixfmt *cc;struct v4l2_pix_format vdev_fmt;struct v4l2_mbus_framefmt *fmt; -struct v4l2_rect vdev_compose;int ret =0 ;if (sdformat->pad >=PRPENCVF_NUM_PADS )@@ -952,11 +951,11 @@ static int prp_set_fmt(struct v4l2_subdev *sd, priv->cc[sdformat->pad] = cc;/* propagate output pad format to capture device */ -imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &vdev_compose, +imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &priv->format_mbus[PRPENCVF_SRC_PAD ], priv->cc[PRPENCVF_SRC_PAD ]);mutex_unlock (&priv->lock); -imx_media_capture_device_set_format (vdev, &vdev_fmt, &vdev_compose); +imx_media_capture_device_set_format (vdev, &vdev_fmt);return 0 ; out:drivers/staging/media/imx/imx-media-capture.c +12
-12@@ -205,8 +205,7 @@ static int capture_g_fmt_vid_cap(struct file *file, void *fh,static int __capture_try_fmt_vid_cap (struct capture_priv *priv,struct v4l2_subdev_format *fmt_src, -struct v4l2_format *f, -struct v4l2_rect *compose) +struct v4l2_format *f) {const struct imx_media_pixfmt *cc, *cc_src;@@ -246,8 +245,7 @@ static int __capture_try_fmt_vid_cap(struct capture_priv *priv, } } -imx_media_mbus_fmt_to_pix_fmt (&f->fmt.pix, compose, - &fmt_src->format, cc); +imx_media_mbus_fmt_to_pix_fmt (&f->fmt.pix, &fmt_src->format, cc);return 0 ; }@@ -265,7 +263,7 @@ static int capture_try_fmt_vid_cap(struct file *file, void *fh,if (ret)return ret; -return __capture_try_fmt_vid_cap (priv, &fmt_src, f,NULL ); +return __capture_try_fmt_vid_cap (priv, &fmt_src, f); } static int capture_s_fmt_vid_cap(struct file *file, void *fh,@@ -273,7 +271,6 @@ static int capture_s_fmt_vid_cap(struct file *file, void *fh, {struct capture_priv *priv =video_drvdata (file);struct v4l2_subdev_format fmt_src; -struct v4l2_rect compose;int ret;if (vb2_is_busy (&priv->q)) {@@ -287,14 +284,17 @@ static int capture_s_fmt_vid_cap(struct file *file, void *fh,if (ret)return ret; - ret =__capture_try_fmt_vid_cap (priv, &fmt_src, f, &compose); + ret =__capture_try_fmt_vid_cap (priv, &fmt_src, f);if (ret)return ret; priv->vdev.fmt.fmt.pix = f->fmt.pix; priv->vdev.cc =imx_media_find_format (f->fmt.pix.pixelformat,CS_SEL_ANY , true); - priv->vdev.compose = compose; + priv->vdev.compose.left =0 ; + priv->vdev.compose.top =0 ; + priv->vdev.compose.width = fmt_src.format.width; + priv->vdev.compose.height = fmt_src.format.height;return 0 ; }@@ -655,8 +655,7 @@ static struct video_device capture_videodev = { };void imx_media_capture_device_set_format (struct imx_media_video_dev *vdev, -const struct v4l2_pix_format *pix, -const struct v4l2_rect *compose) +struct v4l2_pix_format *pix) {struct capture_priv *priv =to_capture_priv (vdev);@@ -664,7 +663,6 @@ void imx_media_capture_device_set_format(struct imx_media_video_dev *vdev, priv->vdev.fmt.fmt.pix = *pix; priv->vdev.cc =imx_media_find_format (pix->pixelformat,CS_SEL_ANY , true); - priv->vdev.compose = *compose;mutex_unlock (&priv->mutex); }EXPORT_SYMBOL_GPL (imx_media_capture_device_set_format);@@ -770,8 +768,10 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev) } vdev->fmt.type =V4L2_BUF_TYPE_VIDEO_CAPTURE ; -imx_media_mbus_fmt_to_pix_fmt (&vdev->fmt.fmt.pix, &vdev->compose, +imx_media_mbus_fmt_to_pix_fmt (&vdev->fmt.fmt.pix, &fmt_src.format,NULL ); + vdev->compose.width = fmt_src.format.width; + vdev->compose.height = fmt_src.format.height; vdev->cc =imx_media_find_format (vdev->fmt.fmt.pix.pixelformat,CS_SEL_ANY , false);drivers/staging/media/imx/imx-media-csi.c +2
-3@@ -1512,7 +1512,6 @@ static int csi_set_fmt(struct v4l2_subdev *sd,struct v4l2_pix_format vdev_fmt;struct v4l2_mbus_framefmt *fmt;struct v4l2_rect *crop, *compose; -struct v4l2_rect vdev_compose;int ret;if (sdformat->pad >=CSI_NUM_PADS )@@ -1568,11 +1567,11 @@ static int csi_set_fmt(struct v4l2_subdev *sd, priv->cc[sdformat->pad] = cc;/* propagate IDMAC output pad format to capture device */ -imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &vdev_compose, +imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &priv->format_mbus[CSI_SRC_PAD_IDMAC ], priv->cc[CSI_SRC_PAD_IDMAC ]);mutex_unlock (&priv->lock); -imx_media_capture_device_set_format (vdev, &vdev_fmt, &vdev_compose); +imx_media_capture_device_set_format (vdev, &vdev_fmt);return 0 ; out:drivers/staging/media/imx/imx-media-utils.c +5
-15@@ -577,8 +577,7 @@ void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt,EXPORT_SYMBOL_GPL (imx_media_fill_default_mbus_fields);int imx_media_mbus_fmt_to_pix_fmt (struct v4l2_pix_format *pix, -struct v4l2_rect *compose, -const struct v4l2_mbus_framefmt *mbus, +struct v4l2_mbus_framefmt *mbus,const struct imx_media_pixfmt *cc) {u32 width;@@ -625,17 +624,6 @@ int imx_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, pix->sizeimage = cc->planar ? ((stride * pix->height * cc->bpp) >>3 ) : stride * pix->height; -/* -* set capture compose rectangle, which is fixed to the -* source subdevice mbus format. -*/ -if (compose) { - compose->left =0 ; - compose->top =0 ; - compose->width = mbus->width; - compose->height = mbus->height; - } -return 0 ; }EXPORT_SYMBOL_GPL (imx_media_mbus_fmt_to_pix_fmt);@@ -647,11 +635,13 @@ int imx_media_mbus_fmt_to_ipu_image(struct ipu_image *image,memset (image,0 ,sizeof (*image)); - ret =imx_media_mbus_fmt_to_pix_fmt (&image->pix, &image->rect, - mbus,NULL ); + ret =imx_media_mbus_fmt_to_pix_fmt (&image->pix, mbus,NULL );if (ret)return ret; + image->rect.width = mbus->width; + image->rect.height = mbus->height; +return 0 ; }EXPORT_SYMBOL_GPL (imx_media_mbus_fmt_to_ipu_image);drivers/staging/media/imx/imx-media.h +0
-0drivers/staging/media/imx/imx-media.h void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt, · line 178
Quoted 7 lines
drivers/staging/media/imx/imx-media.h +1
-2@@ -174,8 +174,7 @@ void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt,struct v4l2_mbus_framefmt *fmt, bool ic_route);int imx_media_mbus_fmt_to_pix_fmt (struct v4l2_pix_format *pix, -struct v4l2_rect *compose, -const struct v4l2_mbus_framefmt *mbus, +struct v4l2_mbus_framefmt *mbus,const struct imx_media_pixfmt *cc);Also here you change this function arguments and only remove it from
imx7-media-csi.cin the next patch, triggering:
vers/staging/media/imx/imx7-media-csi.c: In function 'imx7_csi_set_fmt':drivers/staging/media/imx/imx7-media-csi.c:1089:43: error: passing argument 2 of 'imx_media_mbus_fmt_to_pix_fmt' from incompatible pointer type [-Werror=incompatible-pointer-types]
imx_media_mbus_fmt_to_pix_fmt(&vdev_fmt,&vdev_compose,^~~~~~~~~~~~~In file included from
drivers/staging/media/imx/imx7-media-csi.c:30:drivers/staging/media/imx/imx-media.h:177:34: note: expected 'structv4l2_mbus_framefmt*' but argument is of type 'structv4l2_rect*'
structv4l2_mbus_framefmt*mbus,
~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~drivers/staging/media/imx/imx7-media-csi.c:1090:11: error: passing argument 3 of 'imx_media_mbus_fmt_to_pix_fmt' from incompatible pointer type [-Werror=incompatible-pointer-types]&csi->format_mbus[IMX7_CSI_PAD_SRC], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/staging/media/imx/imx7-media-csi.c:30: drivers/staging/media/imx/imx-media.h:178:38: note: expected 'const struct imx_media_pixfmt *' but argument is of type 'struct v4l2_mbus_framefmt *' const struct imx_media_pixfmt *cc); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
drivers/staging/media/imx/imx7-media-csi.c:1089:2: error: too many arguments to function 'imx_media_mbus_fmt_to_pix_fmt'
imx_media_mbus_fmt_to_pix_fmt(&vdev_fmt,&vdev_compose,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included fromdrivers/staging/media/imx/imx7-media-csi.c:30:drivers/staging/media/imx/imx-media.h:176:5: note: declared here
int imx_media_mbus_fmt_to_pix_fmt(structv4l2_pix_format*pix,^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/imx/imx7-media-csi.c:1093:2: error: too many arguments to function 'imx_media_capture_device_set_format' imx_media_capture_device_set_format(vdev, &vdev_fmt, &vdev_compose); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~In file included from
drivers/staging/media/imx/imx7-media-csi.c:30:drivers/staging/media/imx/imx-media.h:281:6: note: declared here
void imx_media_capture_device_set_format(structimx_media_video_dev*vdev,---
Cheers,
Rui
Steve Longerbeam
maintainerPATCH v2 5/8 media: staging/imx: Remove capture_device_set_format
In reply to Steve LongerbeamDon't propagate the source pad format to the connected capture device. It's now the responsibility of userspace to call VIDIOC_S_FMT on the capture device to ensure the capture format and compose rectangle are compatible with the connected source. To check this, validate the capture format with the source before streaming starts.
--- drivers/staging/media/imx/imx-ic-prpencvf.c | 16 +---- drivers/staging/media/imx/imx-media-capture.c | 64 +++++++++++++------ drivers/staging/media/imx/imx-media-csi.c | 16 +---- drivers/staging/media/imx/imx-media.h | 2 - drivers/staging/media/imx/imx7-media-csi.c | 18 +----- 5 files changed, 50 insertions(+), 66 deletions(-)
drivers/staging/media/imx/imx-ic-prpencvf.c +2 -14
@@ -906,9 +906,7 @@ static int prp_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_format *sdformat) {struct prp_priv *priv =sd_to_priv (sd); -struct imx_media_video_dev *vdev = priv->vdev;const struct imx_media_pixfmt *cc; -struct v4l2_pix_format vdev_fmt;struct v4l2_mbus_framefmt *fmt;int ret =0 ;
@@ -945,19 +943,9 @@ static int prp_set_fmt(struct v4l2_subdev *sd, priv->cc[PRPENCVF_SRC_PAD ] = outcc; } -if (sdformat->which ==V4L2_SUBDEV_FORMAT_TRY ) - goto out; - - priv->cc[sdformat->pad] = cc; +if (sdformat->which ==V4L2_SUBDEV_FORMAT_ACTIVE ) + priv->cc[sdformat->pad] = cc; -/* propagate output pad format to capture device */ -imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, - &priv->format_mbus[PRPENCVF_SRC_PAD ], - priv->cc[PRPENCVF_SRC_PAD ]); -mutex_unlock (&priv->lock); -imx_media_capture_device_set_format (vdev, &vdev_fmt); - -return 0 ; out:mutex_unlock (&priv->lock);return ret;
drivers/staging/media/imx/imx-media-capture.c +44 -20
118 lines not on this page · raw message
drivers/staging/media/imx/imx-media-csi.c +2 -14
@@ -1506,10 +1506,8 @@ static int csi_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_format *sdformat) {struct csi_priv *priv =v4l2_get_subdevdata (sd); -struct imx_media_video_dev *vdev = priv->vdev;struct v4l2_fwnode_endpoint upstream_ep = { .bus_type =0 };const struct imx_media_pixfmt *cc; -struct v4l2_pix_format vdev_fmt;struct v4l2_mbus_framefmt *fmt;struct v4l2_rect *crop, *compose;int ret;
@@ -1561,19 +1559,9 @@ static int csi_set_fmt(struct v4l2_subdev *sd, } } -if (sdformat->which ==V4L2_SUBDEV_FORMAT_TRY ) - goto out; - - priv->cc[sdformat->pad] = cc; +if (sdformat->which ==V4L2_SUBDEV_FORMAT_ACTIVE ) + priv->cc[sdformat->pad] = cc; -/* propagate IDMAC output pad format to capture device */ -imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, - &priv->format_mbus[CSI_SRC_PAD_IDMAC ], - priv->cc[CSI_SRC_PAD_IDMAC ]); -mutex_unlock (&priv->lock); -imx_media_capture_device_set_format (vdev, &vdev_fmt); - -return 0 ; out:mutex_unlock (&priv->lock);return ret;
drivers/staging/media/imx/imx-media.h +0 -2
@@ -278,8 +278,6 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev);void imx_media_capture_device_unregister (struct imx_media_video_dev *vdev);struct imx_media_buffer *imx_media_capture_device_next_buf (struct imx_media_video_dev *vdev); -void imx_media_capture_device_set_format (struct imx_media_video_dev *vdev, -struct v4l2_pix_format *pix);void imx_media_capture_device_error (struct imx_media_video_dev *vdev);/* subdev group ids */
drivers/staging/media/imx/imx7-media-csi.c +2 -16
@@ -1031,11 +1031,8 @@ static int imx7_csi_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_format *sdformat) {struct imx7_csi *csi =v4l2_get_subdevdata (sd); -struct imx_media_video_dev *vdev = csi->vdev;const struct imx_media_pixfmt *outcc;struct v4l2_mbus_framefmt *outfmt; -struct v4l2_pix_format vdev_fmt; -struct v4l2_rect vdev_compose;const struct imx_media_pixfmt *cc;struct v4l2_mbus_framefmt *fmt;struct v4l2_subdev_format format;
@@ -1080,19 +1077,8 @@ static int imx7_csi_set_fmt(struct v4l2_subdev *sd, csi->cc[IMX7_CSI_PAD_SRC ] = outcc; } -if (sdformat->which ==V4L2_SUBDEV_FORMAT_TRY ) - goto out_unlock; - - csi->cc[sdformat->pad] = cc; - -/* propagate output pad format to capture device */ -imx_media_mbus_fmt_to_pix_fmt (&vdev_fmt, &vdev_compose, - &csi->format_mbus[IMX7_CSI_PAD_SRC ], - csi->cc[IMX7_CSI_PAD_SRC ]); -mutex_unlock (&csi->lock); -imx_media_capture_device_set_format (vdev, &vdev_fmt, &vdev_compose); - -return 0 ; +if (sdformat->which ==V4L2_SUBDEV_FORMAT_ACTIVE ) + csi->cc[sdformat->pad] = cc; out_unlock:mutex_unlock (&csi->lock);
Signature · 1 line
2.17.1
Steve Longerbeam
maintainerPATCH v2 6/8 media: staging/imx: Re-organize modules
In reply to Steve LongerbeamRe-organize modules, and which objects are linked into those modules, so that:
- imx6-media (renamed from imx-media) is the media driver module for imx5/6 only, and has no symbol exports. The IPU internal subdevice objects now link directly with imx6-media.
- imx6-media-csi (renamed from imx-media-csi) is the subdev driver module for imx5/6 CSI. It is now linked direcly with imx-media-fim, since only the imx5/6 CSI makes use of the frame interval monitor.
- imx-media-common now only contains common code between imx5/6 and imx7 media drivers. It contains imx-media-utils, imx-media-of, imx-media-dev-common, and imx-media-capture. In order to acheive that, some functions common to imx5/6 and imx7 have been moved out of imx-media-dev.c and into imx-media-dev-common.c.
--- drivers/staging/media/imx/Makefile | 18 +- .../staging/media/imx/imx-media-dev-common.c | 345 +++++++++++++++++- drivers/staging/media/imx/imx-media-dev.c | 340 +---------------- drivers/staging/media/imx/imx-media-fim.c | 5 - drivers/staging/media/imx/imx-media-of.c | 3 + drivers/staging/media/imx/imx-media.h | 16 +- drivers/staging/media/imx/imx7-media-csi.c | 4 +- 7 files changed, 370 insertions(+), 361 deletions(-)
drivers/staging/media/imx/Makefile +9 -9
@@ -1,16 +1,16 @@ # SPDX-License-Identifier: GPL-2.0 -imx-media-objs := imx-media-dev.o imx-media-internal-sd.o imx-media-of.o -imx-media-objs += imx-media-dev-common.o -imx-media-common-objs := imx-media-utils.o imx-media-fim.o -imx-media-ic-objs := imx-ic-common.o imx-ic-prp.o imx-ic-prpencvf.o +imx6-media-objs := imx-media-dev.o imx-media-internal-sd.o \ + imx-ic-common.o imx-ic-prp.o imx-ic-prpencvf.o imx-media-vdic.o -obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx-media.o +imx-media-common-objs := imx-media-capture.o imx-media-dev-common.o \ + imx-media-of.o imx-media-utils.o + +imx6-media-csi-objs := imx-media-csi.o imx-media-fim.o + +obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx6-media.o obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx-media-common.o -obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx-media-capture.o -obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx-media-vdic.o -obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx-media-ic.o -obj-$(CONFIG_VIDEO_IMX_CSI) += imx-media-csi.o +obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-media-csi.o obj-$(CONFIG_VIDEO_IMX_CSI) += imx6-mipi-csi2.o obj-$(CONFIG_VIDEO_IMX7_CSI) += imx7-media-csi.o
drivers/staging/media/imx/imx-media-dev-common.c +340 -5
377 lines not on this page · raw message
drivers/staging/media/imx/imx-media-dev.c +11 -329
381 lines not on this page · raw message
drivers/staging/media/imx/imx-media-fim.c +0 -5
@@ -420,7 +420,6 @@ void imx_media_fim_eof_monitor(struct imx_media_fim *fim, ktime_t timestamp)spin_unlock_irqrestore (&fim->lock, flags); } -EXPORT_SYMBOL_GPL (imx_media_fim_eof_monitor);/* Called by the subdev in its s_stream callback */ int imx_media_fim_set_stream(struct imx_media_fim *fim,
@@ -457,7 +456,6 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim,v4l2_ctrl_unlock (fim->ctrl[FIM_CL_ENABLE ]);return ret; } -EXPORT_SYMBOL_GPL (imx_media_fim_set_stream);int imx_media_fim_add_controls (struct imx_media_fim *fim) {
@@ -465,7 +463,6 @@ int imx_media_fim_add_controls(struct imx_media_fim *fim)return v4l2_ctrl_add_handler (fim->sd->ctrl_handler, &fim->ctrl_handler,NULL , false); } -EXPORT_SYMBOL_GPL (imx_media_fim_add_controls);/* Called by the subdev in its subdev registered callback */ struct imx_media_fim *imx_media_fim_init (struct v4l2_subdev *sd)
@@ -489,10 +486,8 @@ struct imx_media_fim *imx_media_fim_init(struct v4l2_subdev *sd)return fim; } -EXPORT_SYMBOL_GPL (imx_media_fim_init);void imx_media_fim_free (struct imx_media_fim *fim) {v4l2_ctrl_handler_free (&fim->ctrl_handler); } -EXPORT_SYMBOL_GPL (imx_media_fim_free);
drivers/staging/media/imx/imx-media-of.c +3 -0
@@ -77,6 +77,7 @@ int imx_media_add_of_subdevs(struct imx_media_dev *imxmd,of_node_put (csi_np);return ret; } +EXPORT_SYMBOL_GPL (imx_media_add_of_subdevs);/* * Create a single media link to/from sd using a fwnode link.
@@ -146,6 +147,7 @@ int imx_media_create_of_links(struct imx_media_dev *imxmd,return 0 ; } +EXPORT_SYMBOL_GPL (imx_media_create_of_links);/* * Create media links to the given CSI subdevice's sink pads,
@@ -189,3 +191,4 @@ int imx_media_create_csi_of_links(struct imx_media_dev *imxmd,return 0 ; } +EXPORT_SYMBOL_GPL (imx_media_create_csi_of_links);
drivers/staging/media/imx/imx-media.h +5 -11
@@ -217,18 +217,12 @@ int imx_media_pipeline_set_stream(struct imx_media_dev *imxmd,struct media_entity *entity, bool on); -/* imx-media-dev.c */ -int imx_media_subdev_bound (struct v4l2_async_notifier *notifier, -struct v4l2_subdev *sd, -struct v4l2_async_subdev *asd); -int imx_media_link_notify (struct media_link *link,u32 flags, -unsigned int notification); -void imx_media_notify (struct v4l2_subdev *sd,unsigned int notification, -void *arg); +/* imx-media-dev-common.c */ int imx_media_probe_complete (struct v4l2_async_notifier *notifier); - -struct imx_media_dev *imx_media_dev_init (struct device *dev); -int imx_media_dev_notifier_register (struct imx_media_dev *imxmd); +struct imx_media_dev *imx_media_dev_init (struct device *dev, +const struct media_device_ops *ops); +int imx_media_dev_notifier_register (struct imx_media_dev *imxmd, +const struct v4l2_async_notifier_operations *ops);/* imx-media-fim.c */ struct imx_media_fim ;
drivers/staging/media/imx/imx7-media-csi.c +2 -2
@@ -1241,7 +1241,7 @@ static int imx7_csi_probe(struct platform_device *pdev) }/* add media device */ - imxmd =imx_media_dev_init (dev); + imxmd =imx_media_dev_init (dev,NULL );if (IS_ERR (imxmd)) { ret =PTR_ERR (imxmd); goto destroy_mutex;
@@ -1252,7 +1252,7 @@ static int imx7_csi_probe(struct platform_device *pdev)if (ret <0 && ret != -ENODEV && ret != -EEXIST ) goto cleanup; - ret =imx_media_dev_notifier_register (imxmd); + ret =imx_media_dev_notifier_register (imxmd,NULL );if (ret <0 ) goto cleanup;
Signature · 1 line
2.17.1
Steve Longerbeam
maintainerPATCH v2 7/8 media: staging/imx: Improve pipeline searching
In reply to Steve LongerbeamExport find_pipeline_pad(), renaming to imx_media_pipeline_pad(), and extend its functionality to allow searching for video devices in the enabled pipeline in addition to sub-devices.
As part of this:
- Rename imx_media_find_mipi_csi2_channel() to
imx_media_pipeline_csi2_channel().
- Remove imx_media_find_upstream_pad(), it is redundant now.
- Rename imx_media_find_upstream_subdev() to imx_media_pipeline_subdev() with an additional boolean argument for searching upstream or downstream.
- Add imx_media_pipeline_video_device() which is analogous to imx_media_pipeline_subdev() but searches for video devices.
- Remove imxmd pointer arg from all of the functions above, it was never used in those functions. With that change the i.MX5/6 CSI, VDIC, and IC sub-devices no longer require the media_device.
--- drivers/staging/media/imx/imx-ic-common.c | 4 +- drivers/staging/media/imx/imx-ic-prp.c | 4 +- drivers/staging/media/imx/imx-ic.h | 1 - drivers/staging/media/imx/imx-media-csi.c | 13 +- drivers/staging/media/imx/imx-media-fim.c | 4 - .../staging/media/imx/imx-media-internal-sd.c | 5 +- drivers/staging/media/imx/imx-media-utils.c | 128 ++++++++++-------- drivers/staging/media/imx/imx-media-vdic.c | 5 +- drivers/staging/media/imx/imx-media.h | 20 +-- drivers/staging/media/imx/imx7-media-csi.c | 2 +- 10 files changed, 93 insertions(+), 93 deletions(-)
drivers/staging/media/imx/imx-ic-common.c +1 -3
@@ -22,12 +22,11 @@ static struct imx_ic_ops *ic_ops[IC_NUM_OPS] = { [IC_TASK_VIEWFINDER] = &imx_ic_prpencvf_ops, }; -struct v4l2_subdev *imx_media_ic_register (struct imx_media_dev *imxmd, +struct v4l2_subdev *imx_media_ic_register (struct v4l2_device *v4l2_dev,struct device *ipu_dev,struct ipu_soc *ipu,u32 grp_id) { -struct v4l2_device *v4l2_dev = &imxmd->v4l2_dev;struct imx_ic_priv *priv;int ret;
@@ -37,7 +36,6 @@ struct v4l2_subdev *imx_media_ic_register(struct imx_media_dev *imxmd, priv->ipu_dev = ipu_dev; priv->ipu = ipu; - priv->md = imxmd;/* get our IC task id */ switch (grp_id) {
drivers/staging/media/imx/imx-ic-prp.c +2 -2
@@ -302,8 +302,8 @@ static int prp_link_validate(struct v4l2_subdev *sd,if (ret)return ret; - csi =imx_media_find_upstream_subdev (ic_priv->md, &ic_priv->sd.entity, -IMX_MEDIA_GRP_ID_IPU_CSI ); + csi =imx_media_pipeline_subdev (&ic_priv->sd.entity, +IMX_MEDIA_GRP_ID_IPU_CSI , true);if (IS_ERR (csi)) csi =NULL ;
drivers/staging/media/imx/imx-ic.h +0 -1
@@ -16,7 +16,6 @@struct imx_ic_priv {struct device *ipu_dev;struct ipu_soc *ipu; -struct imx_media_dev *md;struct v4l2_subdev sd;int task_id;void *task_priv;
drivers/staging/media/imx/imx-media-csi.c +4 -9
@@ -60,7 +60,6 @@ struct csi_skip_desc {struct csi_priv {struct device *dev;struct ipu_soc *ipu; -struct imx_media_dev *md;struct v4l2_subdev sd;struct media_pad pad[CSI_NUM_PADS ];/* the video device at IDMAC output pad */
@@ -182,8 +181,8 @@ static int csi_get_upstream_endpoint(struct csi_priv *priv,* CSI-2 receiver if it is in the path, otherwise stay * with video mux. */ - sd =imx_media_find_upstream_subdev (priv->md, src, -IMX_MEDIA_GRP_ID_CSI2 ); + sd =imx_media_pipeline_subdev (src,IMX_MEDIA_GRP_ID_CSI2 , + true);if (!IS_ERR (sd)) src = &sd->entity; }
@@ -197,7 +196,7 @@ static int csi_get_upstream_endpoint(struct csi_priv *priv, src = &priv->sd.entity;/* get source pad of entity directly upstream from src */ - pad =imx_media_find_upstream_pad (priv->md, src,0 ); + pad =imx_media_pipeline_pad (src,0 ,0 , true);if (IS_ERR (pad))return PTR_ERR (pad);
@@ -1138,8 +1137,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,*/ #if 0 mutex_unlock (&priv->lock); - vc_num =imx_media_find_mipi_csi2_channel (priv->md, - &priv->sd.entity); + vc_num =imx_media_find_mipi_csi2_channel (&priv->sd.entity);if (vc_num <0 )return vc_num;mutex_lock (&priv->lock);
@@ -1753,9 +1751,6 @@ static int csi_registered(struct v4l2_subdev *sd)int i, ret;u32 code; -/* get media device */ - priv->md =dev_get_drvdata (sd->v4l2_dev->dev); -/* get handle to IPU CSI */ csi =ipu_csi_get (priv->ipu, priv->csi_id);if (IS_ERR (csi)) {
drivers/staging/media/imx/imx-media-fim.c +0 -4
@@ -41,8 +41,6 @@ enum {#define FIM_CL_TOLERANCE_MAX_DEF 0/* no max tolerance (unbounded) */ struct imx_media_fim { -struct imx_media_dev *md; -/* the owning subdev of this fim instance */ struct v4l2_subdev *sd;
@@ -474,8 +472,6 @@ struct imx_media_fim *imx_media_fim_init(struct v4l2_subdev *sd)if (!fim)return ERR_PTR (-ENOMEM ); -/* get media device */ - fim->md =dev_get_drvdata (sd->v4l2_dev->dev); fim->sd = sd;spin_lock_init (&fim->lock);
drivers/staging/media/imx/imx-media-internal-sd.c +3 -2
@@ -35,7 +35,7 @@ struct internal_subdev {u32 grp_id;struct internal_pad pad[MAX_INTERNAL_PADS ]; -struct v4l2_subdev * (*sync_register)(struct imx_media_dev *imxmd, +struct v4l2_subdev * (*sync_register)(struct v4l2_device *v4l2_dev,struct device *ipu_dev,struct ipu_soc *ipu,u32 grp_id);
@@ -228,7 +228,8 @@ int imx_media_register_ipu_internal_subdevs(struct imx_media_dev *imxmd,continue ;mutex_unlock (&imxmd->mutex); - sd = intsd->sync_register (imxmd, ipu_dev, ipu, intsd->grp_id); + sd = intsd->sync_register (&imxmd->v4l2_dev, ipu_dev, ipu, + intsd->grp_id);mutex_lock (&imxmd->mutex);if (IS_ERR (sd)) { ret =PTR_ERR (sd);
drivers/staging/media/imx/imx-media-utils.c +71 -57
196 lines not on this page · raw message
drivers/staging/media/imx/imx-media-vdic.c +1 -4
@@ -65,7 +65,6 @@ struct vdic_priv {struct device *ipu_dev;struct ipu_soc *ipu; -struct imx_media_dev *md;struct v4l2_subdev sd;struct media_pad pad[VDIC_NUM_PADS ];
@@ -927,12 +926,11 @@ static const struct v4l2_subdev_internal_ops vdic_internal_ops = { .unregistered = vdic_unregistered, }; -struct v4l2_subdev *imx_media_vdic_register (struct imx_media_dev *imxmd, +struct v4l2_subdev *imx_media_vdic_register (struct v4l2_device *v4l2_dev,struct device *ipu_dev,struct ipu_soc *ipu,u32 grp_id) { -struct v4l2_device *v4l2_dev = &imxmd->v4l2_dev;struct vdic_priv *priv;int ret;
@@ -942,7 +940,6 @@ struct v4l2_subdev *imx_media_vdic_register(struct imx_media_dev *imxmd, priv->ipu_dev = ipu_dev; priv->ipu = ipu; - priv->md = imxmd;v4l2_subdev_init (&priv->sd, &vdic_subdev_ops);v4l2_set_subdevdata (&priv->sd, priv);
drivers/staging/media/imx/imx-media.h +10 -10
@@ -190,16 +190,16 @@ imx_media_find_subdev_by_devname(struct imx_media_dev *imxmd, const char *devname);void imx_media_add_video_device (struct imx_media_dev *imxmd,struct imx_media_video_dev *vdev); -int imx_media_find_mipi_csi2_channel (struct imx_media_dev *imxmd, -struct media_entity *start_entity); +int imx_media_pipeline_csi2_channel (struct media_entity *start_entity);struct media_pad * -imx_media_find_upstream_pad (struct imx_media_dev *imxmd, -struct media_entity *start_entity, -u32 grp_id); +imx_media_pipeline_pad (struct media_entity *start_entity,u32 grp_id, +enum v4l2_buf_type buftype,bool upstream);struct v4l2_subdev * -imx_media_find_upstream_subdev (struct imx_media_dev *imxmd, -struct media_entity *start_entity, -u32 grp_id); +imx_media_pipeline_subdev (struct media_entity *start_entity,u32 grp_id, +bool upstream); +struct video_device * +imx_media_pipeline_video_device (struct media_entity *start_entity, +enum v4l2_buf_type buftype,bool upstream);struct imx_media_dma_buf {void *virt;
@@ -250,14 +250,14 @@ int imx_media_of_add_csi(struct imx_media_dev *imxmd, struct device_node *csi_np);/* imx-media-vdic.c */ -struct v4l2_subdev *imx_media_vdic_register (struct imx_media_dev *imxmd, +struct v4l2_subdev *imx_media_vdic_register (struct v4l2_device *v4l2_dev,struct device *ipu_dev,struct ipu_soc *ipu,u32 grp_id);int imx_media_vdic_unregister (struct v4l2_subdev *sd);/* imx-ic-common.c */ -struct v4l2_subdev *imx_media_ic_register (struct imx_media_dev *imxmd, +struct v4l2_subdev *imx_media_ic_register (struct v4l2_device *v4l2_dev,struct device *ipu_dev,struct ipu_soc *ipu,u32 grp_id);
drivers/staging/media/imx/imx7-media-csi.c +1 -1
@@ -450,7 +450,7 @@ static int imx7_csi_get_upstream_endpoint(struct imx7_csi *csi, skip_video_mux:/* get source pad of entity directly upstream from src */ - pad =imx_media_find_upstream_pad (csi->imxmd, src,0 ); + pad =imx_media_pipeline_pad (src,0 ,0 , true);if (IS_ERR (pad))return PTR_ERR (pad);
Signature · 1 line
2.17.1
Steve Longerbeam
maintainerPATCH v2 8/8 media: staging/imx: Don't set driver data for v4l2_dev
In reply to Steve LongerbeamThe media device is already available via multiple methods, there is no need to set driver data for v4l2_dev to the media device.
In imx_media_link_notify(), get media device from link->graph_obj.mdev.
In imx_media_capture_device_register(), get media device from v4l2_dev->mdev.
--- drivers/staging/media/imx/imx-media-capture.c | 5 +++-- drivers/staging/media/imx/imx-media-dev-common.c | 7 ++----- 2 files changed, 5 insertions(+), 7 deletions(-)
drivers/staging/media/imx/imx-media-capture.c +3 -2
@@ -732,15 +732,16 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev) {struct capture_priv *priv =to_capture_priv (vdev);struct v4l2_subdev *sd = priv->src_sd; +struct v4l2_device *v4l2_dev = sd->v4l2_dev;struct video_device *vfd = vdev->vfd;struct vb2_queue *vq = &priv->q;struct v4l2_subdev_format fmt_src;int ret;/* get media device */ - priv->md =dev_get_drvdata (sd->v4l2_dev->dev); + priv->md = container_of(v4l2_dev->mdev, struct imx_media_dev, md); - vfd->v4l2_dev = sd->v4l2_dev; + vfd->v4l2_dev = v4l2_dev; ret =video_register_device (vfd,VFL_TYPE_GRABBER ,-1 );if (ret) {
drivers/staging/media/imx/imx-media-dev-common.c +2 -5
@@ -260,10 +260,11 @@ static int imx_media_inherit_controls(struct imx_media_dev *imxmd,static int imx_media_link_notify (struct media_link *link,u32 flags,unsigned int notification) { +struct imx_media_dev *imxmd =container_of (link->graph_obj.mdev, + struct imx_media_dev, md);struct media_entity *source = link->source->entity;struct imx_media_pad_vdev *pad_vdev;struct list_head *pad_vdev_list; -struct imx_media_dev *imxmd;struct video_device *vfd;struct v4l2_subdev *sd;int pad_idx, ret;
@@ -279,8 +280,6 @@ static int imx_media_link_notify(struct media_link *link, u32 flags, sd =media_entity_to_v4l2_subdev (source); pad_idx = link->source->index; - imxmd =dev_get_drvdata (sd->v4l2_dev->dev); - pad_vdev_list =to_pad_vdev_list (sd, pad_idx);if (!pad_vdev_list) {/* nothing to do if source sd has no pad vdev list */
@@ -384,8 +383,6 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev, goto cleanup; } -dev_set_drvdata (imxmd->v4l2_dev.dev, imxmd); -INIT_LIST_HEAD (&imxmd->vdev_list);v4l2_async_notifier_init (&imxmd->notifier);
Signature · 1 line
2.17.1
Hi Steve,
Quoted 2 lines · Steve Longerbeam
Switch to sync registration for the IPU internal sub-devices, re-organize modules, and a few other miscellaneous cleanups.
FYI,
Just got a run of this series on top of linux-media and got the bellow trace. I will take a better look this afternoon and let you know.
---
Cheers,
Rui
7.968206] Unable to handle kernel NULL pointer dereference at virtual address 00000030
[ 7.976775] pgd = (ptrval) [ 7.979510] [00000030] *pgd=992f8835, *pte=00000000, *ppte=00000000 [ 7.985876] Internal error: Oops: 17 [#1] SMP ARM [ 7.990594] Modules linked in: brcmutil imx7_mipi_csis(C+) imx7_media_csi(C+) imx_media_common(C) ov2680 video_mux v4l2_fwnode mux_mmio mux_core evbug [ 8.004114] CPU: 0 PID: 256 Comm: udevd Tainted: G C 5.1.0-rc1-00222-g5e258c299364 #24 [ 8.013341] Hardware name: Freescale i.MX7 Dual (Device Tree) [ 8.019111] PC is at media_entity_find_link+0x4/0x88 [ 8.024135] LR is at create_of_link+0x78/0xd4 [imx_media_common] [ 8.030153] pc : [<c0941958>] lr : [<bf03ebfc>] psr: 20010013 [ 8.036430] sp : d92b5bdc ip : 00000001 fp : 00000001 [ 8.041665] r10: bf065098 r9 : 0000001c r8 : d92a2ce8 [ 8.046901] r7 : 00000001 r6 : d9387840 r5 : d9387840 r4 : 00000001 [ 8.053439] r3 : d929e4e0 r2 : 00000001 r1 : d929e4e0 r0 : 00000020 [ 8.059978] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 8.067125] Control: 10c5387d Table: 9923006a DAC: 00000051 [ 8.072882] Process udevd (pid: 256, stack limit = 0x(ptrval)) [ 8.078726] Stack: (0xd92b5bdc to 0xd92b6000) [ 8.083095] 5bc0: 00000001 [ 8.091290] 5be0: d9387840 bf03ebfc d92b5c14 db3a40c0 db3a09c4 db3a0c08 d9387840 d9352268 [ 8.099483] 5c00: d9352040 c1414948 0000001c bf03ecb0 00000000 db3a09c4 00000001 db3a40c0 [ 8.107677] 5c20: 00000001 3b0988f7 d9387840 d93523b0 d9352268 d9352040 d9352364 bf03e8ec [ 8.115871] 5c40: d92a2ce8 d93775c0 c14ab278 d92a2d94 00000000 0000001c bf065098 c0958484 [ 8.124065] 5c60: d92a2ce8 d92b5cc0 d9397300 dadb7810 00000001 bf023164 00000001 bf065098 [ 8.132258] 5c80: dadb7810 d92a2ce8 d92a2ce8 d92a2c40 00000000 dadb7800 dadb7810 c1414948 [ 8.140451] 5ca0: d92a2ce8 00000001 bf0671a4 bf065b6c bf065098 dada61c0 d92a2c40 c3003f28 [ 8.148644] 5cc0: 00000000 3b0988f7 00000000 dadb7810 00000000 bf068014 00000000 00000000 [ 8.156838] 5ce0: bf068014 00000007 c1414948 c07ed148 dadb7810 c1c8c064 c1c8c068 00000000 [ 8.165032] 5d00: 00000000 c07eb070 dadb7810 bf068014 bf068014 c1414948 00000000 c14f0cd4 [ 8.173225] 5d20: c1c6bdec c07eb2bc c1414948 00000000 c14f0cd4 dadb7810 00000000 bf068014 [ 8.181418] 5d40: c1414948 00000000 c14f0cd4 c07eb568 00000000 bf068014 dadb7810 c07eb5c8 [ 8.189613] 5d60: dada0590 bf068014 c07eb570 c07e9414 d93a9300 dad4c0a4 dada0590 3b0988f7 [ 8.197806] 5d80: dad4c0d4 bf068014 d93a9300 c1495f38 00000000 c07ea470 bf0676cc c1414970 [ 8.206000] 5da0: c1414948 bf068014 c1414970 c1414948 bf06b000 c07ec248 c14f20e0 c1414970 [ 8.214194] 5dc0: c1414948 c0103078 c024f1b0 c018e6b0 00000000 3b0988f7 c1415078 d93cbd00 [ 8.222388] 5de0: 00000cc0 dac01e00 c1414970 000058da d93cbd40 c01ab5f4 c14f0eba c02a6e10 [ 8.230582] 5e00: c01e0b00 d93c1700 c01de6e4 0000000c 19fe0000 3b0988f7 bf068080 c14f2798 [ 8.238775] 5e20: d93cbd00 00000001 d93cbc70 bf068080 c1c6bdec c01de720 d93cbc70 bf068080 [ 8.246969] 5e40: c14f0dd6 c14f2798 c1414970 c01e0b4c bf06808c 00007fff bf068080 c01dd8dc [ 8.255162] 5e60: 00000000 bf0680c8 c0e048d4 bf0681f0 bf068080 bf0681d4 c0e048b4 bf06829c [ 8.263356] 5e80: bf000000 c10bc9bc 00000001 00000000 c11c139c c11aec30 00000000 00000000 [ 8.271548] 5ea0: 00000000 00000000 00000000 00000000 6e72656b 00006c65 00000000 00000000 [ 8.279740] 5ec0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 8.287933] 5ee0: 00000000 00000000 00000000 3b0988f7 7fffffff c1414948 00000000 00000009 [ 8.296126] 5f00: b6ede824 7fffffff 00000000 0000017b 00000000 c01e10d0 7fffffff 00000000 [ 8.304319] 5f20: 00000003 00000001 00000000 deb38000 000053b4 00000000 deb398c1 deb3ad00 [ 8.312512] 5f40: deb38000 000053b4 deb3cd9c deb3cbf4 deb3bb14 00004000 000044d0 00000000 [ 8.320705] 5f60: 00000000 00000000 000024d0 00000024 00000025 0000001e 0000001b 00000018 [ 8.328898] 5f80: 00000000 3b0988f7 0000002a 00000000 00000001 00000000 0000017b c01011c4 [ 8.337091] 5fa0: d92b4000 c0101000 00000000 00000001 00000009 b6ede824 00000000 00067098 [ 8.345284] 5fc0: 00000000 00000001 00000000 0000017b 00000000 00034708 0005cd80 00000000 [ 8.353477] 5fe0: becf78a8 becf7898 b6ed6e04 b6e70e52 60010030 00000009 00000000 00000000 [ 8.361696] [<c0941958>] (media_entity_find_link) from [<bf03ebfc>] (create_of_link+0x78/0xd4 [imx_media_common]) [ 8.372014] [<bf03ebfc>] (create_of_link [imx_media_common]) from [<bf03ecb0>] (imx_media_create_of_links+0x58/0xac [imx_media_common]) [ 8.384241] [<bf03ecb0>] (imx_media_create_of_links [imx_media_common]) from [<bf03e8ec>] (imx_media_probe_complete+0x58/0x1b8 [imx_media_common]) [ 8.397414] [<bf03e8ec>] (imx_media_probe_complete [imx_media_common]) from [<c0958484>] (v4l2_async_register_subdev+0xe8/0x1c4) [ 8.409011] [<c0958484>] (v4l2_async_register_subdev) from [<bf023164>] (v4l2_async_register_fwnode_subdev+0x114/0xfb0 [v4l2_fwnode]) [ 8.421051] [<bf023164>] (v4l2_async_register_fwnode_subdev [v4l2_fwnode]) from [<bf065b6c>] (mipi_csis_probe+0x2e0/0x514 [imx7_mipi_csis]) [ 8.433604] [<bf065b6c>] (mipi_csis_probe [imx7_mipi_csis]) from [<c07ed148>] (platform_drv_probe+0x48/0x98) [ 8.443451] [<c07ed148>] (platform_drv_probe) from [<c07eb070>] (really_probe+0x1dc/0x2cc) [ 8.451734] [<c07eb070>] (really_probe) from [<c07eb2bc>] (driver_probe_device+0x5c/0x160) [ 8.460016] [<c07eb2bc>] (driver_probe_device) from [<c07eb568>] (device_driver_attach+0x58/0x60) [ 8.468906] [<c07eb568>] (device_driver_attach) from [<c07eb5c8>] (__driver_attach+0x58/0xd0) [ 8.477449] [<c07eb5c8>] (__driver_attach) from [<c07e9414>] (bus_for_each_dev+0x70/0xb4) [ 8.485644] [<c07e9414>] (bus_for_each_dev) from [<c07ea470>] (bus_add_driver+0x198/0x1d0) [ 8.493926] [<c07ea470>] (bus_add_driver) from [<c07ec248>] (driver_register+0x74/0x108) [ 8.502039] [<c07ec248>] (driver_register) from [<c0103078>] (do_one_initcall+0x80/0x31c) [ 8.510237] [<c0103078>] (do_one_initcall) from [<c01de720>] (do_init_module+0x5c/0x1f4) [ 8.518347] [<c01de720>] (do_init_module) from [<c01e0b4c>] (load_module+0x222c/0x255c) [ 8.526368] [<c01e0b4c>] (load_module) from [<c01e10d0>] (sys_finit_module+0xbc/0xdc) [ 8.534217] [<c01e10d0>] (sys_finit_module) from [<c0101000>] (ret_fast_syscall+0x0/0x28) [ 8.542405] Exception stack(0xd92b5fa8 to 0xd92b5ff0) [ 8.547471] 5fa0: 00000000 00000001 00000009 b6ede824 00000000 00067098 [ 8.555664] 5fc0: 00000000 00000001 00000000 0000017b 00000000 00034708 0005cd80 00000000 [ 8.563854] 5fe0: becf78a8 becf7898 b6ed6e04 b6e70e52 [ 8.568922] Code: e3e04015 eaffffd1 fffffdfd e92d4030 (e5904010) [ 8.575093] ---[ end trace 04afa547993602ba ]---
Quoted 35 lines
History:
v2:
- Added a patch that improves the pipeline upstream/downstream search functions, which no longer require the media device.
- Add a patch to remove getting media device fromv4l2_devdriver data.Steve Longerbeam (8):
media: staging/imx: Switch to sync registration for IPU subdevs
media: staging/imx: Pass device to alloc/free_dma_buf
media: staging/imx: Moveadd_video_deviceintocapture_device_registerRevert "media: imx: Set capture compose rectangle in
capture_device_set_format"
media: staging/imx: Removecapture_device_set_format
media: staging/imx: Re-organize modules
media: staging/imx: Improve pipeline searching
media: staging/imx: Don't set driver data forv4l2_devdrivers/staging/media/imx/Makefile | 18 +- drivers/staging/media/imx/imx-ic-common.c | 68 +-- drivers/staging/media/imx/imx-ic-prp.c | 36 +- drivers/staging/media/imx/imx-ic-prpencvf.c | 88 ++-- drivers/staging/media/imx/imx-ic.h | 6 +- drivers/staging/media/imx/imx-media-capture.c | 75 ++- drivers/staging/media/imx/imx-media-csi.c | 45 +- .../staging/media/imx/imx-media-dev-common.c | 346 +++++++++++++- drivers/staging/media/imx/imx-media-dev.c | 449 +----------------- drivers/staging/media/imx/imx-media-fim.c | 9 - .../staging/media/imx/imx-media-internal-sd.c | 357 ++++++-------- drivers/staging/media/imx/imx-media-of.c | 41 +- drivers/staging/media/imx/imx-media-utils.c | 170 +++---- drivers/staging/media/imx/imx-media-vdic.c | 84 +--- drivers/staging/media/imx/imx-media.h | 113 +++-- drivers/staging/media/imx/imx7-media-csi.c | 43 +- 16 files changed, 848 insertions(+), 1100 deletions(-)
Hi Steve,
Quoted 9 lines · Rui Miguel Silva
Hi Steve,
Quoted 2 lines · Steve Longerbeam
Switch to sync registration for the IPU internal sub-devices, re-organize modules, and a few other miscellaneous cleanups.
FYI,
Just got a run of this series on top of linux-media and got the bellow trace. I will take a better look this afternoon and let you know.
Found the issue here, as it was intermittent, it is that mipi csis is racy setting media entity pads. Need to set it in internal_ops. I will send a patch for this later. but even with this fixed it misses now the capturing of any frame. Need to debug it a little more.
---
Cheers,
Rui
Quoted 118 lines
---
Cheers,
Rui7.968206] Unable to handle kernel NULL pointer dereference at virtual address 00000030
[ 7.976775] pgd = (ptrval) [ 7.979510] [00000030] *pgd=992f8835, *pte=00000000, *ppte=00000000 [ 7.985876] Internal error: Oops: 17 [#1] SMP ARM [ 7.990594] Modules linked in: brcmutil imx7_mipi_csis(C+) imx7_media_csi(C+) imx_media_common(C) ov2680 video_mux v4l2_fwnode mux_mmio mux_core evbug [ 8.004114] CPU: 0 PID: 256 Comm: udevd Tainted: G C 5.1.0-rc1-00222-g5e258c299364 #24 [ 8.013341] Hardware name: Freescale i.MX7 Dual (Device Tree) [ 8.019111] PC is at media_entity_find_link+0x4/0x88 [ 8.024135] LR is at create_of_link+0x78/0xd4 [imx_media_common] [ 8.030153] pc : [<c0941958>] lr : [<bf03ebfc>] psr: 20010013 [ 8.036430] sp : d92b5bdc ip : 00000001 fp : 00000001 [ 8.041665] r10: bf065098 r9 : 0000001c r8 : d92a2ce8 [ 8.046901] r7 : 00000001 r6 : d9387840 r5 : d9387840 r4 : 00000001 [ 8.053439] r3 : d929e4e0 r2 : 00000001 r1 : d929e4e0 r0 : 00000020 [ 8.059978] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 8.067125] Control: 10c5387d Table: 9923006a DAC: 00000051 [ 8.072882] Process udevd (pid: 256, stack limit = 0x(ptrval)) [ 8.078726] Stack: (0xd92b5bdc to 0xd92b6000) [ 8.083095] 5bc0: 00000001 [ 8.091290] 5be0: d9387840 bf03ebfc d92b5c14 db3a40c0 db3a09c4 db3a0c08 d9387840 d9352268 [ 8.099483] 5c00: d9352040 c1414948 0000001c bf03ecb0 00000000 db3a09c4 00000001 db3a40c0 [ 8.107677] 5c20: 00000001 3b0988f7 d9387840 d93523b0 d9352268 d9352040 d9352364 bf03e8ec [ 8.115871] 5c40: d92a2ce8 d93775c0 c14ab278 d92a2d94 00000000 0000001c bf065098 c0958484 [ 8.124065] 5c60: d92a2ce8 d92b5cc0 d9397300 dadb7810 00000001 bf023164 00000001 bf065098 [ 8.132258] 5c80: dadb7810 d92a2ce8 d92a2ce8 d92a2c40 00000000 dadb7800 dadb7810 c1414948 [ 8.140451] 5ca0: d92a2ce8 00000001 bf0671a4 bf065b6c bf065098 dada61c0 d92a2c40 c3003f28 [ 8.148644] 5cc0: 00000000 3b0988f7 00000000 dadb7810 00000000 bf068014 00000000 00000000 [ 8.156838] 5ce0: bf068014 00000007 c1414948 c07ed148 dadb7810 c1c8c064 c1c8c068 00000000 [ 8.165032] 5d00: 00000000 c07eb070 dadb7810 bf068014 bf068014 c1414948 00000000 c14f0cd4 [ 8.173225] 5d20: c1c6bdec c07eb2bc c1414948 00000000 c14f0cd4 dadb7810 00000000 bf068014 [ 8.181418] 5d40: c1414948 00000000 c14f0cd4 c07eb568 00000000 bf068014 dadb7810 c07eb5c8 [ 8.189613] 5d60: dada0590 bf068014 c07eb570 c07e9414 d93a9300 dad4c0a4 dada0590 3b0988f7 [ 8.197806] 5d80: dad4c0d4 bf068014 d93a9300 c1495f38 00000000 c07ea470 bf0676cc c1414970 [ 8.206000] 5da0: c1414948 bf068014 c1414970 c1414948 bf06b000 c07ec248 c14f20e0 c1414970 [ 8.214194] 5dc0: c1414948 c0103078 c024f1b0 c018e6b0 00000000 3b0988f7 c1415078 d93cbd00 [ 8.222388] 5de0: 00000cc0 dac01e00 c1414970 000058da d93cbd40 c01ab5f4 c14f0eba c02a6e10 [ 8.230582] 5e00: c01e0b00 d93c1700 c01de6e4 0000000c 19fe0000 3b0988f7 bf068080 c14f2798 [ 8.238775] 5e20: d93cbd00 00000001 d93cbc70 bf068080 c1c6bdec c01de720 d93cbc70 bf068080 [ 8.246969] 5e40: c14f0dd6 c14f2798 c1414970 c01e0b4c bf06808c 00007fff bf068080 c01dd8dc [ 8.255162] 5e60: 00000000 bf0680c8 c0e048d4 bf0681f0 bf068080 bf0681d4 c0e048b4 bf06829c [ 8.263356] 5e80: bf000000 c10bc9bc 00000001 00000000 c11c139c c11aec30 00000000 00000000 [ 8.271548] 5ea0: 00000000 00000000 00000000 00000000 6e72656b 00006c65 00000000 00000000 [ 8.279740] 5ec0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 8.287933] 5ee0: 00000000 00000000 00000000 3b0988f7 7fffffff c1414948 00000000 00000009 [ 8.296126] 5f00: b6ede824 7fffffff 00000000 0000017b 00000000 c01e10d0 7fffffff 00000000 [ 8.304319] 5f20: 00000003 00000001 00000000 deb38000 000053b4 00000000 deb398c1 deb3ad00 [ 8.312512] 5f40: deb38000 000053b4 deb3cd9c deb3cbf4 deb3bb14 00004000 000044d0 00000000 [ 8.320705] 5f60: 00000000 00000000 000024d0 00000024 00000025 0000001e 0000001b 00000018 [ 8.328898] 5f80: 00000000 3b0988f7 0000002a 00000000 00000001 00000000 0000017b c01011c4 [ 8.337091] 5fa0: d92b4000 c0101000 00000000 00000001 00000009 b6ede824 00000000 00067098 [ 8.345284] 5fc0: 00000000 00000001 00000000 0000017b 00000000 00034708 0005cd80 00000000 [ 8.353477] 5fe0: becf78a8 becf7898 b6ed6e04 b6e70e52 60010030 00000009 00000000 00000000 [ 8.361696] [<c0941958>] (media_entity_find_link) from [<bf03ebfc>] (create_of_link+0x78/0xd4 [imx_media_common]) [ 8.372014] [<bf03ebfc>] (create_of_link [imx_media_common]) from [<bf03ecb0>] (imx_media_create_of_links+0x58/0xac [imx_media_common]) [ 8.384241] [<bf03ecb0>] (imx_media_create_of_links [imx_media_common]) from [<bf03e8ec>] (imx_media_probe_complete+0x58/0x1b8 [imx_media_common]) [ 8.397414] [<bf03e8ec>] (imx_media_probe_complete [imx_media_common]) from [<c0958484>] (v4l2_async_register_subdev+0xe8/0x1c4) [ 8.409011] [<c0958484>] (v4l2_async_register_subdev) from [<bf023164>] (v4l2_async_register_fwnode_subdev+0x114/0xfb0 [v4l2_fwnode]) [ 8.421051] [<bf023164>] (v4l2_async_register_fwnode_subdev [v4l2_fwnode]) from [<bf065b6c>] (mipi_csis_probe+0x2e0/0x514 [imx7_mipi_csis]) [ 8.433604] [<bf065b6c>] (mipi_csis_probe [imx7_mipi_csis]) from [<c07ed148>] (platform_drv_probe+0x48/0x98) [ 8.443451] [<c07ed148>] (platform_drv_probe) from [<c07eb070>] (really_probe+0x1dc/0x2cc) [ 8.451734] [<c07eb070>] (really_probe) from [<c07eb2bc>] (driver_probe_device+0x5c/0x160) [ 8.460016] [<c07eb2bc>] (driver_probe_device) from [<c07eb568>] (device_driver_attach+0x58/0x60) [ 8.468906] [<c07eb568>] (device_driver_attach) from [<c07eb5c8>] (__driver_attach+0x58/0xd0) [ 8.477449] [<c07eb5c8>] (__driver_attach) from [<c07e9414>] (bus_for_each_dev+0x70/0xb4) [ 8.485644] [<c07e9414>] (bus_for_each_dev) from [<c07ea470>] (bus_add_driver+0x198/0x1d0) [ 8.493926] [<c07ea470>] (bus_add_driver) from [<c07ec248>] (driver_register+0x74/0x108) [ 8.502039] [<c07ec248>] (driver_register) from [<c0103078>] (do_one_initcall+0x80/0x31c) [ 8.510237] [<c0103078>] (do_one_initcall) from [<c01de720>] (do_init_module+0x5c/0x1f4) [ 8.518347] [<c01de720>] (do_init_module) from [<c01e0b4c>] (load_module+0x222c/0x255c) [ 8.526368] [<c01e0b4c>] (load_module) from [<c01e10d0>] (sys_finit_module+0xbc/0xdc) [ 8.534217] [<c01e10d0>] (sys_finit_module) from [<c0101000>] (ret_fast_syscall+0x0/0x28) [ 8.542405] Exception stack(0xd92b5fa8 to 0xd92b5ff0) [ 8.547471] 5fa0: 00000000 00000001 00000009 b6ede824 00000000 00067098 [ 8.555664] 5fc0: 00000000 00000001 00000000 0000017b 00000000 00034708 0005cd80 00000000 [ 8.563854] 5fe0: becf78a8 becf7898 b6ed6e04 b6e70e52 [ 8.568922] Code: e3e04015 eaffffd1 fffffdfd e92d4030 (e5904010) [ 8.575093] ---[ end trace 04afa547993602ba ]---Quoted 35 lines
History:
v2:
- Added a patch that improves the pipeline upstream/downstream search functions, which no longer require the media device.
- Add a patch to remove getting media device fromv4l2_devdriver data.Steve Longerbeam (8):
media: staging/imx: Switch to sync registration for IPU subdevs
media: staging/imx: Pass device to alloc/free_dma_buf
media: staging/imx: Moveadd_video_deviceintocapture_device_registerRevert "media: imx: Set capture compose rectangle in
capture_device_set_format"
media: staging/imx: Removecapture_device_set_format
media: staging/imx: Re-organize modules
media: staging/imx: Improve pipeline searching
media: staging/imx: Don't set driver data forv4l2_devdrivers/staging/media/imx/Makefile | 18 +- drivers/staging/media/imx/imx-ic-common.c | 68 +-- drivers/staging/media/imx/imx-ic-prp.c | 36 +- drivers/staging/media/imx/imx-ic-prpencvf.c | 88 ++-- drivers/staging/media/imx/imx-ic.h | 6 +- drivers/staging/media/imx/imx-media-capture.c | 75 ++- drivers/staging/media/imx/imx-media-csi.c | 45 +- .../staging/media/imx/imx-media-dev-common.c | 346 +++++++++++++- drivers/staging/media/imx/imx-media-dev.c | 449 +----------------- drivers/staging/media/imx/imx-media-fim.c | 9 - .../staging/media/imx/imx-media-internal-sd.c | 357 ++++++-------- drivers/staging/media/imx/imx-media-of.c | 41 +- drivers/staging/media/imx/imx-media-utils.c | 170 +++---- drivers/staging/media/imx/imx-media-vdic.c | 84 +--- drivers/staging/media/imx/imx-media.h | 113 +++-- drivers/staging/media/imx/imx7-media-csi.c | 43 +- 16 files changed, 848 insertions(+), 1100 deletions(-)