Skip to contentSkip to conversation

ixp4xx: timer and clocks cleanups

PATCH New Krzysztof Halasa 2 participants 3 messages Sep 15, 2009 – Sep 16, 2009 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 ixp4xx: timer and clocks cleanups

Quoted 10 lines · Mikael Pettersson

This patch does a few simple cleanups of the ixp4xx timer and clocksource/clockevent code in mach-ixp4xx/common.c:

- ixp4xx_clocksource_init() is static and always returns 0, which is ignored by its only caller: make it return void
- ixp4xx_clockevent_init(): ditto
- ixp4xx_get_cycles() is only referenced locally: make it static
- use the ixp4xx_timer_irq.dev_id field to pass &clockevent_ixp4xx to ixp4xx_timer_interrupt() via its dev_id parameter, allowing the code in ixp4xx_timer_interrupt() to be smaller and faster

Thanks.

Signature · 1 line
Krzysztof Halasa
#2 lore raw

PATCH 1/1 ixp4xx: timer and clocks cleanups

Quoted 13 lines · Krzysztof Halasa
Quoted 10 lines · Mikael Pettersson

This patch does a few simple cleanups of the ixp4xx timer and clocksource/clockevent code in mach-ixp4xx/common.c:

- ixp4xx_clocksource_init() is static and always returns 0, which is ignored by its only caller: make it return void
- ixp4xx_clockevent_init(): ditto
- ixp4xx_get_cycles() is only referenced locally: make it static
- use the ixp4xx_timer_irq.dev_id field to pass &clockevent_ixp4xx to ixp4xx_timer_interrupt() via its dev_id parameter, allowing the code in ixp4xx_timer_interrupt() to be smaller and faster

Quoted 1 line

Thanks.

Great. Do you want to push these two patches via git or should I add your Acked-by and submit them to the patch system?

/Mikael

#3 lore raw

PATCH 1/1 ixp4xx: timer and clocks cleanups

Quoted 2 lines · Mikael Pettersson

Great. Do you want to push these two patches via git or should I add your Acked-by and submit them to the patch system?

I'll handle them, thanks (by sending to Linus if I understand the recent changes correctly(?)).

Signature · 1 line
Krzysztof Halasa