Skip to contentSkip to conversation

Problem with snd_atiixp in 2.6.8-rc2 (and a workaround)

PATCH Peter Osterlund 3 participants 6 messages Jul 22, 2004 – Jul 27, 2004 Sound

lore
Share & tools
lore

Peter Osterlund

author
#0 lore raw

The snd_atiixp module in the 2.6.8-rc2 kernel doesn't work on my Compaq Presario R3000 (R3057EA) computer. When I load the module, the kernel reports:

ACPI: PCI interrupt 0000:00:14.5[B] -> GSI 5 (level, low) -> IRQ 5 ATI IXP AC97 controller: probe of 0000:00:14.5 failed with error -13

The reason it fails is that snd_ac97_mixer() fails for the second codec (ie when i==1). The patch below makes my sound card work, but that patch was just based on wild guesses and is probably not correct.

lspci reports:

00:14.5 Multimedia audio controller: ATI Technologies Inc IXP150 AC'97 Audio Controller
Subsystem: Hewlett-Packard Company: Unknown device 006b
Flags: bus master, 66Mhz, slow devsel, latency 64, IRQ 5
Memory at e8003000 (32-bit, non-prefetchable)

Any idea how to fix this the right way?

---

 linux-petero/sound/pci/atiixp.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
sound/pci/atiixp.c renamed from sound/pci/atiixp.c~r3000-sound-workaround +4 -3
diff -puN sound/pci/atiixp.c~r3000-sound-workaround sound/pci/atiixp.c
@@ -1387,12 +1387,13 @@ static int __devinit snd_atiixp_mixer_ne
 		ac97.num = i;
 		ac97.scaps = AC97_SCAP_SKIP_MODEM;
 		if ((err = snd_ac97_mixer(pbus, &ac97, &chip->ac97[i])) < 0) {
-			if (chip->codec_not_ready_bits)
+			if (chip->codec_not_ready_bits) {
 				/* codec(s) was detected but not available.
 				 * return the error
 				 */
-				return err;
-			else {
+				chip->ac97[i] = NULL; /* to be sure */
+				continue;
+			} else {
 				/* codec(s) was NOT detected, so just ignore here */
 				chip->ac97[i] = NULL; /* to be sure */
 				snd_printd("atiixp: codec %d not found\n", i);

_

Signature · 2 lines
Peter Osterlund - [email protected]
http://w1.894.telia.com/~u89404340
author
#1 lore raw
Quoted 6 lines · Peter Osterlund

The snd_atiixp module in the 2.6.8-rc2 kernel doesn't work on my Compaq Presario R3000 (R3057EA) computer. When I load the module, the kernel reports:

ACPI: PCI interrupt 0000:00:14.5[B] -> GSI 5 (level, low) -> IRQ 5 ATI IXP AC97 controller: probe of 0000:00:14.5 failed with error -13

I see that this problem has already been fixed in the ALSA CVS, so sorry for the noise, and thanks for the fix.

Signature · 2 lines
Peter Osterlund - [email protected]
http://w1.894.telia.com/~u89404340
#2 lore raw

På lau , 24/07/2004 klokka 15:32, skreiv Peter Osterlund:

Quoted 11 lines
Quoted 6 lines · Peter Osterlund

The snd_atiixp module in the 2.6.8-rc2 kernel doesn't work on my Compaq Presario R3000 (R3057EA) computer. When I load the module, the kernel reports:

ACPI: PCI interrupt 0000:00:14.5[B] -> GSI 5 (level, low) -> IRQ 5 ATI IXP AC97 controller: probe of 0000:00:14.5 failed with error -13

I see that this problem has already been fixed in the ALSA CVS, so sorry for the noise, and thanks for the fix.

It still needs to be fixed in the kernel itself. This bug and the fix were both reported during the 2.6.6 cycle: we're now in 2.6.8-rc2...

Why the delay on such a trivial bug?

Trond

#3 lore raw

At Sat, 24 Jul 2004 16:32:05 -0400,

Quoted 11 lines · Trond Myklebust

På lau , 24/07/2004 klokka 15:32, skreiv Peter Osterlund:

Quoted 9 lines
Quoted 6 lines · Peter Osterlund

The snd_atiixp module in the 2.6.8-rc2 kernel doesn't work on my Compaq Presario R3000 (R3057EA) computer. When I load the module, the kernel reports:

ACPI: PCI interrupt 0000:00:14.5[B] -> GSI 5 (level, low) -> IRQ 5 ATI IXP AC97 controller: probe of 0000:00:14.5 failed with error -13

Quoted 7 lines
Quoted 2 lines

I see that this problem has already been fixed in the ALSA CVS, so sorry for the noise, and thanks for the fix.

It still needs to be fixed in the kernel itself. This bug and the fix were both reported during the 2.6.6 cycle: we're now in 2.6.8-rc2...

Why the delay on such a trivial bug?

It has been already in mm tree for long time...

Takashi

#4 lore raw

På ty , 27/07/2004 klokka 06:51, skreiv Takashi Iwai:

Quoted 6 lines
Quoted 4 lines

It still needs to be fixed in the kernel itself. This bug and the fix were both reported during the 2.6.6 cycle: we're now in 2.6.8-rc2...

Why the delay on such a trivial bug?

It has been already in mm tree for long time...

...and has been available on the ALSA CVS site, yadda, yadda...

That does nothing to change the fact that the *mainline* kernel tree has been stuck with a trivial but irritating bug.

Trond

#5 lore raw

At Tue, 27 Jul 2004 12:30:01 -0400,

Quoted 5 lines · Trond Myklebust

På ty , 27/07/2004 klokka 06:51, skreiv Takashi Iwai:

Quoted 3 lines
Quoted 3 lines

It still needs to be fixed in the kernel itself. This bug and the fix were both reported during the 2.6.6 cycle: we're now in 2.6.8-rc2...

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Why the delay on such a trivial bug?

It has been already in mm tree for long time...

...and has been available on the ALSA CVS site, yadda, yadda...

That does nothing to change the fact that the *mainline* kernel tree has been stuck with a trivial but irritating bug.

The patchset has been ready (that's what Andres includes) since ages, just not taken by Linus.

Takashi