Skip to contentSkip to conversation

bug in cpuid & msr on nosmp machine

PATCH Andi Kleen 1 participant 1 message May 22, 2004 4 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#4 lore raw
Quoted 5 lines · Andrew Morton
Quoted 4 lines · Rusty Russell
Quoted 2 lines · Andrew Morton

I think what you want here is

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
	if (!cpu_possible(cpu) || !cpu_online(cpu))
		return -ENXIO;

It works, but it's not really correct. cpu_possible() is correct, but cpu_online() might no longer be true by the time do_cpu_read() calls do_cpu_id().

mutter. Are we likely to see any ia32 or x86_64 hotplug-cpu machines?

Yes. Think vmware and virtualization, where partitions could get CPUs added and removed at runtime.

-Andi