Skip to contentSkip to conversation

imx8m-blk-ctrl: set ISI panic write hurry level

PATCH In review Krzysztof Hałasa 2 participants 2 messages May 9, 2025 – Jun 18, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx8m-blk-ctrl: set ISI panic write hurry level

Apparently, ISI needs cache settings similar to LCDIF. Otherwise we get artefacts in the image. Tested on i.MX8MP.

drivers/pmdomain/imx/imx8m-blk-ctrl.c +10 -0
index 912802b5215b..5c83e5599f1e 100644
@@ -665,6 +665,11 @@ static const struct imx8m_blk_ctrl_data imx8mn_disp_blk_ctl_dev_data = {
 #define  LCDIF_1_RD_HURRY	GENMASK(15, 13)
 #define  LCDIF_0_RD_HURRY	GENMASK(12, 10)
 
+#define ISI_CACHE_CTRL		0x50
+#define  ISI_V_WR_HURRY		GENMASK(28, 26)
+#define  ISI_U_WR_HURRY		GENMASK(25, 23)
+#define  ISI_Y_WR_HURRY		GENMASK(22, 20)
+
 static int imx8mp_media_power_notifier(struct notifier_block *nb,
 				unsigned long action, void *data)
 {
@@ -694,6 +699,11 @@ static int imx8mp_media_power_notifier(struct notifier_block *nb,
 		regmap_set_bits(bc->regmap, LCDIF_ARCACHE_CTRL,
 				FIELD_PREP(LCDIF_1_RD_HURRY, 7) |
 				FIELD_PREP(LCDIF_0_RD_HURRY, 7));
+		/* Same here for ISI */
+		regmap_set_bits(bc->regmap, ISI_CACHE_CTRL,
+				FIELD_PREP(ISI_V_WR_HURRY, 7) |
+				FIELD_PREP(ISI_U_WR_HURRY, 7) |
+				FIELD_PREP(ISI_Y_WR_HURRY, 7));
 	}
 
 	return NOTIFY_OK;
Signature · 5 lines
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
#1 lore raw
Quoted 6 lines · Krzysztof Hałasa

Apparently, ISI needs cache settings similar to LCDIF. Otherwise we get artefacts in the image. Tested on i.MX8MP.

Applied for next, thanks!

Kind regards
Uffe

Quoted 36 lines
drivers/pmdomain/imx/imx8m-blk-ctrl.c +10 -1
index 912802b5215b..5c83e5599f1e 100644
@@ -665,6 +665,11 @@ static const struct imx8m_blk_ctrl_data imx8mn_disp_blk_ctl_dev_data = {
 #define  LCDIF_1_RD_HURRY      GENMASK(15, 13)
 #define  LCDIF_0_RD_HURRY      GENMASK(12, 10)
 
+#define ISI_CACHE_CTRL         0x50
+#define  ISI_V_WR_HURRY                GENMASK(28, 26)
+#define  ISI_U_WR_HURRY                GENMASK(25, 23)
+#define  ISI_Y_WR_HURRY                GENMASK(22, 20)
+
 static int imx8mp_media_power_notifier(struct notifier_block *nb,
                                unsigned long action, void *data)
 {
@@ -694,6 +699,11 @@ static int imx8mp_media_power_notifier(struct notifier_block *nb,
                regmap_set_bits(bc->regmap, LCDIF_ARCACHE_CTRL,
                                FIELD_PREP(LCDIF_1_RD_HURRY, 7) |
                                FIELD_PREP(LCDIF_0_RD_HURRY, 7));
+               /* Same here for ISI */
+               regmap_set_bits(bc->regmap, ISI_CACHE_CTRL,
+                               FIELD_PREP(ISI_V_WR_HURRY, 7) |
+                               FIELD_PREP(ISI_U_WR_HURRY, 7) |
+                               FIELD_PREP(ISI_Y_WR_HURRY, 7));
        }
 
        return NOTIFY_OK;
 
--

Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa