Skip to contentSkip to conversation

[Fwd: Re: wan/pc300 bug found]

Fwd: Re: wan/pc300 bug found Jeff Garzik 3 participants 5 messages Nov 14, 2006 – Jan 30, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

FYI... I'm certainly willing to remove pc300, if nobody wants it.

But I am unsure whether this is a case of "vendor doesn't care" or "users don't care", which are two very different things...

Jeff

Jeff,

As PC300 is not being produced anymore, we decided that the best solution is to remove its driver from the kernel. I will send you a patch to do so, as soon as possible.

Best regards,

Daniela

-----Original Message-----
From: Jeff Garzik [mailto:[email protected]]
Sent: Sun 10/1/2006 1:35 PM
To: [email protected]; [email protected]; [email protected]; LKML; Andrew Morton
Subject: wan/pc300 bug found

The following gcc warning indicates a bug:

drivers/net/wan/pc300_drv.c: In function 'cpc_open':
drivers/net/wan/pc300_drv.c:2870: warning: 'br' may be used uninitialized in this function

clock_rate_calc() is not checked for a negative return value.

#1 lore raw
Quoted 4 lines · Jeff Garzik

FYI... I'm certainly willing to remove pc300, if nobody wants it.

But I am unsure whether this is a case of "vendor doesn't care" or "users don't care", which are two very different things...

Well, I'm not a user of such card, but I know there are many users at least here in Brazil, I guess it should stay.

- Arnaldo

#2 lore raw
In reply to Jeff Garzik
Quoted 4 lines · Jeff Garzik

FYI... I'm certainly willing to remove pc300, if nobody wants it.

But I am unsure whether this is a case of "vendor doesn't care" or "users don't care", which are two very different things...

I have a driver for PC300/RSV (dual V.35 + V.24) for years. I'm told it works with X.21 version too. If someone has a spare T1/E1 card (non-returnable donation only) I can try to add support as well.

T1/E1 is too complicated to maintain without the actual hardware.

Perhaps we should add my driver to the tree, mark the old one as obsolete and look for angry reports from T1/E1 users?

My driver(s) doesn't support MLPPP but that's probably easy to change if there is any interest.

Signature · 1 line
Krzysztof Halasa
#3 lore raw
Quoted 7 lines · Krzysztof Halasa
Quoted 4 lines · Jeff Garzik

FYI... I'm certainly willing to remove pc300, if nobody wants it.

But I am unsure whether this is a case of "vendor doesn't care" or "users don't care", which are two very different things...

Quoted 8 lines

I have a driver for PC300/RSV (dual V.35 + V.24) for years. I'm told it works with X.21 version too. If someone has a spare T1/E1 card (non-returnable donation only) I can try to add support as well.

T1/E1 is too complicated to maintain without the actual hardware.

Perhaps we should add my driver to the tree, mark the old one as obsolete and look for angry reports from T1/E1 users?

No objections...

Jeff

#4 lore raw

Hi,

Quoted 8 lines · Jeff Garzik
Quoted 6 lines

I have a driver for PC300/RSV (dual V.35 + V.24) for years. I'm told it works with X.21 version too. If someone has a spare T1/E1 card (non-returnable donation only) I can try to add support as well. T1/E1 is too complicated to maintain without the actual hardware. Perhaps we should add my driver to the tree, mark the old one as obsolete and look for angry reports from T1/E1 users?

No objections...

Great. I'm not marking the original pc300 driver as obsolete
- should I? It supports (at least theoretically) multi line PPP and PC300 T1/E1, my drivers don't.

Signature · 1 line
Krzysztof Halasa