Skip to contentSkip to conversation

Fix spurious error return in FBIO_RADEON_SET_MIRROR

DISCUSSION Andreas Schwab 1 participant 1 message Jan 26, 2005

lore
Share & tools
lore
#0 lore raw

FBIO_RADEON_SET_MIRROR always returns with -EINVAL even if successful due to an inappropriate fall-through.

--- linux-2.6.10/drivers/video/aty/radeon_base.c.~1~ 2004-12-29 20:17:12.00=
0000000 +0100
+++ linux-2.6.10/drivers/video/aty/radeon_base.c 2005-01-26 01:48:17.000000=
000 +0100
@@ -911,7 +911,7 @@ static int radeonfb_ioctl (struct inode=20 =20
OUTREG(CRTC_EXT_CNTL, tmp);
=20
- break;
+ return 0;
case FBIO_RADEON_GET_MIRROR:
if (!rinfo->is_mobility)
return -EINVAL;

Andreas.

--=20
Andreas Schwab, SuSE Labs, [email protected]
SuSE Linux Products GmbH, Maxfeldstra=C3=9Fe 5, 90409 N=C3=BCrnberg, Germany Key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."