Skip to contentSkip to conversation

s390 (9/9): no timer interrupts in idle.

PATCH Andi Kleen 1 participant 1 message Apr 21, 2004 4 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#4 lore raw
Quoted 8 lines · Dipankar Sarma
Quoted 7 lines · Christoph Hellwig
Quoted 4 lines · Dipankar Sarma

I think CPU_MASK_NONE can be used only for assignments. You need to actually declare a generic idle_cpu_mask and set it to CPU_MASK_NONE for all other archs. Of course, then the compiler will not be able to optimize it out :)

Well, there's a const keyword in C these days, no?

It is not strong enough in C unfortunately. It is still legal to change const variables, so the compiler has to take that into account and it is hard for global variables. C++ is better here.

Quoted 2 lines

OK, then I missed what optimization you were talking about or underestimated gcc. Can gcc do inter-procedural constant propagation ?

Only when the functions are inlined
(but it is much better at that than it used to be, gcc 3.4 can even inline across multiple files and order doesn't matter anymore)

-Andi