Skip to contentSkip to conversation

mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'

PATCH New Shawn Guo 3 participants 7 messages Mar 14, 2011 – Mar 31, 2011 MMC, SD and SDIO

lore
Share & tools
lore

Shawn Guo

author
#0 lore raw

PATCH 1/1 mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'

The MMC_SDHCI based driver is either based on MMC_SDHCI_PLTFM or MMC_SDHCI_OF. As both parent CONFIG are 'tristate', it may make sense to get all children drivers CONFIG as 'tristate'.

Signed-off-by Shawn Guo <[email protected]>
---
 drivers/mmc/host/Kconfig |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/mmc/host/Kconfig +5 -5
index afe8c6f..f98adbf 100644
@@ -91,7 +91,7 @@ config MMC_SDHCI_OF
 	  If unsure, say N.
 
 config MMC_SDHCI_OF_ESDHC
-	bool "SDHCI OF support for the Freescale eSDHC controller"
+	tristate "SDHCI OF support for the Freescale eSDHC controller"
 	depends on MMC_SDHCI_OF
 	depends on PPC_OF
 	select MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER

@@ -101,7 +101,7 @@ config MMC_SDHCI_OF_ESDHC
 	  If unsure, say N.
 
 config MMC_SDHCI_OF_HLWD
-	bool "SDHCI OF support for the Nintendo Wii SDHCI controllers"
+	tristate "SDHCI OF support for the Nintendo Wii SDHCI controllers"
 	depends on MMC_SDHCI_OF
 	depends on PPC_OF
 	select MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER

@@ -124,7 +124,7 @@ config MMC_SDHCI_PLTFM
 	  If unsure, say N.
 
 config MMC_SDHCI_CNS3XXX
-	bool "SDHCI support on the Cavium Networks CNS3xxx SoC"
+	tristate "SDHCI support on the Cavium Networks CNS3xxx SoC"
 	depends on ARCH_CNS3XXX
 	depends on MMC_SDHCI_PLTFM
 	help

@@ -133,7 +133,7 @@ config MMC_SDHCI_CNS3XXX
 	  If unsure, say N.
 
 config MMC_SDHCI_ESDHC_IMX
-	bool "SDHCI platform support for the Freescale eSDHC i.MX controller"
+	tristate "SDHCI platform support for the Freescale eSDHC i.MX controller"
 	depends on MMC_SDHCI_PLTFM && (ARCH_MX25 || ARCH_MX35 || ARCH_MX5)
 	select MMC_SDHCI_IO_ACCESSORS
 	help

@@ -143,7 +143,7 @@ config MMC_SDHCI_ESDHC_IMX
 	  If unsure, say N.
 
 config MMC_SDHCI_DOVE
-	bool "SDHCI support on Marvell's Dove SoC"
+	tristate "SDHCI support on Marvell's Dove SoC"
 	depends on ARCH_DOVE
 	depends on MMC_SDHCI_PLTFM
 	select MMC_SDHCI_IO_ACCESSORS
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 1/1 mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'

Hi Chris,

Any comment on this one?

Signature · 2 lines
Regards,
Shawn
Quoted 61 lines · Shawn Guo

The MMC_SDHCI based driver is either based on MMC_SDHCI_PLTFM or MMC_SDHCI_OF. As both parent CONFIG are 'tristate', it may make sense to get all children drivers CONFIG as 'tristate'.

Signed-off-by Shawn Guo <[email protected]>
---
 drivers/mmc/host/Kconfig |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/mmc/host/Kconfig +5 -5
index afe8c6f..f98adbf 100644
@@ -91,7 +91,7 @@ config MMC_SDHCI_OF
 	  If unsure, say N.
 
 config MMC_SDHCI_OF_ESDHC
-	bool "SDHCI OF support for the Freescale eSDHC controller"
+	tristate "SDHCI OF support for the Freescale eSDHC controller"
 	depends on MMC_SDHCI_OF
 	depends on PPC_OF
 	select MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER

@@ -101,7 +101,7 @@ config MMC_SDHCI_OF_ESDHC
 	  If unsure, say N.
 
 config MMC_SDHCI_OF_HLWD
-	bool "SDHCI OF support for the Nintendo Wii SDHCI controllers"
+	tristate "SDHCI OF support for the Nintendo Wii SDHCI controllers"
 	depends on MMC_SDHCI_OF
 	depends on PPC_OF
 	select MMC_SDHCI_BIG_ENDIAN_32BIT_BYTE_SWAPPER

@@ -124,7 +124,7 @@ config MMC_SDHCI_PLTFM
 	  If unsure, say N.
 
 config MMC_SDHCI_CNS3XXX
-	bool "SDHCI support on the Cavium Networks CNS3xxx SoC"
+	tristate "SDHCI support on the Cavium Networks CNS3xxx SoC"
 	depends on ARCH_CNS3XXX
 	depends on MMC_SDHCI_PLTFM
 	help

@@ -133,7 +133,7 @@ config MMC_SDHCI_CNS3XXX
 	  If unsure, say N.
 
 config MMC_SDHCI_ESDHC_IMX
-	bool "SDHCI platform support for the Freescale eSDHC i.MX controller"
+	tristate "SDHCI platform support for the Freescale eSDHC i.MX controller"
 	depends on MMC_SDHCI_PLTFM && (ARCH_MX25 || ARCH_MX35 || ARCH_MX5)
 	select MMC_SDHCI_IO_ACCESSORS
 	help

@@ -143,7 +143,7 @@ config MMC_SDHCI_ESDHC_IMX
 	  If unsure, say N.
 
 config MMC_SDHCI_DOVE
-	bool "SDHCI support on Marvell's Dove SoC"
+	tristate "SDHCI support on Marvell's Dove SoC"
 	depends on ARCH_DOVE
 	depends on MMC_SDHCI_PLTFM
 	select MMC_SDHCI_IO_ACCESSORS
Signature · 1 line
1.7.1
#2 lore raw

PATCH 1/1 mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'

Hi Shawn,

Quoted 3 lines · Shawn Guo

Hi Chris,

Any comment on this one?

Yep, I'll push it to mmc-next once -rc1 is released.

Thanks,

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
#3 lore raw

PATCH 1/1 mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'

Quoted 5 lines · Chris Ball

Hi Shawn,

Quoted 2 lines · Shawn Guo

Hi Chris,

Quoted 7 lines
Quoted 1 line

Any comment on this one?

Yep, I'll push it to mmc-next once -rc1 is released.

Thanks,

- Chris.

That patch doesn't make much sense. The config options are used to decide whether support for that platform should be build into the sdhci-platform or sdhci-of module. So setting them 'm' doesn't make any sense, since you can't build part of an module as a module. The effect for 'm' will probably be the same as for 'n'.

- Lars

#4 lore raw

PATCH 1/1 mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'

Hi Lars,

Quoted 5 lines · Lars-Peter Clausen

That patch doesn't make much sense. The config options are used to decide whether support for that platform should be build into the sdhci-platform or sdhci-of module. So setting them 'm' doesn't make any sense, since you can't build part of an module as a module. The effect for 'm' will probably be the same as for 'n'.

Thanks, makes sense -- I'll drop the patch.

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
author
#5 lore raw

PATCH 1/1 mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'

Quoted 11 lines · Chris Ball

Hi Lars,

Quoted 5 lines · Lars-Peter Clausen

That patch doesn't make much sense. The config options are used to decide whether support for that platform should be build into the sdhci-platform or sdhci-of module. So setting them 'm' doesn't make any sense, since you can't build part of an module as a module. The effect for 'm' will probably be the same as for 'n'.

Thanks, makes sense -- I'll drop the patch.

Then, you are going to need the patch below I just posted in the same thread.

[PATCH] mmc: sdhci: change CONFIG of MMC_SDHCI_TEGRA from 'tristate' to 'bool'

Signature · 2 lines
Regards,
Shawn
author
#6 lore raw

PATCH 1/1 mmc: sdhci: change CONFIG of MMC_SDHCI_TEGRA from 'tristate' to 'bool'

In reply to Shawn Guo

From: Shawn Guo <[email protected]>

This config option is used to decide whether tegra sdhci support should be build into the sdhci-platform module. So setting it 'm' is nonsense, since we can't build part of an module as a module. The effect for 'm' will probably be the same as for 'n'.

Signed-off-by Shawn Guo <[email protected]>

---
The commit message comes from the comment given by Lars-Peter Clausen on another Naked patch :)

 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/Kconfig +1 -1
index 94df405..b981715 100644
@@ -154,7 +154,7 @@ config MMC_SDHCI_DOVE
 	  If unsure, say N.
 
 config MMC_SDHCI_TEGRA
-	tristate "SDHCI platform support for the Tegra SD/MMC Controller"
+	bool "SDHCI platform support for the Tegra SD/MMC Controller"
 	depends on MMC_SDHCI_PLTFM && ARCH_TEGRA
 	select MMC_SDHCI_IO_ACCESSORS
 	help
Signature · 1 line
1.7.1