Skip to contentSkip to conversation

arch/mips/loongson/common/mem.c: fix phys_mem_access_prot() check

PATCH Applied Arnaud Patard 2 participants 2 messages Apr 29, 2010 MIPS

lore
Share & tools
lore

Arnaud Patard

author
#0 lore raw

PATCH 1/1 arch/mips/loongson/common/mem.c: fix phys_mem_access_prot() check

The check used to determine if uncached accelerated should be used or not is wrong. The parenthesis are misplaced and making the test fail.

Signed-off-by Arnaud Patard <[email protected]>

---

arch/mips/loongson/common/mem.c +1 -1
Index: linux-2.6/arch/mips/loongson/common/mem.c
===================================================================
@@ -75,7 +75,7 @@ pgprot_t phys_mem_access_prot(struct fil
 	unsigned long end = offset + size;
 
 	if (__uncached_access(file, offset)) {
-		if (((uca_start && offset) >= uca_start) &&
+		if (uca_start && (offset >= uca_start) &&
 		    (end <= uca_end))
 			return __pgprot((pgprot_val(vma_prot) &
 					 ~_CACHE_MASK) |
Applied
#1 lore raw
Quoted 4 lines · Arnaud Patard

The check used to determine if uncached accelerated should be used or not is wrong. The parenthesis are misplaced and making the test fail.

Signed-off-by Arnaud Patard <[email protected]>

Thanks, applied.

Ralf