Changes to IRQs.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 56 lines · Krzysztof Halasa
Trivial changes to IRQs.
Signed-off-by Krzysztof Hałasa <[email protected]>Documentation/DocBook/genericirq.tmpl +2
-2@@ -417,8 +417,8 @@ desc->chip->end(); </para> <para> To make use of the split implementation, replace the call to - __do_IRQ by a call to desc->chip->handle_irq() and associate - the appropriate handler function to desc->chip->handle_irq(). + __do_IRQ by a call to desc->handle_irq() and associate + the appropriate handler function to desc->handle_irq(). In most cases the generic handler implementations should be sufficient. </para>arch/arm/include/asm/hw_irq.h +0
-8@@ -10,14 +10,6 @@ static inline void ack_bad_irq(int irq) irq_err_count++; } -/* -* Obsolete inline function for calling irq descriptor handlers. -*/ -static inline void desc_handle_irq (unsigned int irq,struct irq_desc *desc) -{ - desc->handle_irq (irq, desc); -} -void set_irq_flags (unsigned int irq,unsigned int flags);#define IRQF_VALID (1 << 0)arch/arm/plat-orion/gpio.c +1
-1@@ -354,6 +354,6 @@ void orion_gpio_irq_handler(int pinoff) polarity ^=1 << (pin &31 );writel (polarity,GPIO_IN_POL (pin)); } -desc_handle_irq (irq, desc); + desc->handle_irq (irq, desc); } }include/linux/irq.h +0
-0
include/linux/irq.h extern irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action); · line 287
Quoted 8 lines
include/linux/irq.h +1
-1@@ -281,7 +281,7 @@ extern irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action);/* * Built-in IRQ handlers for various IRQ types, -* callable via desc->chip->handle_irq() +* callable via desc->handle_irq() */ extern void handle_level_irq (unsigned int irq,struct irq_desc *desc);extern void handle_fasteoi_irq (unsigned int irq,struct irq_desc *desc);
This doesn't really qualify for trivial queue, adding ARM addressess to CC (I hope I got them right after the latest flame :P) at least for the ARM bits.
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.
Quoted 2 lines · Jiri Kosina
This doesn't really qualify for trivial queue, adding ARM addressess to CC (I hope I got them right after the latest flame :P)
Hmm, apparently I did not.
<[email protected]>: host
lists.arm.linux.org.uk[78.32.30.220] said: 550 Please direct your message to the new mailing lists on lists.infradead.org (in reply to RCPT TO command)
Could someone please update MAINTAINERS to reflect reality? I am apparently not smart enough to keep track of the current situation with the ARM mailinglists. I thought that final decision was [email protected]. MAINTAINERS lists [email protected], but the bounce suggests to use lists.infradead.org ...
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.
PATCH 1/1 Changes to IRQs.
Quoted 10 lines · Jiri Kosina
Could someone please update
MAINTAINERSto reflect reality? I am apparently not smart enough to keep track of the current situation with
the ARM mailinglists. I thought that final decision was linux-arm at vger.kernel.org.MAINTAINERSlists linux-arm-kernel at lists.arm.linux.org.uk, but the bounce suggests to use
lists.infradead.org ...
I submitted that patch some time ago. I believe Russell is going to chase it up with his signed-off-by.
Signature · 1 line
dwmw2
Quoted 3 lines · Jiri Kosina
This doesn't really qualify for trivial queue, adding ARM addressess to CC (I hope I got them right after the latest flame :P) at least for the ARM bits.
(Fixed the arm ml address, and lkml too (my mistake)).
But you noticed, of course, that the only real change is that to the arch/arm/plat-orion/gpio.c? Just asking to make sure as the patch may look longer than it is.
Quoted 9 lines
Review desc->chip->end(); · line 421
Quoted 9 lines
+++ b/Documentation/DocBook/genericirq.tmpl
(quoted diff) +2
-2@@ -417,8 +417,8 @@ desc->chip->end(); </para> <para> To make use of the split implementation, replace the call to - __do_IRQ by a call to desc->chip->handle_irq() and associate - the appropriate handler function to desc->chip->handle_irq(). + __do_IRQ by a call to desc->handle_irq() and associate + the appropriate handler function to desc->handle_irq().
Only the comment fix, the code has been changed long ago.
Quoted 5 lines
Quoted 5 lines
(quoted diff) +1
-0+++ b/arch/arm/include/asm/hw_irq.h@@ -10,14 +10,6 @@ static inline void ack_bad_irq(int irq) irq_err_count++; }
Quoted 7 lines
Review static inline void ack_bad_irq(int irq) · line 19
Quoted 7 lines
(quoted diff) +0
-7-/* - * Obsolete inline function for calling irq descriptor handlers. - */ -static inline void desc_handle_irq(unsigned int irq, struct irq_desc *desc) -{ - desc->handle_irq(irq, desc); -}
IIRC there had been no users of this function for some time, one has been added recently...
Quoted 9 lines
Review void orion_gpio_irq_handler(int pinoff) · line 359
Quoted 9 lines
(quoted diff) +2
-1+++ b/arch/arm/plat-orion/gpio.c@@ -354,6 +354,6 @@ void orion_gpio_irq_handler(int pinoff) polarity ^= 1 << (pin & 31); writel(polarity, GPIO_IN_POL(pin)); } - desc_handle_irq(irq, desc); + desc->handle_irq(irq, desc); } }
That's the one. I've little doubt someone did that by mistake.
Quoted 7 lines
Review extern irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action); · line 284
Quoted 7 lines
+++
b/include/linux/irq.h(quoted diff) +1
-1@@ -281,7 +281,7 @@ extern irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action); /* * Built-in IRQ handlers for various IRQ types, - * callable via desc->chip->handle_irq() + * callable via desc->handle_irq()
The code has been changed long ago, the patch only fixes comments.
But of course I'm not insisting, just wanted to flush my queue of such things out.
Signature · 1 line
Krzysztof Halasa