Skip to contentSkip to conversation

vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc

PATCH RESEND Applied TeLeMan 3 participants 3 messages May 12, 2010 – May 22, 2010

lore
Share & tools
lore

TeLeMan

author
#0 lore raw

PATCH RESEND 1/1 vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc

cirrus_post_load() will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu.

---
 hw/cirrus_vga.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
hw/cirrus_vga.c +0 -0
index 9dfe76a..262ba9c 100644
@@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga

= {
.version_id = 2,
.minimum_version_id = 2, .minimum_version_id_old = 2,
- .post_load = cirrus_post_load,
.fields = (VMStateField []) {
VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState), VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0,
--
SUN OF A BEACH

Applied
#2 lore raw
In reply to TeLeMan

Thanks, applied.

Quoted 25 lines · TeLeMan

cirrus_post_load() will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu.

---
 hw/cirrus_vga.c |    1 -

 1 files changed, 0 insertions(+), 1 deletions(-)
hw/cirrus_vga.c +0 -1
index 9dfe76a..262ba9c 100644
@@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga
 = {
     .version_id = 2,
     .minimum_version_id = 2,
     .minimum_version_id_old = 2,
-    .post_load = cirrus_post_load,
     .fields      = (VMStateField []) {
         VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState),

        VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0, --
SUN OF A BEACH