vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc
PATCH RESEND 1/1 vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc
cirrus_post_load() will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu.
--- hw/cirrus_vga.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
hw/cirrus_vga.c +0 -0
@@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga
= {
.version_id = 2,
.minimum_version_id = 2, .minimum_version_id_old = 2,
- .post_load = cirrus_post_load,
.fields = (VMStateField []) {
VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState), VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0,
--
SUN OF A BEACH
Quoted 4 lines · TeLeMan
cirrus_post_load()will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu.Signed-off-by TeLeMan <[email protected]>
Nice catch.
Blue Swirl
AppliedThanks, applied.
Quoted 25 lines · TeLeMan
cirrus_post_load()will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu.Signed-off-by TeLeMan <[email protected]>---
hw/cirrus_vga.c | 1 -1 files changed, 0 insertions(+), 1 deletions(-)hw/cirrus_vga.c +0
-1@@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga = { .version_id = 2, .minimum_version_id = 2, .minimum_version_id_old = 2, - .post_load = cirrus_post_load, .fields = (VMStateField []) { VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState),VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0, --
SUN OF A BEACH