makedevs: Use sync(2) instead running /bin/sync
PATCH 1/1 makedevs: Use sync(2) instead running /bin/sync
When compiled -O2 -D_FORTIFY_SOURCE=2 with gcc v4, the call system("/bin/sync") causes a fatal error,
makedevs.c:531: error: ignoring return value of ?system?
This is the case (by default) on Ubuntu 8.10; for details see https://wiki.kubuntu.org/CompilerFlags
In any case, using system(3) to run (via the shell) sync(1) is silly. Avoid the issues by directly calling sync(2).
Signed-off-by Brian Foster <[email protected]>
---
This patch is against r22481.
It fixes Innova Card defect http://busybox.net/bugs/view.php?id=1090.
target/makedevs/makedevs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
target/makedevs/makedevs.c +1 -1
@@ -528,7 +528,7 @@ loop: }fclose (table); -system ("/bin/sync" ); +sync ();return 0 ; }
Signature · 12 lines
1.6.0.4 ====================================================================== Issue History Date Modified Username Field Change ====================================================================== 11-21-08 06:01 blf New Issue 11-21-08 06:01 blf Status new => assigned 11-21-08 06:01 blf Assigned To => buildroot ======================================================================