Skip to contentSkip to conversation

board_r: run scsi init() on ARM too

PATCH New Ian Campbell 1 participant 1 message May 7, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 board_r: run scsi init() on ARM too

This has been disabled for ARM in initr_scsi since that function was introduced. However it works fine for me on Cubieboard and Cubietruck (with the upcoming AHCI glue patch).

I also tested on two random ARM platforms which seem to define CONFIG_CMD_SCSI:
- highbank worked fine (on midway hardware)
- omap5_uevm built OK and I confirmed using objdump that things were as expected (i.e. the default weak scsi_init nop was used).

While there remove the mismatched comment from the #endif (omitting the comment seems to be the prevailing style in this file).

---
 common/board_r.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
common/board_r.c +1 -4
index 602a239..4479acb 100644
@@ -588,15 +588,12 @@ static int initr_status_led(void)
 #if defined(CONFIG_CMD_SCSI)
 static int initr_scsi(void)
 {
-	/* Not supported properly on ARM yet */
-#ifndef CONFIG_ARM
 	puts("SCSI:  ");
 	scsi_init();
-#endif
 
 	return 0;
 }
-#endif /* CONFIG_CMD_NET */
+#endif
 
 #if defined(CONFIG_CMD_DOC)
 static int initr_doc(void)
Signature · 1 line
2.0.1