usb: atm: cxacru: fix NULL pointer dereference on uninitialized atm_dev
Subsystems (3)
PATCH 1/1 usb: atm: cxacru: fix NULL pointer dereference on uninitialized atm_dev
Your message has been rejected, probably because you are not subscribed to the mailing list and the list's policy is to prohibit non-members from posting to it. If you think that your messages are being rejected in error, contact the mailing list owner at [email protected].
From: "Wang, Jie" <[email protected]>
The cxacru driver uses the usbatm framework, which defers the ATM device registration to a kernel thread (usbatm_do_heavy_init()) but immediately returns success from the USB probe. Because the probe returns success, the driver core creates sysfs attribute files (like adsl_state and adsl_config), making them accessible to userspace before the ATM device is fully initialized.
If a user writes to these sysfs files before the initialization is complete or if it fails, the driver attempts to send a command to the device. If the command fails, the error handling path calls atm_err(), which unconditionally dereferences instance->usbatm->atm_dev. Since atm_dev is NULL, this leads to a NULL pointer dereference:
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000002: 0000 [#1] SMP KASAN NOPTI KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017] RIP: 0010:adsl_state_store+0x5cc/0x770 drivers/usb/atm/cxacru.c:359 Call Trace: <TASK> kernfs_fop_write_iter+0x3a4/0x540 fs/kernfs/file.c:345 new_sync_write fs/read_write.c:595 [inline] vfs_write+0x612/0xba0 fs/read_write.c:687 ksys_write+0x150/0x270 fs/read_write.c:739 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f </TASK>
To fix this, add checks for instance->usbatm->atm_dev == NULL in adsl_state_store() and adsl_config_store(). This prevents the functions from proceeding and dereferencing the uninitialized atm_dev, consistent with how mac_address_show() handles the same race condition.
---
drivers/usb/atm/cxacru.c +2 -2
@@ -347,7 +347,7 @@ static ssize_t adsl_state_store(struct device *dev,return -EINVAL ; ret =0 ; -if (instance ==NULL ) +if (instance ==NULL || instance->usbatm->atm_dev ==NULL )return -ENODEV ;if (mutex_lock_interruptible (&instance->adsl_state_serialize))
@@ -444,7 +444,7 @@ static ssize_t adsl_config_store(struct device *dev,if (!capable (CAP_NET_ADMIN ))return -EACCES ; -if (instance ==NULL ) +if (instance ==NULL || instance->usbatm->atm_dev ==NULL )return -ENODEV ; pos =0 ;
base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
Signature · 4 lines
See https://goo.gle/syzbot-ai-patches for information about AI-generated patches. The person who has signed off on the patch is responsible for addressing comments. syzbot engineers can be reached at [email protected].