Skip to contentSkip to conversation

pxa3xx_nand: show the real time used by the controller

PATCH New Lei Wen 1 participant 1 message Mar 29, 2010

Subsystems (4)
lore
Share & tools
lore

Lei Wen

author
#0 lore raw

PATCH 1/1 pxa3xx_nand: show the real time used by the controller

The electronic signal timing is not that simple that we set to timing register. Sometimes it is difficult to find current timing is not what NAND chip spec want. So we add show real timing function to give intuitive check whether current timing meet the need.

---
 arch/arm/plat-pxa/include/plat/pxa3xx_nand.h |    1 +
 drivers/mtd/nand/pxa3xx_nand.c               |  239 ++++++++++++++++++++------
 2 files changed, 189 insertions(+), 51 deletions(-)
(quoted diff) +0 -0

b/arch/arm/plat-pxa/include/plat/pxa3xx_nand.h
index 7c99390..c428897 100644

arch/arm/plat-pxa/include/plat/pxa3xx_nand.h +1 -0
@@ -15,6 +15,7 @@ struct pxa3xx_nand_platform_data {
 
 	/* Whether the controller support using naked command set */
 	int	naked_cmd_support;
+	unsigned int RD_CNT_DEL;
 
 	const struct mtd_partition		*parts[NUM_CHIP_SELECT];
 	unsigned int				nr_parts[NUM_CHIP_SELECT];
drivers/mtd/nand/pxa3xx_nand.c +44 -30

117 lines not on this page · raw message

long nand_clk)
+{
+ uint32_t rtADL, rtCH, rtCS, rtWH, rtWP, rtRH, rtRP;
+ uint32_t rtR, rtRHW, rtWHR, rtAR, tmp;
+
+ rtCH = ((ndtr0 >> 19) & 0x7) + 1;
+ rtCS = ((ndtr0 >> 16) & 0x7) + 1;
+ rtWH = ((ndtr0 >> 11) & 0x7) + 1;
+ rtWP = ((ndtr0 >> 8) & 0x7) + 1;
+ rtADL= (ndtr0 >> 27) & 0x1f;
+ rtRH = ((ndtr0 >> 3) & 0x7) + 1;
+ rtRP = (ndtr0 & NDTR0_ETRP) ? ((0x8 | (ndtr0 & 0x7)) + 1)
+ : ((ndtr0 & 0x7) + 1);
+ rtRHW = (ndtr1 >> 8) & 0x3;
+ rtWHR = (ndtr1 >> 4) & 0xf;
+ rtAR = ndtr1 & 0xf;
+ rtR = (ndtr1 >> 16) & 0xffff;
+
+ if (ndtr1 & NDTR1_PRESCALE)
+ rtR *= 16;
+
+ rtR += rtCH + 2;
+ switch(rtRHW) {
+ case 0:
+ rtRHW = 0;
+ break;
+ case 1:
+ rtRHW = 16;
+ break;
+ case 2:
+ rtRHW = 32;
+ break;
+ case 3:
+ rtRHW = 48;
+ break;
+ }

-/* convert nano-seconds to nand flash controller clock cycles */
-#define ns2cycle(ns, clk) (int)(((ns) * (clk / 1000000) / 1000) - 1)
+ /*
+ * TWHR delay=max(tAR, max(0, tWHR-max(tWH, tCH)))
+ * TAR delay=max(tAR, max(0, tWHR-max(tWH, tCH))) + 2
+ */
+ if (rtWH > rtCH)
+ tmp = rtWH - 1;
+ else
+ tmp = rtCH - 1;
+ if (rtADL != 0) {
+ rtADL = rtADL - 3 - rtWP;
+ rtADL = rtADL > 0 ? rtADL : 0;
+ rtADL = rtADL + tmp + rtWP + 8;
+ }
+ if (rtWHR < tmp)
+ rtWHR = rtAR;
+ else {
+ if (rtAR > (rtWHR - tmp))
+ rtWHR = rtAR;
+ else
+ rtWHR = rtWHR - tmp;
+ }
+ rtAR = rtWHR + 2;
+ printk("Shows real timing(ns):\n");
+ if (ndtr0 & NDTR0_SELCNTR)
+ printk("NDTR0 SELCNTR is set\n");
+ else
+ printk("NDTR0 SELCNTR is not set\n");
+ if (ndtr0 & NDTR0_RD_CNT_DEL_MASK)
+ printk("Read Strobe delay is %d\n",
+ (ndtr0 & NDTR0_RD_CNT_DEL_MASK) >> 22);
+ else
+ printk("No Read Stobe delay\n");
+ if (ndtr0 & NDTR0_sel_NRE_EDGE)
+ printk("Controller is using falling edge to detect RE\n");
+ else
+ printk("Controller is using rising edge to detect RE\n");

-/* convert nand flash controller clock cycles to nano-seconds */
-#define cycle2ns(c, clk) ((((c) + 1) * 1000000 + clk / 500) / (clk / 1000))
+ if (ndtr1 & NDTR1_WAIT_MODE)
+ printk("NDTR1 wait mode is set\n");
+ else
+ printk("NDTR1 wait mode is not set\n");
+
+ printk("TADL is %ld TCH is %ld TCS is %ld TWH is %ld TWP is %ld TRH is %ld "
+ "TRP is %ld TR is %ld TRHW is %ld TWHR is %ld TAR is %ld\n",
+ cycle2ns(rtADL, nand_clk), cycle2ns(rtCH, nand_clk),
+ cycle2ns(rtCS, nand_clk), cycle2ns(rtWH, nand_clk),
+ cycle2ns(rtWP, nand_clk), cycle2ns(rtRH, nand_clk),
+ cycle2ns(rtRP, nand_clk), cycle2ns(rtR, nand_clk),
+ cycle2ns(rtRHW, nand_clk), cycle2ns(rtWHR, nand_clk),
+ cycle2ns(rtAR, nand_clk));
+}

static void pxa3xx_nand_set_timing(struct pxa3xx_nand_info *info,
- const struct pxa3xx_nand_timing *t)
+ struct pxa3xx_nand_timing *t, int show_timing)
{
struct pxa3xx_nand *nand = info->nand_data; unsigned long nand_clk;
- uint32_t ndtr0, ndtr1;
+ uint32_t ndtr0, ndtr1, tRP, tR, tRHW, tADL;

nand_clk = clk_get_rate(nand->clk);
- ndtr0 = NDTR0_tCH(ns2cycle(t->tCH, nand_clk)) |

-		NDTR0_tCS(ns2cycle(t->tCS, nand_clk)) |
-		NDTR0_tWH(ns2cycle(t->tWH, nand_clk)) |
-		NDTR0_tWP(ns2cycle(t->tWP, nand_clk)) |
-		NDTR0_tRH(ns2cycle(t->tRH, nand_clk)) |

- NDTR0_tRP(ns2cycle(t->tRP, nand_clk));
+ ndtr0 = ndtr1 = 0;
+ tRP = ns2cycle(t->tRP, nand_clk);
+ tRP = (tRP > 0xf) ? 0xf : tRP;
+ if (tRP > 0x7) {
+ ndtr0 |= NDTR0_ETRP;
+ tRP -= 0x7;
+ }
+ tR = ns2cycle(t->tR, nand_clk);
+ if (tR > 0xffff) {
+ ndtr1 |= NDTR1_PRESCALE;
+ tR /= 16;
+ }
+ if (t->tRHW > 0) {
+ tRHW = ns2cycle(t->tRHW, nand_clk);
+ if (tRHW < 16)
+ tRHW = 1;
+ else {
+ if (tRHW < 32)
+ tRHW = 2;
+ else
+ tRHW = 3;
+ }
+ }
+ else
+ tRHW = 0;
+ tADL = (t->tADL > 0) ? ns2cycle(t->tADL, nand_clk) : 0;
+
+ if (nand->RD_CNT_DEL > 0)
+ ndtr0 |= NDTR0_SELCNTR
+ | (NDTR0_RD_CNT_DEL(nand->RD_CNT_DEL - 1));
+
+ ndtr0 |= NDTR0_tADL(tADL)

+		| NDTR0_tCH(ns2cycle(t->tCH, nand_clk))
+		| NDTR0_tCS(ns2cycle(t->tCS, nand_clk))
+		| NDTR0_tWH(ns2cycle(t->tWH, nand_clk))
+		| NDTR0_tWP(ns2cycle(t->tWP, nand_clk))
+		| NDTR0_tRH(ns2cycle(t->tRH, nand_clk))
+		| NDTR0_tRP(tRP)
+		| NDTR0_SELCNTR;

+
+ if (nand->wait_mode)
+ ndtr1 |= NDTR1_WAIT_MODE;
+
+ ndtr1 |= NDTR1_tR(tR)

+		| NDTR1_tRHW(tRHW)
+		| NDTR1_tWHR(ns2cycle(t->tWHR, nand_clk))
+		| NDTR1_tAR(ns2cycle(t->tAR, nand_clk));

- ndtr1 = NDTR1_tR(ns2cycle(t->tR, nand_clk)) |
- NDTR1_tWHR(ns2cycle(t->tWHR, nand_clk)) |
- NDTR1_tAR(ns2cycle(t->tAR, nand_clk));

- info->ndtr0cs0 = ndtr0;
- info->ndtr1cs0 = ndtr1;
nand_writel(nand, NDTR0CS0, ndtr0);
nand_writel(nand, NDTR1CS0, ndtr1);
+ nand_writel(nand, NDREDEL, 0x0);
+ info->ndtr0cs0 = ndtr0;
+ info->ndtr1cs0 = ndtr1;
+ if (show_timing)
+ show_real_timing(ndtr0, ndtr1, nand_clk);
}

static void pxa3xx_set_datasize(struct pxa3xx_nand_info *info)
@@ -1060,7 +1196,7 @@ static int pxa3xx_nand_waitfunc(struct mtd_info *mtd, struct nand_chip *this)
}

static void pxa3xx_nand_config_flash(struct pxa3xx_nand_info *info,
- const struct pxa3xx_nand_flash *f)
+ struct pxa3xx_nand_flash *f, int show_timing)
{
struct pxa3xx_nand *nand = info->nand_data; struct platform_device *pdev = nand->pdev;
@@ -1125,7 +1261,7 @@ static void pxa3xx_nand_config_flash(struct pxa3xx_nand_info *info,

info->reg_ndcr = ndcr;

- pxa3xx_nand_set_timing(info, &f->timing);
+ pxa3xx_nand_set_timing(info, &f->timing, show_timing);
}

/* the maximum possible buffer size for large page with OOB data
@@ -1227,7 +1363,7 @@ static int pxa3xx_nand_sensing(struct pxa3xx_nand *nand)
struct pxa3xx_nand_info *info = nand->info[nand->chip_select]; struct mtd_info *mtd = get_mtd_by_info(info);
/* use the common timing to make a try */
- pxa3xx_nand_config_flash(info, &builtin_flash_types[0]);
+ pxa3xx_nand_config_flash(info, &builtin_flash_types[0], 0);
pxa3xx_nand_cmdfunc(mtd, NAND_CMD_RESET, 0, 0);
if (nand->state & STATE_READY)
return 1;
@@ -1270,7 +1406,7 @@ static int pxa3xx_nand_scan(struct mtd_info *mtd)

/* find the chip in default list */
if (f->chip_id == id) {
- pxa3xx_nand_config_flash(info, f);
+ pxa3xx_nand_config_flash(info, f, 1);
chip->cellinfo = info->data_buff[2]; mtd->writesize = f->page_size; mtd->writesize_shift = ffs(mtd->writesize) - 1;
@@ -1556,6 +1692,7 @@ static int __devinit pxa3xx_nand_probe(struct platform_device *pdev)
return ret;

nand = platform_get_drvdata(pdev);
+ nand->RD_CNT_DEL = pdata->RD_CNT_DEL;
for (cs = 0; cs < NUM_CHIP_SELECT; cs++) {
info = nand->info[cs];
mtd = get_mtd_by_info(info);

Signature · 1 line
1.5.6.5