Skip to contentSkip to conversation

No subject

DISCUSSION [email protected] 1 participant 1 message Jan 23, 2009

lore
Share & tools
lore
#0 lore raw
Quoted 37 lines
Quoted 19 lines

Review COBJS-$(CONFIG_NS8382X) += ns8382x.o · line 58

Quoted 9 lines

COBJS-$(CONFIG_BFIN_MAC) += bfin_mac.o

(quoted diff) +0 -1
@@ -54,11 +55,11 @@ COBJS-$(CONFIG_NS8382X) += ns8382x.o
 COBJS-$(CONFIG_DRIVER_NS9750_ETHERNET) += ns9750_eth.o
 COBJS-$(CONFIG_PCNET) += pcnet.o
 COBJS-$(CONFIG_PLB2800_ETHER) += plb2800_eth.o
-COBJS-$(CONFIG_PPC4xx_EMAC) += 4xx_enet.o
 

that was ok here.

Review COBJS-$(CONFIG_NS8382X) += ns8382x.o · line 60

Quoted 2 lines
(quoted diff) +0 -0
 COBJS-$(CONFIG_DRIVER_RTL8019) += rtl8019.o
 

...while this isn't.

Quoted 18 lines

Review COBJS-$(CONFIG_ULI526X) += uli526x.o · line 72

Quoted 13 lines
(quoted diff) +1 -0
 COBJS-$(CONFIG_RTL8139) += rtl8139.o
 COBJS-$(CONFIG_RTL8169) += rtl8169.o
 COBJS-$(CONFIG_DRIVER_S3C4510_ETH) += s3c4510b_eth.o
+COBJS-$(CONFIG_SH_ETHER) += sh_eth.o
 COBJS-$(CONFIG_DRIVER_SMC91111) += smc91111.o

COBJS-$(CONFIG_DRIVER_SMC911X) += smc911x.o COBJS-$(CONFIG_TIGON3) += tigon3.o bcm570x_autoneg.o 5701rls.o

(quoted diff) +0 -1
@@ -68,7 +69,6 @@ COBJS-$(CONFIG_ULI526X) += uli526x.o
 COBJS-$(CONFIG_VSC7385_ENET) += vsc7385.o
 COBJS-$(CONFIG_XILINX_EMAC) += xilinx_emac.o
 COBJS-$(CONFIG_XILINX_EMACLITE) += xilinx_emaclite.o
-COBJS-$(CONFIG_SH_ETHER) += sh_eth.o
 

Actually we should perform a global s/CONFIG_DRIVER_/CONFIG_/, me thinks.

Quoted 1 line

Agreed. Can you do it Michal, or should I (for net, anyway)?

I would like to describe what happen. I sent to mailing list two patches. One with Makefile sort and second with LL_TEMAC. First patch just sort some labels in drivers/net/Makefile. Wolfgang sent that he don't like it and he reject this patch. I haven't wanted to sort any Makefile labels I just wanted to add LL_TEMAC driver. Makefile sort was not my point.
Then Ben add only Makefile sort patch (because of some small drivers violations) to net repo and send pull request to Wolfgang and he merged it to his repo.

My point was and is only add LL_TEMAC driver to u-boot not sorting labels in net repo.
BEN: Could you please add that driver to your repo? and if you can please sort labels to correct way.

Thanks,
Michal

Quoted 8 lines
Quoted 5 lines

Best regards,

Wolfgang Denk

regards,
Ben

Signature · 2 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854