Skip to contentSkip to conversation

The ending LBA is inclusive. Hence, the partition size should be ((ending-LBA + 1) - starting-LBA) to get the proper partition size.

PATCH New Richard Retanubun 1 participant 1 message Dec 12, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 The ending LBA is inclusive. Hence, the partition size should be ((ending-LBA + 1) - starting-LBA) to get the proper partition size.

This is confirmed against the results from the parted tool. (e.g. use parted /dev/sda -s unit S print) and observe the size.

---
Hi Wolfgang,

Apologies for the 'custodianship' assumption audacity :) Let me know if there is a more proper 'channel' for this and I'll stop bugging you.

 disk/part_efi.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
disk/part_efi.c +3 -1
index cc188ee..d8a8111 100644
@@ -163,7 +163,9 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, int part,
 
        /* The ulong casting limits the maximum disk size to 2 TB */
        info->start = (ulong) le64_to_int((*pgpt_pte)[part - 1].starting_lba);
-       info->size = (ulong) le64_to_int((*pgpt_pte)[part - 1].ending_lba) - info->start;
+       /* The ending LBA is inclusive, to calculate size, add 1 to it */
+       info->size = ((ulong)le64_to_int((*pgpt_pte)[part - 1].ending_lba) + 1)
+                    - info->start;
        info->blksz = GPT_BLOCK_SIZE;
 
        sprintf((char *)info->name, "%s%d\n", GPT_ENTRY_NAME, part);

--
1.5.6.5