led: enable led in 88pm860x
Subsystems (5)
PATCH 1/1 led: enable led in 88pm860x
Enable led sub device in Marvell 88PM860x. Two LED arrays can be supported. Each LED array can be used for R,G,B leds.
--- drivers/leds/Kconfig | 7 + drivers/leds/Makefile | 1 + drivers/leds/leds-88pm860x.c | 334 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 342 insertions(+), 0 deletions(-) create mode 100644 drivers/leds/leds-88pm860x.c
drivers/leds/Kconfig +7 -0
@@ -236,6 +236,13 @@ config LEDS_BD2802 This option enables support for BD2802GU RGB LED driver chips accessed via the I2C bus. +config LEDS_88PM860X + tristate "LED Support for Marvell 88PM860x PMIC" + depends on LEDS_CLASS && MFD_88PM860X + help + This option enables support for on-chip LED drivers found on Marvell + Semiconductor 88PM8606 PMIC. + comment "LED Triggers" config LEDS_TRIGGERS
drivers/leds/Makefile +1 -0
@@ -29,6 +29,7 @@ obj-$(CONFIG_LEDS_DA903X) += leds-da903x.o obj-$(CONFIG_LEDS_WM831X_STATUS) += leds-wm831x-status.o obj-$(CONFIG_LEDS_WM8350) += leds-wm8350.o obj-$(CONFIG_LEDS_PWM) += leds-pwm.o +obj-$(CONFIG_LEDS_88PM860X) += leds-88pm860x.o # LED SPI Drivers obj-$(CONFIG_LEDS_DAC124S085) += leds-dac124s085.o
drivers/leds/leds-88pm860x.c new file +334 -0
334 lines not on this page · raw message
Signature · 1 line
1.5.6.5
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
mode which doesn't work, and the MMU mode does.
Quoted 5 lines
However, in the (MM)I/O address
mapping for the 21285 driver, the footbridge code completely ignoresCONFIG_MMUand has all the I/O addresses #defined as if they were all virtual. This is obviously not going to work if the MMU is disabled and all the addresses will be wrong.
That's the situation with most platform support. NOMMU support hasn't had very much attention since it was merged, and certainly there is very little in the way of interest in running NOMMU on the existing platforms. I think you're the first to publically amit to contemplating this.
Quoted 4 lines
I've attached a patch (-p0) that adds an #ifdef to select between physical and virtual addresses for the 21285 chip, depending on
CONFIG_MMU. I do not have a real EBSA285 to test this on, but this board does have a real 21285 and it is working for me.
Most 21285-based systems are the same, so provided it works for one, it should work for all. However, I don't particularly like needlessly doubling up the _SIZE macros. Can we get around this by having another macro:
#ifdef CONFIG_MMU
#define MMU_IO(a,b) (a)
#else
#define MMU_IO(a,b) (b)
#endif
and then using this to define each _BASE macro?
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
the memory which the page tables live in, so we had to make the two match - and it's not possible to change the TTB flags and the page tables simultaneously, certainly not without turning the MMU off, doing the modification and turning it back on again.
Quoted 4 lines
We still have things like the SMP/nAMP mode which is Cortex-A9 and ARM11MPCore specific. There is also the TLB ops broadcasting bit in ACTLR which is also specific to ARM Ltd cores and some of these bits may not be accessible directly if you run in non-secure mode.
If you're running in non-secure mode and the parts of the system you don't have access to haven't already been setup, you're running in a crippled environment - so this isn't really an argument.
Quoted 10 lines
Quoted 4 lines
It strikes me that things are just becoming excessively complicated with these seemingly "catch-22" issues. Maybe a totally different approach is needed - such as requiring some of this low level setup to be done by the platform's boot loader?
Ideally, yes, it would be nice if these were done by the boot loader. We would have to define some clear requirements or at least saying that Linux only touches the architectured registers and not the implementation defined ones. But I'm not sure how feasible this would be.
Unless we do something like this, we're going to end up with lots of bits of additional platform specific non-conditional assembly in the early kernel boot path.
That stands in the way of having the kernel bootable on different platforms, supporting the device tree code, and makes debugging harder (the "why doesn't my kernel boot" problem.)
Quoted 3 lines
There is also the CPU hotplug case where CPUs come back via the setup function and may need to touch bits like SMP/nAMP. This should work together with a boot monitor.
How does the CPU get back to the setup function? Is the hardware aware of the address of our setup function? I don't think so, so I don't buy this argument.
If the CPU is reset (eg, because power has been removed), it's going to want to start executing from the reset vector - which means it will come back to us via the boot loader.
The only case where it may not is when the power has not been removed and we're doing something along the lines of the hotplug code in Realview, where we just put the "unplugged" CPUs into a wait-loop, but maintaining all of their context. When the CPU is "re-plugged" we manually jump back to the C entry point for secondary processors directly, resetting the stack as we go. We don't re-call the CPU specific initialization again.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
v7. The only problem areas I'd forsee are with Thumb-2 and DMA coherent memory.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
the bus clock, and use named clocks only for extra clocks it may need such as a codec clock for an audio device. I belive this is what Russell's initial complaint about the implementation is.
Signature · 4 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
function calls or static data being indirected through the GOT table, which means it has to be relocated along side the data segment - which makes the offset between the text and data segments fixed.
I would not believe that the "problems" have gone because the toolchain is working how it's supposed to.
The -Dstatic= stays.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
MC13783_REG_POWERMISC_PWGTSPI_M as I don't understand it's purpose without going through mc13783_reg_rmw_powermisc (which I didn't do yet).
What is the base for your patch? (Hm, it seems next could work. mc13783-regulator seems to have gotten some more #defines ending in _M. You seem to mean "mask". IMHO it's a bit unfortunate, because the nameing scheme doesn't match the already existing names :-()
Shouldn't mc13783_state_powermisc_pwgt be a per-device variable instead of a static variable?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
about 10 32-bit registers giving detailed information about various aspects of the CPU - including five 32-bit registers for details about the instruction set.
We know that some of the meanings of these registers has changed their meaning - and I don't think there's a way to identify which meaning should be applied to the registers (it seems to require reading lots of different documents to sort out what CPUs implement which method.)
Frankly, it's a mess, and when you look at implementations, it turns out to be unreliable.
Quoted 3 lines
On ARM, it would be great to have a simple set of features in
/proc/cpuinfoindicating which instruction sets are available (and reliable).
I think you've living in a dream world there.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
1. the VIC initialization
2. the sdhci drive strength
3. the presence of a second i2c port
4. the CLKDIV0_ARM_MASK
The rest of the non-board support code is identical in those two directories.
Quoted 3 lines
It does however mean that mach-s3c6400 and mach-s3c6410 are not heavily populated with machines, especially as the intended new Openmoko device never appeared.
Given the above, and the "mass population" hasn't happened, maybe part of the solution to the duplicated header file problem is to start combining some of these directories?
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
the arch/arm/mach-s5pc100/cpu.c file. The s5pc100-clock.c should be moved into arch/arm/mach-s5pc100/ as well.
Not sure yet what to do with the rest.
Signature · 4 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
platforms would make more sense.
I suspect that IRQF_VALID is something left behind from the times before CONFIG_GENERIC_HARDIRQS. My not-so-qualified guess is that IRQF_VALID was used to disallow request_irq() on irqs that lacked chip backing.
Today IRQ_NOREQUEST seems to be used for chained interrupt handlers. The check in request_threaded_irq() returns -EINVAL if IRQ_NOREQUEST is set. This covers request_irq(), but setup_irq() is lacking a check. Maybe this is done intentionally, or perhaps it's something I should fix?
If the purpose with IRQF_VALID is to guard against request_irq()/setup_irq() on irqs lacking chip backing, then good news is that the CONFIG_GENERIC_HARDIRQ already has code to handle this for us. Basically, the default in irq_desc_init makes use of &no_irq_chip. And the __setup_irq() code is already checking against irqs mapped to &no_irq_chip, those are disallowed with a -ENOSYS.
Is there any point in keeping IRQF_VALID on ARM, or shall I submit a patch to clean things up?
Thanks,
/ magnus
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
The mask and ID pattern for older ARM IDs in the kernel decompressor matches the CPU ID for Scorpion, causing the v7 caching routines not to be run and kernel decompression to take significantly longer.
This new mask from Russell should match only ARM v2/v3 CPU's.
--- arch/arm/boot/compressed/head.S | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/compressed/head.S +2 -2
@@ -628,8 +628,8 @@ proc_types: @ b __arm6_mmu_cache_off @ b __armv3_mmu_cache_flush - .word 0x00000000 @ old ARM ID - .word 0x0000f000 + .word 0x41000000 @ old ARM ID + .word 0xff00f000 mov pc, lr THUMB( nop ) mov pc, lr
Signature · 1 line
1.6.3.3
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
corner cases to be dealt with. I don't remember what they were off hand though.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
Building without CONFIG_CPU_IDLE or CONFIG_PM causes build to fail if cpu idle parameters are tried to pass using omap3_pm_init_cpuidle function.
--- arch/arm/mach-omap2/board-3430sdp.c | 20 +++++++ arch/arm/mach-omap2/cpuidle34xx.c | 105 ++++++++++++++++++++++++++++------- arch/arm/mach-omap2/pm.h | 15 +++++ 3 files changed, 119 insertions(+), 21 deletions(-)
arch/arm/mach-omap2/board-3430sdp.c +20 -0
@@ -46,6 +46,7 @@#include "mux.h" #include "sdram-qimonda-hyb18m512160af-6.h" #include "hsmmc.h" +#include "pm.h" #define CONFIG_DISABLE_HFCLK 1
@@ -57,6 +58,24 @@#define TWL4030_MSECURE_GPIO 22 +/* FIXME: These values need to be updated based on more profiling on 3430sdp*/ +static struct cpuidle_params omap3_cpuidle_params_table[] = { +/* C1 */ + {2 ,2 ,5 }, +/* C2 */ + {10 ,10 ,30 }, +/* C3 */ + {50 ,50 ,300 }, +/* C4 */ + {1500 ,1800 ,4000 }, +/* C5 */ + {2500 ,7500 ,12000 }, +/* C6 */ + {3000 ,8500 ,15000 }, +/* C7 */ + {10000 ,30000 ,300000 }, +}; +static int board_keymap[] = {KEY (0 ,0 ,KEY_LEFT ),KEY (0 ,1 ,KEY_RIGHT ),
@@ -307,6 +326,7 @@ static void __init omap_3430sdp_init_irq(void) { omap_board_config = sdp3430_config; omap_board_config_size =ARRAY_SIZE (sdp3430_config); +omap3_pm_init_cpuidle (omap3_cpuidle_params_table);omap2_init_common_hw (hyb18m512160af6_sdrc_params,NULL );omap_init_irq ();omap_gpio_init ();
arch/arm/mach-omap2/cpuidle34xx.c +84 -21
159 lines not on this page · raw message
arch/arm/mach-omap2/pm.h +15 -0
@@ -23,6 +23,21 @@ extern int omap3_can_sleep(void);extern int set_pwrdm_state (struct powerdomain *pwrdm,u32 state);extern int omap3_idle_init (void ); +struct cpuidle_params { +u32 sleep_latency; +u32 wake_latency; +u32 threshold; +}; + +#if defined(CONFIG_PM ) && defined(CONFIG_CPU_IDLE ) +extern void omap3_pm_init_cpuidle (struct cpuidle_params *cpuidle_board_params); +#else +static +inline void omap3_pm_init_cpuidle (struct cpuidle_params *cpuidle_board_params) +{ +} +#endif +extern int omap3_pm_get_suspend_state (struct powerdomain *pwrdm);extern int omap3_pm_set_suspend_state (struct powerdomain *pwrdm,int state);
Signature · 1 line
1.6.6
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
because of few dependencies. The auto-generated dma and irq headers are included as per comments.
The series is boot tested on omap4430 and omap4430 sdp's with multi-omap and regular defconfig builds.
The following changes since commit 80c20d543d142ee54ec85259b77aaf0b83c32db5= :
Tony Lindgren (1):
Merge branch 'omap-fixes-for-linus' into omap-for-linus
Santosh Shilimkar (9):
omap3/4: uart: fix full-fifo write abort omap2/3/4: ioremap omap_globals module
omap4: sdma: Enable the idle modes on omap4
omap: sdma: Limit the secure reserve channel fix for omap3
omap4: Fix omap_type() for omap4
omap3/4: Remove overlapping mapping of L4_WKUP io space
omap4: Add auto-generated irq and dma headers
omap4: Use dma line defines from dma-44xx.h
omap4: Use irq line defines from irq-44xx.h
arch/arm/mach-omap2/control.c | 6 +- arch/arm/mach-omap2/devices.c | 8 +- arch/arm/mach-omap2/id.c | 2 + arch/arm/mach-omap2/include/mach/irqs-44xx.h | 144 ++++++++++++++++++++++= +++ arch/arm/mach-omap2/include/mach/irqs.h | 1 + arch/arm/mach-omap2/io.c | 12 -- arch/arm/mach-omap2/prcm.c | 16 +++- arch/arm/mach-omap2/sdrc.c | 11 ++- arch/arm/mach-omap2/serial.c | 31 +++++- arch/arm/mach-omap2/timer-mpu.c | 2 +- arch/arm/plat-omap/common.c | 38 ++++---- arch/arm/plat-omap/devices.c | 4 +- arch/arm/plat-omap/dma.c | 7 +- arch/arm/plat-omap/dmtimer.c | 24 ++-- arch/arm/plat-omap/gpio.c | 12 +- arch/arm/plat-omap/include/plat/common.h | 17 ++-- arch/arm/plat-omap/include/plat/control.h | 3 + arch/arm/plat-omap/include/plat/dma-44xx.h | 145 ++++++++++++++++++++++= ++++ arch/arm/plat-omap/include/plat/dma.h | 86 +--------------- arch/arm/plat-omap/include/plat/io.h | 9 -- arch/arm/plat-omap/include/plat/irqs.h | 89 ---------------- arch/arm/plat-omap/io.c | 4 - 22 files changed, 411 insertions(+), 260 deletions(-) create mode 100644 arch/arm/mach-omap2/include/mach/irqs-44xx.h create mode 100644 arch/arm/plat-omap/include/plat/dma-44xx.h
Regards,
Santosh
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
<p class=3DMsoNormal = style=3D'text-indent:21.0pt;layout-grid-mode:char'><font size=3D4 face=3D"Times New Roman"><span lang=3DEN-US = style=3D'font-size:15.0pt'>Question:
How does hardware know which part of binary program in memory should = loaded
into Icache/Dcache?<o:p></o:p></span></font></p>
<p class=3DMsoNormal = style=3D'text-indent:21.0pt;layout-grid-mode:char'><font size=3D4 face=3D"Times New Roman"><span lang=3DEN-US = style=3D'font-size:15.0pt'><o:p> </o:p></span></font></p>
<p class=3DMsoNormal style=3D'layout-grid-mode:char'><font size=3D4 face=3D"Times New Roman"><span lang=3DEN-US = style=3D'font-size:15.0pt'>Rocky<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D1 face=3DArial><span lang=3DEN-US = style=3D'font-size:
9.0pt;font-family:Arial'><o:p> </o:p></span></font></p>
</div>
</body>
</html>
------=_NextPart_000_0004_01CAB6F5.3376D8F0--
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
this should rather be MACH_VEXPRESS_CA9X4. What is the reason for having ARCH_ here?
Otherwise, Tested-By: Albin Tonnerre <[email protected]>
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
on anything without V6K extensions. I think that the byte and word versions are supported on V6 and up though.
That'd make both __cmpxchg and __xchg slightly buggy, in different ways.
What it does mean is that atomic operations on unsigned shorts using ldrex/strex will only be possible on V6K and up.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
to continue with it.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
Sometimes you need to make an `asm' operand be a specific register, but there's no matching constraint letter for that register _by itself_. To force the operand into that register, use a local variable for the operand and specify the register in the variable declaration. *Note Explicit Reg Vars::. Then for the `asm' operand, use any register constraint letter that matches the register:
register int *p1 asm ("r0") = ...; register int *p2 asm ("r1") = ...; register int *result asm ("r0");
asm ("sysint" : "=r" (result) : "0" (p1), "r" (p2));
Fwiw, that note is present in GCC-4.0.1, but not GCC-3.3.6. But we've depended on that behaviour for a long time.
Note that we've depended on GCC not copying values with a dereferenced memory location for a long time too: E.g. "+m" (*ptr) is used a lot in spinlocks.
I'm sure I've read email confirmation (on these very lists) that GCC will always work with a memory constraint used in that way, without copying the value to/from a different location such as a stack slot.
But suprisingly, the GCC documentation says:
Extended asm supports input-output or read-write operands. Use the constraint character `+' to indicate such an operand and list it with the output operands. You should only use read-write operands when the constraints for the operand (or the operand in which only some of the bits are to be changed) allow a register.
^^^^^^^^^^^^^^^^
Maybe we're relying on undefined GCC behaviour for the "+m" constraint?
Quoted 9 lines
See the
__asmeq()macro in <asm/system.h> for a dirty hack which will check which registers are used and abort at compile time, although your compilation is going to fail anyway so I'm not sure it makes much of a difference in this particular case.The real fix here is to add an asm constraint to GCC which allows you to specify "any even GPR" (or whatever's most suitable for the ldrd instruction). Being able to give specific registers, like you can on other architectures, would be useful too.
See above GCC documentation for using register variables to designate specific registers. Many supported architectures don't have asm letter constraints for each register - hence so many of the old _syscallN macros in <asm/unistd.h> having to use register variables.
I am surprised GCC doesn't have a constraint for "any even register suitable for ldrd" on ARM, but I've just checked gcc-4.4.3 and it doesn't.
However, if I'm reading the source correctly, if not compiling for Thumb-1, and GCC believes the target machine supports ldrd, then all doubleword values are constrained to an even register pair anyway. That's why GCC itself does not need an even-register constraint letter.
...Which is I guess why it throws up only with OABI, or with pre-arm5e
archs: GCC doesn't consider OABI targets to support ldrd. (It's actually some more obscure condition, let's not go there).
Something else from the lovely GCC source:
mfix-cortex-m3-ldrd
Target Report Var(fix_cm3_ldrd) Init(2)
Avoid overlapping destination and address registers on LDRD instructions that may trigger Cortex-M3 errata.
In other words, the "=&" earlyclobber *is* needed on Cortex-M3.
Enjoy!
-- Jamie
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
second read was not ready. If this delay is adequate for the worst case propagate time it takes for the bits to change, it is not needed to read the register more than twice. I determined this experimentally by reading the register 3 times right after write and comparing the 2nd and 3rd read when doing different transfers between PC and ARM. As I have tested it only on 9261, somebody should either run the same kind of tests on other SoC's as well or figure out the worst case timings on all of them.
The datasheet describes that some changes are performed in 3 USB clock + 3 master clock periods. If so, then one/some extra reads could create the master-clock dependant small delay needed to be sure that everything is ready.
Actually, this leads to a another problem. We are able to read the rx fifo count when the bits are changing there. If some data is being received at the very moment when we read the register, we're in trouble. When some bits are old and some new, we can get values that are larger or smaller than the actual value (ie 0111->1000 change). This is a rare condition, but it might happen. Should this register be read always twice to check that nothing was unstable during the first read?
I would still leave in this extra read because it is known to be unstable. If it is needed on some SoC's, we could read out the register value until we get 2 same results to verify that it is stable. But there is no point of reading the first (known bad) value.
Signature · 5 lines
Anti Sullin Embedded Software Engineer Artec Design LLC Teaduspargi 6/2, 12618, Tallinn, Estonia http://www.artecdesign.ee
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
This patch introduces support for the tcc platform by creating an arch/arm/plat-tcc and arch/arm/mach-tcc8k directories and adding basic include files plus Kconfig and Makefile.
--- arch/arm/Kconfig | 11 + arch/arm/Makefile | 2 + arch/arm/mach-tcc8k/Kconfig | 5 + arch/arm/plat-tcc/Kconfig | 20 + arch/arm/plat-tcc/Makefile | 3 + arch/arm/plat-tcc/include/mach/debug-macro.S | 33 + arch/arm/plat-tcc/include/mach/entry-macro.S | 69 ++ arch/arm/plat-tcc/include/mach/hardware.h | 43 ++ arch/arm/plat-tcc/include/mach/memory.h | 29 + arch/arm/plat-tcc/include/mach/system.h | 31 + arch/arm/plat-tcc/include/mach/tcc8k-regs.h | 855 ++++++++++++++++++++++++++ arch/arm/plat-tcc/include/mach/uncompress.h | 32 + arch/arm/plat-tcc/include/mach/vmalloc.h | 11 + arch/arm/plat-tcc/system.c | 24 + 14 files changed, 1168 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-tcc8k/Kconfig create mode 100644 arch/arm/plat-tcc/Kconfig create mode 100644 arch/arm/plat-tcc/Makefile create mode 100644 arch/arm/plat-tcc/include/mach/debug-macro.S create mode 100644 arch/arm/plat-tcc/include/mach/entry-macro.S create mode 100644 arch/arm/plat-tcc/include/mach/hardware.h create mode 100644 arch/arm/plat-tcc/include/mach/memory.h create mode 100644 arch/arm/plat-tcc/include/mach/system.h create mode 100644 arch/arm/plat-tcc/include/mach/tcc8k-regs.h create mode 100644 arch/arm/plat-tcc/include/mach/uncompress.h create mode 100644 arch/arm/plat-tcc/include/mach/vmalloc.h create mode 100644 arch/arm/plat-tcc/system.c
arch/arm/Kconfig +11 -0
@@ -723,6 +723,15 @@ config ARCH_SHARK Support for the StrongARM based Digital DNARD machine, also known as "Shark" (<http://www.shark-linux.de/shark.html>). +config ARCH_TCC_926 + bool "Telechips TCC ARM926-based systems" + select CPU_ARM926T + select HAVE_CLK + select COMMON_CLKDEV + select GENERIC_CLOCKEVENTS + help + Support for Telechips TCC ARM926-based systems. + config ARCH_LH7A40X bool "Sharp LH7A40X" select CPU_ARM922T
@@ -887,6 +896,8 @@ source "arch/arm/plat-s3c24xx/Kconfig" source "arch/arm/plat-s5p/Kconfig" source "arch/arm/plat-s5pc1xx/Kconfig" +source "arch/arm/plat-tcc/Kconfig" + if ARCH_S3C2410 source "arch/arm/mach-s3c2400/Kconfig" source "arch/arm/mach-s3c2410/Kconfig"
arch/arm/Makefile +2 -0
@@ -172,6 +172,7 @@ machine-$(CONFIG_ARCH_SHARK) := shark machine-$(CONFIG_ARCH_SHMOBILE) := shmobile machine-$(CONFIG_ARCH_STMP378X) := stmp378x machine-$(CONFIG_ARCH_STMP37XX) := stmp37xx +machine-$(CONFIG_ARCH_TCC8K) := tcc8k machine-$(CONFIG_ARCH_U300) := u300 machine-$(CONFIG_ARCH_U8500) := ux500 machine-$(CONFIG_ARCH_VERSATILE) := versatile
@@ -192,6 +193,7 @@ plat-$(CONFIG_PLAT_PXA) := pxa plat-$(CONFIG_PLAT_S3C24XX) := s3c24xx samsung plat-$(CONFIG_PLAT_S5PC1XX) := s5pc1xx samsung plat-$(CONFIG_PLAT_S5P) := s5p samsung +plat-$(CONFIG_ARCH_TCC_926) := tcc ifeq ($(CONFIG_ARCH_EBSA110),y) # This is what happens if you forget the IOCS16 line.
arch/arm/mach-tcc8k/Kconfig new file +5 -0
@@ -0,0 +1,5 @@ +if ARCH_TCC8K + +comment "TCC8000 systems:" + +endif
arch/arm/plat-tcc/Kconfig new file +20 -0
@@ -0,0 +1,20 @@ +if ARCH_TCC_926 + +menu "Telechips ARM926-based CPUs" + +choice + prompt "Telechips CPU type:" + default ARCH_TCC8K + +config ARCH_TCC8K + bool TCC8000 + select USB_ARCH_HAS_OHCI + help + Support for Telechips TCC8000 systems + +endchoice + +source "arch/arm/mach-tcc8k/Kconfig" + +endmenu +endif
arch/arm/plat-tcc/Makefile new file +3 -0
@@ -0,0 +1,3 @@ +# "Telechips Platform Common Modules" + +obj-y := system.o
arch/arm/plat-tcc/include/mach/debug-macro.S new file +33 -0
@@ -0,0 +1,33 @@ +/* + * Copyright (C) 1994-1999 Russell King + * Copyright (C) 2008-2009 Telechips + * Copyright (C) 2009 Hans J. Koch <[email protected]> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + */ + + .macro addruart,rx,tmp + mrc p15, 0, \rx, c1, c0 + tst \rx, #1 @ MMU enabled? + moveq \rx, #0x90000000 @ physical base address + movne \rx, #0xF1000000 @ virtual base + orr \rx, \rx, #0x00007000 @ UART0 + .endm + + .macro senduart,rd,rx + strb \rd, [\rx, #0x44] + .endm + + .macro waituart,rd,rx + .endm + + .macro busyuart,rd,rx +1001: + ldr \rd, [\rx, #0x14] + tst \rd, #0x20 + + beq 1001b + .endm
arch/arm/plat-tcc/include/mach/entry-macro.S new file +69 -0
69 lines not on this page · raw message
arch/arm/plat-tcc/include/mach/hardware.h new file +43 -0
43 lines not on this page · raw message
arch/arm/plat-tcc/include/mach/memory.h new file +29 -0
@@ -0,0 +1,29 @@ +/* +* Based on: linux/include/asm-arm/arch-intergrator/memory.h +* Author: Greg Lonnon <[email protected]> +* Rewritten by: <[email protected]> +* Modified: June 10, 2008 +* Description: Memory map for TCC8300 +* +* Copyright (C) 1999 ARM Limited +* Copyright (C) 2000 RidgeRun, Inc. +* Copyright (C) 2008-2009 Telechips +* +* Licensed under the terms of the GPL v2. +*/ + +#ifndef __ASM_ARCH_MEMORY_H +#define __ASM_ARCH_MEMORY_H + +/* +* Physical DRAM offset. +*/ +#define PHYS_OFFSET UL(0x20000000) + +#define __virt_to_bus (x) __virt_to_phys(x) +#define __bus_to_virt (x) __phys_to_virt(x) +#define __pfn_to_bus (x) __pfn_to_phys(x) +#define __bus_to_pfn (x) __phys_to_pfn(x) + +#endif +
arch/arm/plat-tcc/include/mach/system.h new file +31 -0
@@ -0,0 +1,31 @@ +/* +* Author: <[email protected]> +* Created: June 10, 2008 +* Description: LINUX SYSTEM FUNCTIONS for TCC83x +* +* Copyright (C) 2008-2009 Telechips +* +* Licensed under the terms of the GPL v2. +* +*/ + +#ifndef __ASM_ARCH_SYSTEM_H +#define __ASM_ARCH_SYSTEM_H +#include <linux/clk.h> + +#include <asm/mach-types.h> +#include <mach/hardware.h> + +extern void plat_tcc_reboot (void ); + +static inline void arch_idle (void ) +{ +cpu_do_idle (); +} + +static inline void arch_reset (char mode,const char *cmd) +{ +plat_tcc_reboot (); +} + +#endif
arch/arm/plat-tcc/include/mach/tcc8k-regs.h new file +855 -0
855 lines not on this page · raw message
arch/arm/plat-tcc/include/mach/uncompress.h new file +32 -0
@@ -0,0 +1,32 @@ +/* +* Copyright (C) 2009 Hans J. Koch <[email protected]> +* +* This file is licensed under the terms of the GPL version 2. +*/ + +#include <linux/types.h> +#include <mach/tcc8k-regs.h> + +unsigned int system_rev; + +#define ID_MASK 0x7fff + +static void putc (int c) +{ +u32 *uart_lsr = (u32 *)(UART_BASE_PHYS +UART_LSR_OFFS ); +u32 *uart_thr = (u32 *)(UART_BASE_PHYS +UART_THR_OFFS ); + +while (!(*uart_lsr &UART_LSR_THRE )) +barrier (); + *uart_thr = c; +} + +static inline void flush (void ) +{ +} + +/* +* nothing to do +*/ +#define arch_decomp_setup () +#define arch_decomp_wdog ()
arch/arm/plat-tcc/include/mach/vmalloc.h new file +11 -0
@@ -0,0 +1,11 @@ +/* +* Author: <[email protected]> +* Created: June 10, 2008 +* +* Copyright (C) 2000 Russell King. +* Copyright (C) 2008-2009 Telechips +* +* Licensed under the terms of the GPL v2. +*/ +#define VMALLOC_END (PAGE_OFFSET + 0x10000000) +
arch/arm/plat-tcc/system.c new file +24 -0
@@ -0,0 +1,24 @@ +/* +* System functions for Telechips TCCxxxx SoCs +* +* Copyright (C) Hans J. Koch <[email protected]> +* +* Licensed under the terms of the GPL v2. +* +*/ + +#include <asm/io.h> +#include <mach/tcc8k-regs.h> + +/* System reboot */ +void plat_tcc_reboot (void ) +{ +/* Make sure clocks are on */ +__raw_writel (0xffffffff ,CKC_BASE +BCLKCTR0_OFFS ); + +/* Enable watchdog reset */ +__raw_writel (0x49 ,TIMER_BASE +TWDCFG_OFFS ); +/* Wait for reset */ +unreachable (); +} +
Signature · 1 line
1.6.3.3
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
Add the clock framework for Telechips TCC8xxx processors.
--- arch/arm/mach-tcc8k/Makefile | 6 + arch/arm/mach-tcc8k/clock.c | 589 +++++++++++++++++++++++++++++++ arch/arm/plat-tcc/Makefile | 2 +- arch/arm/plat-tcc/clock.c | 170 +++++++++ arch/arm/plat-tcc/include/mach/clkdev.h | 7 + arch/arm/plat-tcc/include/mach/clock.h | 48 +++ 6 files changed, 821 insertions(+), 1 deletions(-) create mode 100644 arch/arm/mach-tcc8k/Makefile create mode 100644 arch/arm/mach-tcc8k/clock.c create mode 100644 arch/arm/plat-tcc/clock.c create mode 100644 arch/arm/plat-tcc/include/mach/clkdev.h create mode 100644 arch/arm/plat-tcc/include/mach/clock.h
arch/arm/mach-tcc8k/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# +# Makefile for TCC8K boards and common files. +# + +# Common support +obj-y += clock.o
arch/arm/mach-tcc8k/clock.c new file +589 -0
589 lines not on this page · raw message
arch/arm/plat-tcc/Makefile +1 -1
@@ -1,3 +1,3 @@ # "Telechips Platform Common Modules" -obj-y := system.o +obj-y := clock.o system.o
arch/arm/plat-tcc/clock.c new file +170 -0
170 lines not on this page · raw message
arch/arm/plat-tcc/include/mach/clkdev.h new file +7 -0
@@ -0,0 +1,7 @@ +#ifndef __ASM_MACH_CLKDEV_H +#define __ASM_MACH_CLKDEV_H + +#define __clk_get (clk) ({ 1; }) +#define __clk_put (clk) do { } while (0) + +#endif
arch/arm/plat-tcc/include/mach/clock.h new file +48 -0
48 lines not on this page · raw message
Signature · 1 line
1.6.3.3
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
Introduce lowlevel interrupt routines.
--- arch/arm/mach-tcc8k/Makefile | 3 +- arch/arm/mach-tcc8k/irq.c | 113 +++++++++++++++++++++++++++++++++ arch/arm/plat-tcc/include/mach/irqs.h | 84 ++++++++++++++++++++++++ 3 files changed, 199 insertions(+), 1 deletions(-) create mode 100644 arch/arm/mach-tcc8k/irq.c create mode 100644 arch/arm/plat-tcc/include/mach/irqs.h
arch/arm/mach-tcc8k/Makefile +2 -1
@@ -3,4 +3,5 @@ # # Common support -obj-y += clock.o +obj-y += clock.o irq.o +
arch/arm/mach-tcc8k/irq.c new file +113 -0
113 lines not on this page · raw message
arch/arm/plat-tcc/include/mach/irqs.h new file +84 -0
84 lines not on this page · raw message
Signature · 1 line
1.6.3.3
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
Add the system timer using clockevents with the internal TC32 timer. This also adds a clocksource using the same timer.
--- arch/arm/Kconfig | 1 + arch/arm/mach-tcc8k/Makefile | 2 +- arch/arm/mach-tcc8k/time.c | 150 ++++++++++++++++++++++++++++++++ arch/arm/plat-tcc/include/mach/timex.h | 5 + 4 files changed, 157 insertions(+), 1 deletions(-) create mode 100644 arch/arm/mach-tcc8k/time.c create mode 100644 arch/arm/plat-tcc/include/mach/timex.h
arch/arm/Kconfig +1 -0
@@ -728,6 +728,7 @@ config ARCH_TCC_926 select CPU_ARM926T select HAVE_CLK select COMMON_CLKDEV + select GENERIC_TIME select GENERIC_CLOCKEVENTS help Support for Telechips TCC ARM926-based systems.
arch/arm/mach-tcc8k/Makefile +1 -1
@@ -3,5 +3,5 @@ # # Common support -obj-y += clock.o irq.o +obj-y += clock.o irq.o time.o
arch/arm/mach-tcc8k/time.c new file +150 -0
150 lines not on this page · raw message
arch/arm/plat-tcc/include/mach/timex.h new file +5 -0
@@ -0,0 +1,5 @@ +/* +* A definition needed by arch core code. +* +*/ +#define CLOCK_TICK_RATE (HZ * 100000UL)
Signature · 1 line
1.6.3.3
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
Map the IO ranges of TCC8xxx peripherals.
--- arch/arm/mach-tcc8k/Makefile | 2 +- arch/arm/mach-tcc8k/io.c | 68 +++++++++++++++++++++++++++++++++++ arch/arm/plat-tcc/include/mach/io.h | 53 +++++++++++++++++++++++++++ 3 files changed, 122 insertions(+), 1 deletions(-) create mode 100644 arch/arm/mach-tcc8k/io.c create mode 100644 arch/arm/plat-tcc/include/mach/io.h
arch/arm/mach-tcc8k/Makefile +1 -1
@@ -3,5 +3,5 @@ # # Common support -obj-y += clock.o irq.o time.o +obj-y += clock.o irq.o time.o io.o
arch/arm/mach-tcc8k/io.c new file +68 -0
25 lines not on this page · raw message
arch/arm/plat-tcc/include/mach/io.h new file +53 -0
53 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
1.6.3.3
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
This patch introduces a first set of platform devices for integrated peripherals of TCC8xxx processors. Drivers for these devices are available and will be posted in a second step.
--- arch/arm/mach-tcc8k/Makefile | 2 +- arch/arm/mach-tcc8k/devices.c | 274 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 275 insertions(+), 1 deletions(-) create mode 100644 arch/arm/mach-tcc8k/devices.c
arch/arm/mach-tcc8k/devices.c new file +274 -0
274 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
1.6.3.3
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
Add support for the Telechips TCC8000-SDK development board.
--- arch/arm/mach-tcc8k/Kconfig | 6 +++ arch/arm/mach-tcc8k/Makefile | 3 ++ arch/arm/mach-tcc8k/Makefile.boot | 3 ++ arch/arm/mach-tcc8k/board-tcc8000-sdk.c | 59 +++++++++++++++++++++++++++++++ arch/arm/mach-tcc8k/board-tcc8000-sdk.h | 18 +++++++++ 5 files changed, 89 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-tcc8k/Makefile.boot create mode 100644 arch/arm/mach-tcc8k/board-tcc8000-sdk.c create mode 100644 arch/arm/mach-tcc8k/board-tcc8000-sdk.h
arch/arm/mach-tcc8k/Makefile.boot new file +3 -0
Lines of this file are not shown. View the raw message.
arch/arm/mach-tcc8k/board-tcc8000-sdk.c new file +59 -0
59 lines not on this page · raw message
arch/arm/mach-tcc8k/board-tcc8000-sdk.h new file +18 -0
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 1 line
1.6.3.3
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
need something like this is the AMBA PL011 UART driver, RX part, where data comes in from the outside and we have no control over the data flow. I trigger one transfer to a buffer here, then wait for it to complete or be interrupted. If it completes, I immediately trigger another transfer to the second buffer before I start processing the just recieved buffer (like front/back buffers).
I just hope that this will always be fast enough, queueing two transfers after each other at the same time first would perhaps be better if the hardware can handle it, now we have no hardware that can actually queue that up so we can work it over the day we see something like that...
(I don't know if I'm making myself clear, the PL011 patch may speak for itself rather.)
Quoted 1 line
o =A0TODO: PAUSE/RESUME support. Currently the DMA API driver has to emul=
ate it.
The only PrimeCell that needs this is currently again the PL011. It needs to PAUSE then get the number of pending bytes and then terminate the transfer. This is done when we timeout transfers e.g. for UART consoles. So being able to pause and retrieve the number of bytes left and then cancel is the most advanced sequence that will be used by a PrimeCell currently.
I've seen sample PCM/I2S drivers that wants PAUSE/RESUME though.
(...)
Quoted 7 lines
Basic PL330 engine driver
Signed-off-by Jassi Brar <[email protected]>---
=A0arch/arm/common/Kconfig =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A03 + =A0arch/arm/common/Makefile =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A01 + =A0arch/arm/common/pl330.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 | 1891 +++++++++++=
++++++++++++++++++++++
Quoted 4 lines
=A0arch/arm/include/asm/hardware/pl330.h | =A0197 ++++ =A04 files changed, 2092 insertions(+), 0 deletions(-) =A0create mode 100644
arch/arm/common/pl330.c=A0create mode 100644arch/arm/include/asm/hardware/pl330.h
Contemplate moving all but the header file to drivers/dma (not that I have any strong feelings about it, just feels right).
(...)
Review
Quoted 118 lines
(quoted diff) +118
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
NTEG_CFG << 24))
Review
Quoted 6 lines
(quoted diff) +6
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
1 << 2)
Review
Quoted 3 lines
(quoted diff) +3
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
1 << 5) /* TOUT for exit? */
Review
Quoted 5 lines
(quoted diff) +5
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
xit? */
Quoted 1 line
+#define
PL330_STATE_QUEUEBUSY=A0 =A0 =A0 =A0 =A0(1 << 11) /* TOUT for e=
xit? */
Quoted 1 line
+#define
PL330_STATE_INVALID=A0 =A0 =A0 =A0 =A0 =A0(1 << 15) /* To catch=
error */
Review
Quoted 2 lines
(quoted diff) +2
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
\
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | PL330_STA=
TE_WFE | PL330_STATE_FAULTING)
Review
Quoted 52 lines
(quoted diff) +52
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
I like multiline comments like this, notice blank first line:
/*
* Foo
*/
(Yeah I know it's picky. Applies to entire file.)
Review
Quoted 5 lines
(quoted diff) +5
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
)->mc_bus + sz)))
Review
Quoted 31 lines
(quoted diff) +31
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
*/
Review
Quoted 8 lines
+ =A0 =A0 =A0 struct
list_headrqd;(quoted diff) +7
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Contemplate using bool for these two members.
Quoted 2 lines
+ =A0 =A0 =A0 /* which thread needs to be reset */
+ =A0 =A0 =A0 unsigned reset_chan:8;
Why not use:
u8 reset_chan;
Review
Quoted 8 lines
(quoted diff) +8
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
/
Review
Quoted 27 lines
+ =A0 =A0 =A0 unsigned active;
+ =A0 =A0 =A0 struct mutex mtx;
+ =A0 =A0 =A0 /* Only two at a time */
+ =A0 =A0 =A0 struct_pl330_reqreq[2];
+ =A0 =A0 =A0 /* parent DMAC */
+ =A0 =A0 =A0 structpl330_dmac*dmac;(quoted diff) +21
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
annels */
Quoted 2 lines
+ =A0 =A0 =A0 u32 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
mcode_bus;
+ =A0 =A0 =A0 /* CPU address of buffer allocated for MicroCode for all Ch=
annels*/
Review
Quoted 46 lines
+ =A0 =A0 =A0 void =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*mcode_cpu;
+ =A0 =A0 =A0 structpl330_thread=A0 =A0 *channels;
+ =A0 =A0 =A0 /* MANAGER thread is _always_ the last one */
+ =A0 =A0 =A0 structpl330_thread=A0 =A0 *manager;
+ =A0 =A0 =A0 structtasklet_struct=A0 tasks;
+ =A0 =A0 =A0 enumpl330_dmac_state=A0 state;(quoted diff) +40
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
se;
Review
Quoted 53 lines
(quoted diff) +53
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
ond)
Review
Quoted 143 lines
(quoted diff) +143
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
ond)
Review
Quoted 118 lines
(quoted diff) +118
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
With all these emit_* functions you have half a microcode compiler in the driver, but I really, really like it! It's the right foundation for hackers that want
to have fun with the microcode generation later on.
Review
Quoted 10 lines
(quoted diff) +10
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
*/
Review
Quoted 55 lines
+ =A0 =A0 =A0 }
+ =A0 =A0 =A0writel(val, regs + DBGINST0);(quoted diff) +53
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
R;
Quoted 5 lines
+ =A0 =A0 =A0 case
DS_ST_QBUSY:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (is_manager(thrd))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 returnPL330_STATE_INVALID;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return PL330_STATE_QUEUEBUS=
Y;
Quoted 7 lines
+ =A0 =A0 =A0 case
DS_ST_WFP:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (is_manager(thrd))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 returnPL330_STATE_INVALID;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 returnPL330_STATE_WFP;
+ =A0 =A0 =A0 caseDS_ST_KILL:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (is_manager(thrd))
Quoted 8 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return
PL330_STATE_INVALID;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 returnPL330_STATE_KILLING;
+ =A0 =A0 =A0 caseDS_ST_CMPLT:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (is_manager(thrd))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 returnPL330_STATE_INVALID;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return PL330_STATE_COMPLETI=
NG;
Quoted 5 lines
+ =A0 =A0 =A0 case
DS_ST_FLTCMP:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (is_manager(thrd))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 returnPL330_STATE_INVALID;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return PL330_STATE_FAULT_CO=
MPLETING;
Review
Quoted 16 lines
+ =A0 =A0 =A0 default:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 returnPL330_STATE_INVALID;
+ =A0 =A0 =A0 }(quoted diff) +13
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
bool
Review
Quoted 16 lines
+ =A0 =A0 =A0 u8 insn[6] =3D {0, 0, 0, 0, 0, 0};
(quoted diff) +15
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Since you defined nonsecure as :1 you could just assign it. But please make both ns and cfg->nonsecure bool.
Quoted 8 lines
+ =A0 =A0 =A0 else if (
readl(regs + CS(thrd->id))&CS_CNS)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 ns =3D 1;
+ =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 ns =3D 0;
+
+ =A0 =A0 =A0 /* See 'Abort Sources' point-4 at Page 2-25 */
+ =A0 =A0 =A0 if (_manager_ns(thrd)&& !ns)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_INFO "%s:%d Recipe for ABORT!\n=
",
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
__func__,__LINE__);
dev_info(thrd->dmac->dev, "....");
Review
Quoted 8 lines
(quoted diff) +8
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
;
Review
Quoted 29 lines
(quoted diff) +29
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
ATE_KILLING);
Quoted 2 lines
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (_state(thrd)=3D=3D PL330_STATE_KILLING=
)
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 UNTIL(thrd, PL330_STATE_STO=
PPED)
Review
Quoted 10 lines
(quoted diff) +10
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
1);
Review
Quoted 11 lines
(quoted diff) +11
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
*/
Review
Quoted 23 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return false;
+ =A0 =A0 =A0 }(quoted diff) +21
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
);
Quoted 1 line
+ =A0 =A0 =A0 ccr |=3D (((
rqc->brst_len- 1) &0xf) << CC_DSTBRSTLEN_SHFT=
);
Review
Quoted 22 lines
(quoted diff) +22
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
| scctl =3D=3D SINVALID2)
Review
Quoted 12 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return false;
+ =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return true;(quoted diff) +9
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
REVISIT XXX */
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_LD(dry_run, &buf[off], ALWAY=
S);
Quoted 2 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D
_emit_RMB(dry_run, &buf[off]);
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_ST(dry_run, &buf[off], ALWAY=
S);
Review
Quoted 13 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D
_emit_WMB(dry_run, &buf[off]);
+ =A0 =A0 =A0 }(quoted diff) +11
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
XXX */
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_WFP(dry_run, &buf[off], SING=
LE, pxs->r->peri);
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_LDP(dry_run, &buf[off], SING=
LE, pxs->r->peri);
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_ST(dry_run, &buf[off], ALWAY=
S);
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Do we need FLUSHP for every cycle? REVIS=
IT XXX */
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_FLUSHP(dry_run, &buf[off], p=
xs->r->peri);
Review
Quoted 12 lines
+ =A0 =A0 =A0 }
(quoted diff) +11
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
XXX */
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_WFP(dry_run, &buf[off], SING=
LE, pxs->r->peri);
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_LD(dry_run, &buf[off], ALWAY=
S);
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_STP(dry_run, &buf[off], SING=
LE, pxs->r->peri);
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Do we need FLUSHP for every cycle? REVIS=
IT XXX */
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _emit_FLUSHP(dry_run, &buf[off], p=
xs->r->peri);
Review
Quoted 13 lines
+ =A0 =A0 =A0 }
(quoted diff) +12
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
pxs, cyc);
Quoted 4 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
+
+ =A0 =A0 =A0 case DEVTOMEM:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _ldst_devtomem(dry_run, &buf[off],=
pxs, cyc);
Quoted 4 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
+
+ =A0 =A0 =A0 case MEMTOMEM:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _ldst_memtomem(dry_run, &buf[off],=
pxs, cyc);
Quoted 4 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
+
+ =A0 =A0 =A0 default:
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D0x40000000; /* Scare off the Clien=
t */
Review
Quoted 9 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
+ =A0 =A0 =A0 }(quoted diff) +7
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
pec *pxs)
Review
Quoted 35 lines
(quoted diff) +35
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Which means? Hackers like to mess with stuff... Note to self? Usually comments like that is a trace of questionable design so if the design is solid, remove the comments because then it will be obvious that you don't want to mess with the construct.
Review
Quoted 14 lines
(quoted diff) +14
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
nt0);
Review
Quoted 18 lines
(quoted diff) +18
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
pend);
Review
Quoted 21 lines
+ =A0 =A0 =A0 }
+ =A0 =A0 =A0 /***********************************/(quoted diff) +19
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
;
Review
Quoted 41 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 bursts -=3D c;
+ =A0 =A0 =A0 }(quoted diff) +39
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
urst size */
Quoted 5 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (
x->bytes%BRST_SIZE(pxs->ccr))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return-EINVAL; +
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0pxs->x=3D x;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 off +=3D _setup_xfer(dry_run, &buf[off], px=
s);
Review
Quoted 31 lines
(quoted diff) +31
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
YING)
Review
Quoted 59 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return
-EINVAL;(quoted diff) +58
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
For all exported symbols: I have a hard time seeing anyone compiling the DMA engine driver or anything else using this as a module and making use of all these exports. But maybe for testing, what do I know...
Review
Quoted 13 lines
(quoted diff) +13
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
];
Quoted 2 lines
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* Mark thread as infected =
*/
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
pl330->dmac_tbd.reset_chan=
|=3D (1 << thrd->id);
Review
Quoted 12 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
(quoted diff) +11
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
->id)) {
Quoted 2 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (
thrd->active) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct pl33=
0_req *r1, *r2;
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 enum pl330_=
op_err err;
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 void __iome=
m *regs =3D pi->base;
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned ac=
tive;
Quoted 2 lines
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 active =3D =
thrd->active - 1;
Quoted 2 lines
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 r1 =3D thrd=
->req[active].r;
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 r2 =3D thrd=
->req[1 - active].r;
Quoted 2 lines
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 thrd->req[a=
ctive].r =3D NULL;
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 thrd->req[1=
- active].r =3D NULL;
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 thrd->activ=
e =3D 0;
Quoted 2 lines
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (readl(r=
egs + FSC) & (1 << thrd->id))
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
=A0 err =3D PL330_ERR_FAIL;
Quoted 2 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
=A0 err =3D PL330_ERR_ABORT;
Quoted 2 lines
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _callback(r=
1, err);
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _callback(r=
2, err);
Review
Quoted 42 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
(quoted diff) +41
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
um_events) - 1)) {
Quoted 2 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0
pl330->dmac_tbd.reset_dmac=3D 1;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_INFO "%s:%d Unexpected!\n", __f=
unc__, __LINE__);
dev_info(pl330->dev, "...");
Review
Quoted 17 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 ret =3D 1;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 gotoupdt_exit;
+ =A0 =A0 =A0 }(quoted diff) +14
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
d];
Review
Quoted 5 lines
(quoted diff) +5
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
_tbd.reset_chan |=3D (1 << id);
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN=
_INFO "%s:%d Unexpected!\n",
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
=A0 __func__, __LINE__);
dev_info(pl330->dev, "....");
Quoted 3 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 active =3Dthrd->active- 1=
;
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 rqdone =3D &thrd->req[activ=
e];
Quoted 3 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
rqdone->r=3D NULL; +
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (thrd->req[1 - active].r=
)
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 thrd->activ=
e =3D 2 - active;
Quoted 2 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 else
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 thrd->activ=
e =3D 0;
Review
Quoted 5 lines
(quoted diff) +5
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
t of callbacks to be done */
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 list_add_tail(&rqdone->rqd,=
&pl330->req_done);
Review
Quoted 14 lines
(quoted diff) +14
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
f(pl330->req_done.next,
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
=A0 struct _pl330_req, rqd);
Review
Quoted 10 lines
(quoted diff) +10
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
gr
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 || pl330->dmac_tbd.reset_ch=
an) {
Review
Quoted 103 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 ret =3D 1;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0tasklet_schedule(&pl330->tasks);
+ =A0 =A0 =A0 }(quoted diff) +100
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
",
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
__func__,__LINE__);
dev_err(pl330->dev, "....");
Notice err! Not info.
Review
Quoted 27 lines
(quoted diff) +27
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
* pi->mcbufsz);
Quoted 2 lines
+ =A0 =A0 =A0 thrd->req[0].mc_bus =3D
pl330->mcode_bus
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 + (thrd->id=
* pi->mcbufsz);
Quoted 4 lines
+
+ =A0 =A0 =A0 thrd->req[1].r =3D NULL;
+ =A0 =A0 =A0 thrd->req[1].mc_cpu =3D thrd->req[0].mc_cpu
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 + pi->mcbuf=
sz / 2;
Quoted 2 lines
+ =A0 =A0 =A0 thrd->req[1].mc_bus =3D thrd->req[0].mc_bus
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 + pi->mcbuf=
sz / 2;
Review
Quoted 28 lines
(quoted diff) +12
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
id;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return ev;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+ =A0 =A0 =A0 }(quoted diff) +12
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
thrd->id)
Review
Quoted 26 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 pl330->events[ev] =3D -1;
(quoted diff) +25
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
];
Quoted 2 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
_reset_thread(thrd);
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0thrd->ev=3D _alloc_event(t=
hrd);
Quoted 2 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (
thrd->ev>=3D 0) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0thrd->free=
=3D false;
Review
Quoted 59 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 thrd =3D NULL;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
+ =A0 =A0 =A0 }(quoted diff) +54
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
=A0 GFP_KERNEL);
Review
Quoted 52 lines
+ =A0 =A0 =A0 if (!pl330->channels)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return-ENOMEM;(quoted diff) +50
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
PERCHAN)
Quoted 5 lines
+ =A0 =A0 =A0 =A0*/
+ =A0 =A0 =A0pl330->mcode_cpu=3D dma_alloc_coherent(pl330->dev,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 chans * pi-= mcbufsz,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 &pl330->mco=
de_bus, GFP_KERNEL);
Quoted 2 lines
+ =A0 =A0 =A0 if (!pl330->mcode_cpu) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_INFO "Unable to allocate MCODE =
buffer\n");
dev_err(pl330->dev, "....");
ERR!
Quoted 6 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return
-ENOMEM;
+ =A0 =A0 =A0 }
+
+ =A0 =A0 =A0 ret =3Ddmac_alloc_threads(pl330);
+ =A0 =A0 =A0 if (ret) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 printk(KERN_INFO "Unable to create channels=
for DMAC\n");
dev_err(pl330->dev, "....");
ERR!
Quoted 4 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 dma_free_coherent(pl330->dev,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 chans * pi-= mcbufsz,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 pl330->mcod=
e_cpu, pl330->mcode_bus);
Review
Quoted 15 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return ret;
+ =A0 =A0 =A0 }(quoted diff) +13
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
e_cpu, pl330->mcode_bus);
Review
Quoted 22 lines
(quoted diff) +22
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
_NUM_PERIPH_MASK;
Review
Quoted 50 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 val +=3D 1;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0pi->pcfg.num_peri=3D val;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0pi->pcfg.peri_ns=3D readl(regs + CR4);
+ =A0 =A0 =A0 } else {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0pi->pcfg.num_peri=3D 0;
+ =A0 =A0 =A0 }(quoted diff) +44
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
0x%x !\n",
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
readl(regs + PERIPH_ID), re=
adl(regs + PCELL_ID));
dev_info(pl330->dev, ...)
Quoted 2 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return
-EINVAL;
+ =A0 =A0 =A0 }
If the parent device (IMO a DMAdevices/DMAengine) is an struct amba_device I don't think this ID check is necessary, there is already PrimeCell matching code in
<linux/amba/bus.h>
Quoted 4 lines
+
+ =A0 =A0 =A0 /* Make sure it isn't already added */
+ =A0 =A0 =A0list_for_each_entry(pt, &pl330_list, node)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (pt =3D=3D pl330)
Perhaps print some warning here. Doesn't seem sound that this would happen.
Review
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return 0;
(quoted diff) +6
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
events!\n",
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
__func__,__LINE__);
dev_info(pl330->dev, "....");
Review
Quoted 15 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return
-EINVAL;
+ =A0 =A0 =A0 }(quoted diff) +13
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
for DMAC\n");
dev_info(pl330->dev, "....");
Review
Quoted 9 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 return i;
+ =A0 =A0 =A0 }(quoted diff) +7
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
ong) pl330);
arch/arm/include/asm/hardware/pl330.h
Quoted 106 lines
(quoted diff) +71
-0Lines of this file are not shown. View the raw message.
arch/arm/include/asm/hardware/pl330.h new file +28
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
/
arch/arm/include/asm/hardware/pl330.h
Quoted 3 lines
arch/arm/include/asm/hardware/pl330.h new file +3
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
*/
arch/arm/include/asm/hardware/pl330.h
Quoted 8 lines
arch/arm/include/asm/hardware/pl330.h new file +8
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
/
arch/arm/include/asm/hardware/pl330.h
Quoted 3 lines
arch/arm/include/asm/hardware/pl330.h new file +3
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
y */
arch/arm/include/asm/hardware/pl330.h
Quoted 1 line
arch/arm/include/asm/hardware/pl330.h new file +1
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
/
arch/arm/include/asm/hardware/pl330.h
Quoted 9 lines
arch/arm/include/asm/hardware/pl330.h new file +9
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
*/
arch/arm/include/asm/hardware/pl330.h
Quoted 9 lines
arch/arm/include/asm/hardware/pl330.h new file +9
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Contemplate adding:
/* Owning device */
struct device *dev;arch/arm/include/asm/hardware/pl330.h
Quoted 47 lines
arch/arm/include/asm/hardware/pl330.h new file +47
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
For all of these things using just one bit, contemplate turning them into bool instead, because that's what they are.
arch/arm/include/asm/hardware/pl330.h
Quoted 84 lines
arch/arm/include/asm/hardware/pl330.h new file +84
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
us);
arch/arm/include/asm/hardware/pl330.h
Quoted 3 lines
arch/arm/include/asm/hardware/pl330.h new file +3
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Do you really need both pairs:
pl330_alloc() + pl330_add() andpl330_del() + pl330_free()
to be public and exposed in the interface and exported? I would suggest mak= ing
removing two of them unless there is something I don't get here. IMO:
int pl330_add(struct device *, struct pl330_info *);
Should be enough, pl330_info will be filled in if the call returns sucessfu= lly.
You could also
struct pl330_info *pl330_add(struct device *);
If you prefer to use macros like IS_ERR() etc on the returned pointer.
Quoted 4 lines
arch/arm/include/asm/hardware/pl330.h new file +1
-1Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
1.6.2.5
Yours,
Linus Walleij
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
support DMA as well (via two M2M channels). Maybe we can add support for that in subsequent versions?
Thanks,
MW
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
Are you trying to 'git pull' his tree?
I tried that initially and it worked fine for the initial pull. After that=
I
always ran into issues with trying to update it.
I don't quite remember how I did the initial pull when I started a new bran= ch
to follow Russell's tree but I think I did it like the FAQ says on how to follow the -next tree.
Oh, this is using git version 1.7.0.3.254.g4503b
Regards,
Hartley=
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
/*
* Table that determines the low power modes outputs, with actual settings
* used in parentheses for don't-care values. Except for the float output,
* the configured driven and pulled levels match, so if there is a need for
* non-LPM pulled output, the same configuration could probably be used. *
* Output value sleep_oe_n sleep_data pullup_en pulldown_en pull_sel * (bit 7) (bit 8) (bit 14) (bit 13) (bit 15) * * Input 0 X(0) X(0) X(0) 0 * Drive 0 0 0 0 X(1) 0 * Drive 1 0 1 X(1) 0 0 * Pull hi (1) 1 X(1) 1 0 0 * Pull lo (0) 1 X(0) 0 1 0 * Z (float) 1 X(0) 0 0 0 */ #define MFPR_LPM_INPUT (0) #define MFPR_LPM_DRIVE_LOW (MFPR_SLEEP_DATA(0) | MFPR_PULLDOWN_EN) #define MFPR_LPM_DRIVE_HIGH (MFPR_SLEEP_DATA(1) | MFPR_PULLUP_EN) #define MFPR_LPM_PULL_LOW (MFPR_LPM_DRIVE_LOW | MFPR_SLEEP_OE_N) #define MFPR_LPM_PULL_HIGH (MFPR_LPM_DRIVE_HIGH | MFPR_SLEEP_OE_N) #define MFPR_LPM_FLOAT (MFPR_SLEEP_OE_N) #define MFPR_LPM_MASK (0xe080)
When a pin's LPM is configured as MFPR_LPM_INPUT, the MFPR will, upon entry to any low power mode, contain all zeros in the bits listed above. If my understanding is correct, this will cause such pins to drive low in any low power mode. That's not always a good thing for an input pin to do. This definition is misleading and should probably be removed.
The default MFP configuration includes MFP_LPM_DEFAULT, which (via mfpr_lpm[]) selects MFPR_LPM_INPUT. Is this really a desired "default"? I think MFPR_LPM_DRIVE_LOW is a safer bet, in case the pin is externally driven high.
-Dave
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
able
will increment in the same way at least in the current configuration.
If you have case where individual CPUs are running at different speed and d= ifferent
Tick rate then only this can make difference.
Regards,
Santosh
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
if (bits > 8) {
this16
} else {
that8
}
so no loss in splitting it. You need two copies of the read and write loops in the read_write routine, though it's only 8 extra lines of code for a 1% CPU increase.
I don't have strong feelings about this it way.
Quoted 2 lines
Yes. Too bad we can't also combine multiple messages that might be in
the queue...
I wonder if it might be easier, if there are several parts to a message, to just cook up one big new transfer, copy the data into it and just do that. It would mean copying every data block of course since in the MMC/SD case they are 512+2+1.
Quoted 2 lines
But, if this gets to complicated it might not be worth holding off getting it merged
Possibly. It depends on the timing of the merge windows. The current code works with some devices.
Quoted 9 lines
Quoted 6 lines
It now occurs to me that another step in CPU efficiency could be had by abusing the receive-fifo-is-half-full interrupt to signal the completion of a transfer. This would only work for transfers of four or more words and would need some careful jiggery-pokery at end of transfer to turn the tx-fifo-is-half-empty interrupt enable off and ensure that exactly four words would end up in the RX FIFO.
That might work but I think it could break horribly. The "jiggery-pokery"
could end up being pretty messy.
Yes. It is looking nasty and it would make a mess of the place where the continuity stuff needs to happen to achieve actual functionality improvements.
To get some idea of the potential wins I've been instrumenting the code today to see how many interrupts it takes to receive the last 4 words
At 3.7MHz I'm seeing up to 3 interrupts waiting for the final draining to happen, with an average of 1.36 (1 would be the perfect figure) At 400kHz it takes up to 26 with an average of 9.92
Me, I only really care about the SD card case, where a half dozen useless interrupts per 512-byte block is not going to impact on the CPU usage much. In fact, by making the interrupt routine more complex it may even end up being more cpu hungry in the end.
On the other hand, slow clock-speed devices are using needless high CPU, especially if the transfer sizes are small as is typical with command-response devices.
Quoted 5 lines
But, the tx-fifo-is-half-empty might be what is needed to handle the multiple transfer merging. We know the driver is finished transfering the data to the fifo when (
espi->tx==t->len). At this point we are just wating for the last (fifo_level) bytes to come in on the rx fifo, this could be anything from 1 to 8 bytes.
Another instrumentation show that yes, at 3.7MHz, the data read on each interrupt is between 1 and 8 words. I'm surprised it gets to 8 full - maybe when the interrupt is requested while some other IRQ (ether? clock tick?) is already in progress? I'm instrumenting in a way that shouldn't change the timing characteristics of the transfer (ie a tiny printk's only after end of transfer)
Quoted 3 lines
Quoted 1 line
It's a horrible thought, and I suspect that the DMA engine is the real answer.
The DMA engine might help but it's not here yet....
Yes. What I mean is that the prospect of that happening somewhere in the future reduces the importance of doing hairy jiggery pokery with the interrupt version.
M
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
be merged through Russells tree pending some changes to our board structure in u8500/ux500.
Yours,
Linus Walleij
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
not, how about to remove it. It consumes the memory and increase code itself. It's only function pin instead of GPIOs.
Thank you,
Kyungmin Park
Quoted 4 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D
S5PV210_MP07_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP07(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP07_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP07",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP10_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP10(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP10_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP10",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP11_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP11(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP11_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP11",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP12_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP12(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP12_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP12",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP13_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP13(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP13_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP13",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP14_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP14(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP14_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP14",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP15_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP15(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP15_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP15",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP16_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP16(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP16_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP16",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP17_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP17(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP17_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP17",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP18_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP18(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP18_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP18",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP20_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP20(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP20_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP20",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP21_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP21(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP21_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP21",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP22_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP22(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP22_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP22",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP23_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP23(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP23_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP23",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP24_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP24(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP24_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP24",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP25_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP25(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP25_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP25",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP26_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP26(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP26_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP26",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP27_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP27(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP27_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP27",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_MP28_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_MP28(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
MP28_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "MP28",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_ETC0_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_ETC0(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
ETC0_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "ETC0",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_ETC1_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_ETC1(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
ETC1_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "ETC1",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_ETC2_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_ETC2(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
ETC2_NR,
Quoted 7 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "ETC2",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 }, {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3DS5PV210_ETC4_BASE,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .config =3D&gpio_cfg_noint,
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .chip =A0 =3D {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .base =A0 =3D S5PV210_ETC4(=
0),
Quoted 1 line
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .ngpio =A0=3D S5PV210_GPIO_=
ETC4_NR,
arch/arm/include/asm/hardware/pl330.h
Quoted 9 lines
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .label =A0=3D "ETC4",
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 },
+ =A0 =A0 =A0 },arch/arm/include/asm/hardware/pl330.h new file +6
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
=A0ARRAY_SIZE(s5pv210_gpio_4bit));
arch/arm/mach-s5=
Quoted 5 lines
arch/arm/include/asm/hardware/pl330.h new file +4
-0Lines of this file are not shown. View the raw message.
arch/arm/mach-s5= renamed from arch/arm/mach-s5pv210/include/mach/gpio.h +0
-0The rest of this diff is not shown. View the raw message.
pv210/include/mach/gpio.h
Quoted 44 lines
index 533b020..ddbbfc3 100644
arch/arm/mach-s5pv210/include/mach/gpio.h +33
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
=A0/* GPIO bank numbers */
=A0/*
CONFIG_S3C_GPIO_SPACEallows the user to select extraarch/arm/mach-s5pv210/include/mach/gpio.h +0
-0@@ -85,6 +118,35 @@ enum s5p_gpio_number {
Quoted 1 line
=A0 =A0 =A0 =A0S5PV210_GPIO_J2_START =A0 =3D S5PV210_GPIO_NEXT(S5PV210_GP=
IO_J1),
Quoted 1 line
=A0 =A0 =A0 =A0S5PV210_GPIO_J3_START =A0 =3D S5PV210_GPIO_NEXT(S5PV210_GP=
IO_J2),
Quoted 1 line
=A0 =A0 =A0 =A0S5PV210_GPIO_J4_START =A0 =3D S5PV210_GPIO_NEXT(S5PV210_GP=
IO_J3),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP01_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
J4),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP02_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP01),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP03_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP02),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP04_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP03),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP05_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP04),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP06_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP05),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP07_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP06),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP10_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP07),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP11_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP10),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP12_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP11),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP13_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP12),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP14_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP13),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP15_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP14),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP16_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP15),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP17_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP16),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP18_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP17),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP20_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP18),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP21_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP20),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP22_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP21),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP23_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP22),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP24_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP23),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP25_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP24),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP26_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP25),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP27_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP26),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_MP28_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP27),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_ETC0_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
MP28),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_ETC1_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
ETC0),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_ETC2_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
ETC1),
Quoted 1 line
+ =A0 =A0 =A0
S5PV210_GPIO_ETC4_START=3D S5PV210_GPIO_NEXT(S5PV210_GPIO_=
ETC2),
Quoted 37 lines
=A0};
=A0/* S5PV210 GPIO number definitions */
arch/arm/mach-s5pv210/include/mach/gpio.h +29
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Quoted 2 lines
=A0/* the end of the S5PV210 specific gpios */
-#defineS5PV210_GPIO_END=A0 =A0 =A0 (S5PV210_GPJ4(S5PV210_GPIO_J4_NR)+=
1)
Quoted 1 line
+#define
S5PV210_GPIO_END=A0 =A0 =A0 (S5PV210_ETC4(S5PV210_GPIO_ETC4_NR)=
+ 1)
Quoted 3 lines
=A0#define
S3C_GPIO_END=A0 =A0 =A0 =A0 =A0S5PV210_GPIO_END-/* define the number of gpios we need to the one after the
GPJ4()range =
*/
Quoted 1 line
-#define
ARCH_NR_GPIOS=A0 =A0 =A0 =A0 =A0(S5PV210_GPJ4(S5PV210_GPIO_J4_N=
R) + =A0 =A0 \
Quoted 1 line
+/* define the number of gpios we need to the one after the
ETC4()range =
*/
Quoted 1 line
+#define
ARCH_NR_GPIOS=A0 =A0 =A0 =A0 =A0(S5PV210_ETC4(S5PV210_GPIO_ETC4=
_NR) + =A0 \
Quoted 1 line
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
CONFIG_SA=
MSUNG_GPIO_EXTRA + 1)
arch/arm/ma=
Quoted 3 lines
=A0#include <
asm-generic/gpio.h>arch/arm/ma= renamed from arch/arm/mach-s5pv210/include/mach/regs-gpio.h +0
-0
ch-s5pv210/include/mach/regs-gpio.h
Quoted 85 lines
new file mode 100644
index 0000000..c78bbebarch/arm/mach-s5pv210/include/mach/regs-gpio.h new file +77
-1Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
1.6.2.5
Quoted 2 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-s=
oc" in
Quoted 6 lines
the body of a message to majordomo at vger.kernel.org More majordomo info at =A0http://vger.kernel.org/majordomo-info.html
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
not figured
out how to use type 2b and type 3b descriptors. It's not the fault of DMA driver or
specification :-) It's actually upto the client to select the right type.
Quoted 9 lines
Review
Quoted 8 lines
(quoted diff) +8
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Minute point really. Better readability "
ch_params"
OK
Quoted 7 lines
Quoted 7 lines
+ =A0 =A0
dma_write(l, CDP(lch));
+ =A0 =A0dma_write((lcfg->sgheadphy), CNDP(lch));
+ =A0 =A0 /**
+ =A0 =A0 =A0* Barrier needed as writes to the
+ =A0 =A0 =A0* descriptor memory needs to be flushed
+ =A0 =A0 =A0* before it's used by DMA controller
+ =A0 =A0 =A0*/
Quoted 5 lines
Little bit of re-wording if you can.
Also you don't wanted the double **
=A0 =A0 =A0 =A0/*
=A0 =A0 =A0 =A0 * Memory barrier is needed because data may still be =A0 =A0 =A0 =A0 * in the write buffer. The barrier drains write buffers a=
nd
Quoted 2 lines
=A0 =A0 =A0 =A0 * ensures that DMA sees correct descriptors =A0 =A0 =A0 =A0 */
OK
Quoted 5 lines
Quoted 5 lines
+ =A0 =A0
wmb();
+ =A0 =A0omap_start_dma(lch);
+
+ =A0 =A0 /* Maintain the pause state in descriptor */
+ =A0 =A0omap_set_dma_sglist_pausebit(lcfg, lcfg->pausenode, 0);
Quoted 8 lines
Quoted 7 lines
+ =A0 =A0
omap_set_dma_sglist_pausebit(lcfg, pauseafter, 1); +
+ =A0 =A0 /**
+ =A0 =A0 =A0* Barrier needed as writes to the
+ =A0 =A0 =A0* descriptor memory needs to be flushed
+ =A0 =A0 =A0* before it's used by DMA controller
+ =A0 =A0 =A0*/Description change if possible
OK
Quoted 3 lines
Quoted 3 lines
+ =A0 =A0
wmb();
+
+ =A0 =A0 /* Errata i557 - pausebit should be cleared in no standby mode=
*/
Quoted 1 line
This should have been
I couldn't understand this comment.
Quoted 8 lines
Quoted 5 lines
+ =A0 =A0
sys_cf=3Ddma_read(OCP_SYSCONFIG);
+ =A0 =A0 l =3Dsys_cf;
+ =A0 =A0 /* Middle mode reg set no Standby */
+ =A0 =A0 l &=3D ~(BIT(12) | BIT(13));
+ =A0 =A0dma_write(l, OCP_SYSCONFIG);From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
Origin 1.1"
Quoted 20 lines
The following commits are in:
Pinkava J (7):
ARM: n30: Enable Acer n35 if Acer n30 is selected
ARM: n30: fix: suspended wrong USB port on Acer n35
ARM: n30: Add RTC platform device for Acer n30 / Acer n35
ARM: n35: Add support for LEDs on Acer n35
ARM: n35: Enable wake-up by Power button on Acer n35
ARM: n30: Add support for MMC card reader on Acer n30 / Acer n35
ARM: n30: Add support for power on/off on Acer n30 / Acer n35 MMC card readerarch/arm/mach-s3c2410/Kconfig | 7 ++++ arch/arm/mach-s3c2410/mach-n30.c | 65 +++++++++++++++++++++++++++++++++++++- 2 files changed, 71 insertions(+), 1 deletions(-)
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
| NOTE: This routine need only be called for page cache pages | which can potentially ever be mapped into the address | space of a user process. So for example, VFS layer code | handling vfs symlinks in the page cache need not call | this interface at all.
A page from slab or stack is not going to see the sky of user land and therefore it should not be fed into flush_dcache_page().
Sebastian
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
actually using the cfg_eint anywhere. For the S5PV210 it seems that the gpio pin configuration is static for all gpio banks.
It is probably going to be easier to remove it from this code and look at removing it altogether from the s3c_gpio_cfg configuration structure.
Also, but not a stopper to getting this merged, we should probably make a standard config structure for this and then re-use it, as iirc this will be the same as the 64xx case if we remove the cfg_eint.
arch/arm/mach-s5pv210/include/mach/regs-gpio.h
Quoted 227 lines
arch/arm/mach-s5pv210/include/mach/regs-gpio.h new file +227
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
^& replace with nr_chips.
Signature · 4 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
leave this comment for now.
Quoted 199 lines
Quoted 199 lines
arch/arm/plat-s5p/irq-eint.c
Quoted 194 lines
(quoted diff) +14
-0Lines of this file are not shown. View the raw message.
arch/arm/plat-s5p/Kconfig +0
-0@@ -23,3 +23,8 @@ config PLAT_S5PThe rest of this diff is not shown. View the raw message.
? ? ? select
SAMSUNG_IRQ_UART
? ? ? help
? ? ? ? Base platform code for Samsung's S5P series SoC.arch/arm/plat-s5p/Kconfig +5
-0Lines of this file are not shown. View the raw message.
arch/arm/plat-s5p/Makefile +0
-0@@ -16,4 +16,5 @@ obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? += dev-uart.oThe rest of this diff is not shown. View the raw message.
?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= cpu.o ?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= clock.o ?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= irq.o +obj-$(CONFIG_S5P_EXT_INT) ? ?+= irq-eint.o ?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= setup-i2c0.o
arch/arm/plat-s5p/irq-eint.c new file +151
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
We don't need to do any masking here as we'll always be processing all interrupts from the controller. In fact, we probably don't need the end argument here at-all.
Quoted 11 lines
Quoted 11 lines
arch/arm/plat-s5p/irq-eint.c
Quoted 11 lines
arch/arm/plat-s5p/irq-eint.c new file +11
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
We can remove the end parameters, both interrupt banks are 8 IRQs and this we can also make the bit clearing post mask a constant if it is even needed.
Quoted 53 lines
Quoted 53 lines
Quoted 53 lines
arch/arm/plat-s5p/irq-eint.c new file +53
-0Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 4 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year.
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
data at registering time, which is built-in, but I guess you object because of the size of all the extra data and code that would come by making mach-omapX/mailbox.c as built-in. Am I right?
If that's the case I agree, although I have the feeling that the platform-specific data can be reduced a lot.
But again, only one of the patches makes the code built-in, the rest of the patches are independent of that.
Signature · 1 line
Felipe Contreras
Quoted 1 line
From [email protected] Fri Nov 6 13:01:15 2009
From: [email protected] ()
Date: Fri, 06 Nov 2009 18:01:15 -0000
Subject: No subject
Message-ID: <[email protected]>
/*
* This is normally called from the decompressor code. The requirements
* are: MMU = off, D-cache = off, I-cache = dont care, r0 = 0,
* r1 = machine nr, r2 = atags pointer.
*/
Since D-cache is off when entering kernel then what's the point of flushing data cache here? In theory we only need make sure the whole cache is invalidated right? So that when MMU is enabled the cache is in a clean status with everything new loaded.
I'm asking this is I'm running a simulation and somehow the simulation can not continue when data cache is cleaned but invalidate only works. My doubt is since the cache content is garbage when chip is powered on, "xxx" data may be flushed to memory if "clean and invalidate" is performed, which cause my simulation problem.
Any one can help me understand this? Thanks in advance.
-Tim
--000e0cd70ad85790720488287990
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Hi,<div>I have a question regarding the data cache flush routine called at = the beginning of kernel start up. At the beginning of the start up code, af= ter processor type and machine type look up and simple page table created, = a __switch_data is called which goes to=A0__v7_setup in my case (since the = CPU is A9). Then at the beginning of the function it calls v7_flush_dcache_= all. This cache routine is in cache-v7.S and I see it actually does "c= lean and invalidate" operation as opposed to invalidate only.</div> <div><br></div><div>From Russell's comment I can see this is the kernel=
start requirement:</div><div><div><br></div><div>/*</div><div>=A0* This is= normally called from the decompressor code. =A0The requirements</div><div>
=A0* are: MMU =3D off, D-cache =3D off, I-cache =3D dont care, r0 =3D 0,</d= iv><div>=A0* r1 =3D machine nr, r2 =3D atags pointer.</div><div>=A0*/</div>= <div><br></div><div>Since D-cache is off when entering kernel then what'= ;s the point of flushing data cache here? In theory we only need make sure = the whole cache is invalidated right? So that when MMU is enabled the cache=
is in a clean status with everything new loaded.</div>
<div><br></div><div>I'm asking this is I'm running a simulation and=
somehow the simulation can not continue when data cache is cleaned but inv=
alidate only works. My doubt is since the cache content is garbage when chi= p is powered on, "xxx" data may be flushed to memory if "cle= an and invalidate" is performed, which cause my simulation problem.</d= iv>
<div><br></div><div>Any one can help me understand this? Thanks in advance.= </div><div><br></div><div>-Tim</div><div><br></div><div><br></div><div><br>= </div><div><br></div></div><div><br></div>
--000e0cd70ad85790720488287990--
Part of the diff is not shown here. View the raw message.