bug in new IMQ ?
Hello to list and Patrick !
scuse me first for my bad english:)
I'm using the new IMQ code since 2 days, and it's very efficient! but i've experimented a bad problem, that i doesn't manage to resolve.
for example I load these simple rules:
tc qdisc add dev imq0 handle 1: root htb default 1
tc class add dev imq0 parent 1: classid 1:1 htb rate 500kbit burst 30k
tc qdisc add dev imq0 parent 1:1 handle 21:0 sfq
tc filter add dev imq0 protocol ip parent 1: handle 10 fw classid 1:1
iptables -t mangle -A PREROUTING -i ppp0 -j IMQ iptables -t mangle -A PREROUTING -i ppp0 -j MARK --set-mark 10 ip link set imq0 up
the result in the syslog is (at the first network activity)
"kernel: nf_hook: Verdict = QUEUE."
and quickly become:
"kernel: last message repeated 6 times"
the real problem is that I've experimented a silent Crash this morning but before using IMQ this machine was rock stable (months without crash) the only usable log of it is:
Apr 8 10:03:55 way kernel: nf_hook: Verdict = QUEUE. Apr 8 10:04:26 way last message repeated 1533 times Apr 8 10:05:27 way last message repeated 2982 times Apr 8 10:06:28 way last message repeated 2808 times Apr 8 10:07:29 way last message repeated 2837 times Apr 8 10:08:30 way last message repeated 2841 times Apr 8 10:09:31 way last message repeated 3008 times >> crash here, pc completely freezed << Apr 8 10:21:08 way syslogd 1.4.1: restart.
Configuration:
o kernel 2.4.18 with HTB patch,
o netfilter/iptables v1.2.6a from CVS, ppp0 is kernel mode pppoe,
o iproute2-ss020116 compiled with HTB patch
So, is it a bug, or a misconfiguration ?
tanks a lot!:)
curio / a QoS addicted french guy :)
_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
Hi Simond.
Quoted 8 lines · SIMOND François
Hello to list and Patrick !
scuse me first for my bad english:)I'm using the new IMQ code since 2 days, and it's very efficient! but i've experimented a bad problem, that i doesn't manage to resolve.
for example I load these simple rules:
...
Quoted 4 lines
the result in the syslog is (at the first network activity)
"kernel:nf_hook: Verdict = QUEUE."
and quickly become:
"kernel: last message repeated 6 times"
This means you have compiled your kernel with netfilter debugging turned on.
Turn it off and the message will disappear.
Quoted 4 lines
the real problem is that I've experimented a silent Crash this morning but before using IMQ this machine was rock stable (months without crash) the only usable log of it is:
Sorry about that :)
It IS a bug and it has been fixed, i will put out a new version tonight. The problem was that packets returned later from non-work-conserving qdiscs
were passed on to registered network interface taps twice and somewhere there
a null pointer reference occured.
PS: Please write bugreports directly to me
_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
Hi Simond.
Quoted 8 lines · SIMOND François
Hello to list and Patrick !
scuse me first for my bad english:)I'm using the new IMQ code since 2 days, and it's very efficient! but i've experimented a bad problem, that i doesn't manage to resolve.
for example I load these simple rules:
...
Quoted 4 lines
the result in the syslog is (at the first network activity)
"kernel:nf_hook: Verdict = QUEUE."
and quickly become:
"kernel: last message repeated 6 times"
You have compiled your kernel with NETFILTER DEBUGGING, turn it off and it will disappear.
Quoted 5 lines
the real problem is that I've experimented a silent Crash this morning but before using IMQ this machine was rock stable (months without crash) the only usable log of it is:
So, is it a bug, or a misconfiguration ?
Sorry about that, it IS a bug :(
It has been fixed and i will put out a new version tonight. The problem was that packets passed through non-work-conserving qdiscs were delivered to dev_queue_xmit_nit twice and somewhere there a NULL pointer reference occured.
PS: In the future please send bugreports directly to me or at least CC
Bye,
Patrick
_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
Quoted 9 lines
Quoted 1 line
So, is it a bug, or a misconfiguration ?
Sorry about that, it IS a bug :(
It has been fixed and i will put out a new version tonight. The problem was that packets passed through non-work-conserving qdiscs were delivered todev_queue_xmit_nittwice and somewhere there a NULL pointer reference occured.PS: In the future please send bugreports directly to me or at least CC
happy hacking patrick ;) When I have written HTB I suspect that all will go well. A week later I spend whole days catching bugs people reported.
Sometimes very tricky ones ....
nice to see another active developer in field !
Let Power be with you Patrick ;)
devik
_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
Quoted 4 lines · Martin Devera
happy hacking patrick ;) When I have written HTB I suspect that all will go well. A week later I spend whole days catching bugs people reported.
Sometimes very tricky ones ....
Yeah the problem was i wrote the new imq during easter holidays while i was staying at my parents on my laptop so i hadn't got a chance to extensively test it ..
As soon as i tried it on my router it also crashed :) The new version i promised for yesterday is not out yet, i will probably put it out tonight after some more testing ..
Quoted 2 lines
nice to see another active developer in field !
Let Power be with you Patrick ;)
:)
I thought about changing qos subsystem to support real ingress queueing without imq or something. Kind of two root qdiscs per device. What do you
(and others) think about this ?
Bye,
Patrick
_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
Quoted 8 lines
Quoted 2 lines
nice to see another active developer in field !
Let Power be with you Patrick ;):)
I thought about changing qos subsystem to support real ingress queueing without imq or something. Kind of two root qdiscs per device. What do you
(and others) think about this ?
There already is somethink like it (ingres) only it doesn't queue .. IMO the main problem will be to understand whole machinery in sch_generic.c and likes.
Also Jamal and Alexey are against this ... But I think it is worth of doing it. Especially in 2.4 where we have both rx and tx softirqs it should not be so comlicated to do it.
devik
_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
Quoted 6 lines · Martin Devera
Quoted 4 lines
I thought about changing qos subsystem to support real ingress queueing without imq or something. Kind of two root qdiscs per device. What do you
(and others) think about this ?There already is somethink like it (ingres) only it doesn't queue ..
:) In my eyes current ingres is just a hack.
Quoted 3 lines
IMO the main problem will be to understand whole machinery in
sch_generic.cand likes.
Also Jamal and Alexey are against this ... But I think it is worth
Why ? I guess IMQ prooves ingress shaping DOES work so i can't see any good reason ..
Quoted 2 lines
of doing it. Especially in 2.4 where we have both rx and tx softirqs it should not be so comlicated to do it.
One problem i see is that unlike imq it would probably be placed in net_rx_action so you can't use netfilter marks for filters which i guess is really bad for ingress because without iptables you cannot use any kind of connection state etc. information for filters so preventing DOS will be much harder, but that will probably remain unsolvable ..
Patrick
_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/