Skip to contentSkip to conversation

htb_change sfq_change

LARTC Catalin BOIE 3 participants 14 messages May 9, 2002 – May 16, 2002

lore
Share & tools
lore
#1 lore raw

Because there is nothing to change once created. For HTB it might be r2q or debug but there is no real need yet. devik

Quoted 7 lines · Catalin BOIE

Hello!

Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change function is not sfq_change (or htb_change) and is NULL instead?

Thank you very much!

Quoted 10 lines

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#2 lore raw
In reply to Catalin BOIE
Quoted 9 lines · Martin Devera

Date: Thu, 9 May 2002 12:29:00 +0200 (CEST)
From: Martin Devera <[email protected]>
To: Catalin BOIE <[email protected]>
Cc: [email protected]
Subject: Re: [LARTC] htb_change sfq_change

Because there is nothing to change once created. For HTB it might be r2q or debug but there is no real need yet. devik

OK.
But for SFQ?

Quoted 15 lines · Catalin BOIE
Quoted 13 lines

Hello!

Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change function is not sfq_change (or htb_change) and is NULL instead?

Thank you very much!

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

Quoted 6 lines
Quoted 5 lines

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#3 lore raw
In reply to Catalin BOIE
Quoted 9 lines · Martin Devera

Date: Thu, 9 May 2002 12:29:00 +0200 (CEST)
From: Martin Devera <[email protected]>
To: Catalin BOIE <[email protected]>
Cc: [email protected]
Subject: Re: [LARTC] htb_change sfq_change

Because there is nothing to change once created. For HTB it might be r2q or debug but there is no real need yet. devik

It's hard to implement it?
Thanks!

Quoted 21 lines · Catalin BOIE
Quoted 8 lines

Hello!

Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change function is not sfq_change (or htb_change) and is NULL instead?

Thank you very much!

Quoted 10 lines

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Quoted 4 lines

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#4 lore raw
In reply to Catalin BOIE

Should not be. But HTB is in feature freeze. My main goal is to be in kernel asap.
Then we can do some changes later. I'd like to keep the code from larger updates now.
Do you need it ? And why ?
devik

Quoted 41 lines · Catalin BOIE
Quoted 9 lines · Martin Devera

Date: Thu, 9 May 2002 12:29:00 +0200 (CEST)
From: Martin Devera <[email protected]>
To: Catalin BOIE <[email protected]>
Cc: [email protected]
Subject: Re: [LARTC] htb_change sfq_change

Because there is nothing to change once created. For HTB it might be r2q or debug but there is no real need yet. devik

It's hard to implement it?
Thanks!

Quoted 21 lines · Catalin BOIE
Quoted 8 lines

Hello!

Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change function is not sfq_change (or htb_change) and is NULL instead?

Thank you very much!

Quoted 10 lines

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Quoted 4 lines

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Quoted 7 lines

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#6 lore raw
In reply to Catalin BOIE
Quoted 2 lines

Should not be. But HTB is in feature freeze. My main goal is to be in kernel asap.

I wish you good luck!
HTB deserves to be in the main kernel tree.

Quoted 2 lines

Then we can do some changes later. I'd like to keep the code from larger updates now.

OK.

Quoted 1 line

Do you need it ? And why ?

Yes, I need it.
I need to change on the fly r2q to see how the traffic flow changes. But I don't want to delete the whole tree just to change some parameters on the root class.

Quoted 53 lines

devik

Quoted 48 lines · Catalin BOIE
Quoted 9 lines · Martin Devera

Date: Thu, 9 May 2002 12:29:00 +0200 (CEST)
From: Martin Devera <[email protected]>
To: Catalin BOIE <[email protected]>
Cc: [email protected]
Subject: Re: [LARTC] htb_change sfq_change

Because there is nothing to change once created. For HTB it might be r2q or debug but there is no real need yet. devik

It's hard to implement it?
Thanks!

Quoted 21 lines · Catalin BOIE
Quoted 8 lines

Hello!

Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change function is not sfq_change (or htb_change) and is NULL instead?

Thank you very much!

Quoted 10 lines

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Quoted 4 lines

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#8 lore raw
In reply to Catalin BOIE
Quoted 2 lines

I wish you good luck!
HTB deserves to be in the main kernel tree.

Thanks :)

Quoted 5 lines
Quoted 1 line

Do you need it ? And why ?

Yes, I need it.
I need to change on the fly r2q to see how the traffic flow changes. But I don't want to delete the whole tree just to change some parameters on the root class.

you can't do it either. The r2q is used ONLY during class creation to compute its default quantum.
To test your case you would need to call tc class change for all existing classes.
devik

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#9 lore raw
In reply to Catalin BOIE

:) You can drop & recreate it safely. User will
not see it. The change function for SFQ will be
probably considered "redundant" by other kernel
developers because of it.

Quoted 4 lines · Catalin BOIE
Quoted 4 lines
Quoted 2 lines

OK.
But for SFQ?

what do you want to change in sfq !!??

Quoted 11 lines

perturb and quantum on-the-fly.

Quoted 1 line

devik

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#10 lore raw
In reply to Catalin BOIE
Quoted 10 lines · Martin Devera

Date: Tue, 14 May 2002 14:15:36 +0200 (CEST)
From: Martin Devera <[email protected]>
To: Catalin BOIE <[email protected]>
Cc: [email protected]
Subject: Re: [LARTC] htb_change sfq_change

:) You can drop & recreate it safely. User will not see it. The change function for SFQ will be probably considered "redundant" by other kernel developers because of it.

But you loose counters! This is bad IMHO.

Quoted 11 lines · Catalin BOIE
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

OK.
But for SFQ?

what do you want to change in sfq !!??

perturb and quantum on-the-fly.

Quoted 1 line

devik

Quoted 8 lines
Quoted 7 lines

---
Catalin(ux) BOIE
[email protected]
http://www2.deuroconsult.ro/~catab

---
Catalin(ux) BOIE
[email protected]
openh323://dino.rdsbv.ro

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#11 lore raw
In reply to Catalin BOIE
Quoted 2 lines · Catalin BOIE

On Tue, 14 May 2002, Martin Devera wrote:
But you loose counters! This is bad IMHO.

If you know when you're dropping it, the counter loss is not relevant; resetting to zero is easy to compensate for, and rrdtool (for example) has built-in support for it.

As per the rrdtool developper's recommendations, I have the following in front of my QoS reset script:
rrdtool update /var/rrd/qos_office.rrd N:U:U:U:U
rrdtool update /var/rrd/qos_office.rrd N:0:0:0:0

... done for each rrd file.

Signature · 6 lines
Michael T. Babcock
CTO, FibreSpeed Ltd.     (Hosting, Security, Consultation, Database, etc)
http://www.fibrespeed.net/~mbabcock/
_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
#12 lore raw
In reply to Catalin BOIE
Quoted 6 lines
Quoted 4 lines

:) You can drop & recreate it safely. User will
not see it. The change function for SFQ will be
probably considered "redundant" by other kernel
developers because of it.

But you loose counters! This is bad IMHO.

That's good point ! So that go ahead and implement it for SFQ :)

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#13 lore raw
In reply to Catalin BOIE
Quoted 11 lines · Martin Devera

Date: Wed, 15 May 2002 15:11:09 +0200 (CEST)
From: Martin Devera <[email protected]>
To: Catalin BOIE <[email protected]>
Cc: [email protected]
Subject: Re: [LARTC] htb_change sfq_change

Quoted 5 lines
Quoted 4 lines

:) You can drop & recreate it safely. User will
not see it. The change function for SFQ will be
probably considered "redundant" by other kernel
developers because of it.

Quoted 4 lines
Quoted 1 line

But you loose counters! This is bad IMHO.

That's good point ! So that go ahead and implement it for SFQ :)

But it is already!
But in sch_sfq.c at the end (in jump table) is "NULL /* sfq_change */"! There are race problems in sfq_change?

I found a patch on the net that puted NULL instead sfq_change...

Thanks!

---
Catalin(ux) BOIE
[email protected]
openh323://dino.rdsbv.ro

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/