Skip to contentSkip to conversation

scsi_id release 0.2

announce Olaf Hering 3 participants 5 messages Dec 7, 2003 – Dec 12, 2003 Kbuild

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines · Patrick Mansfield

Version 0.2 of scsi_id is available at:

http://www-124.ibm.com/storageio/scsi_id/scsi_id-0.2.tar.gz

What is $(DEBUG)? It is used by klibc and replaced by true/false.

scsi_id/Makefile 2003-12-07 16:08:20.000000000 +0100 renamed from Makefile 2003-12-05 23:26:25.000000000 +0100 +1 -1
diff -purN scsi_id-0.2/Makefile extras/scsi_id/Makefile
@@ -27,7 +27,7 @@ INSTALL_DATA  = ${INSTALL} -m 644
 # Note some of the variables used here are set when built under udev, and
 # otherwise might not be set.
 
-override CFLAGS+=-DSCSI_ID_VERSION=\"$(SCSI_ID_VERSION)\" $(DEBUG) -Wall
+override CFLAGS+=-DSCSI_ID_VERSION=\"$(SCSI_ID_VERSION)\" -Wall
 
 PROG=scsi_id
 SYSFS=-lsysfs
Signature · 14 lines
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG


-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
#1 lore raw
Quoted 7 lines · Olaf Hering
Quoted 3 lines · Patrick Mansfield

Version 0.2 of scsi_id is available at:

http://www-124.ibm.com/storageio/scsi_id/scsi_id-0.2.tar.gz

What is $(DEBUG)? It is used by klibc and replaced by true/false.

I use it to compile with -g.

i.e.:

	# make DEBUG=-g 
	cc -DSCSI_ID_VERSION=\"0.2\" -g -Wall   -c -o scsi_id.o scsi_id.c
	cc -DSCSI_ID_VERSION=\"0.2\" -g -Wall   -c -o scsi_serial.o scsi_serial.c
	cc  -o scsi_id  scsi_id.o scsi_serial.o  -lsysfs  

The udev DEBUG value does not get passed down to the extras, so the scsi_id build under udev should be OK.

Is it breaking your build? If so I'll just remove it.

The scsi_id debug logging via the "-v" or when DEBUG is set is always enabled - it outputs to syslog LOG_DEBUG when called from udev, or via stderr when used via the command line. (Though the klibc strerror() only prints the errno value, making for some odd error messages.)

-- Patrick Mansfield

-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

#2 lore raw
In reply to Olaf Hering
Quoted 13 lines · Patrick Mansfield
Quoted 7 lines · Olaf Hering
Quoted 3 lines · Patrick Mansfield

Version 0.2 of scsi_id is available at:

http://www-124.ibm.com/storageio/scsi_id/scsi_id-0.2.tar.gz

What is $(DEBUG)? It is used by klibc and replaced by true/false.

I use it to compile with -g.

i.e.:

Quoted 7 lines
	# make DEBUG=-g 
	cc -DSCSI_ID_VERSION=\"0.2\" -g -Wall   -c -o scsi_id.o scsi_id.c
	cc -DSCSI_ID_VERSION=\"0.2\" -g -Wall   -c -o scsi_serial.o scsi_serial.c
	cc  -o scsi_id  scsi_id.o scsi_serial.o  -lsysfs  

The udev DEBUG value does not get passed down to the extras, so the scsi_id build under udev should be OK.

It does. make EXTRAS=extras/scsi_id will pass DEBUG�lse/true if defined.

Quoted 1 line

Is it breaking your build? If so I'll just remove it.

Yes, just try to build a udev debug binary.

I need also this patch because gcc decides that a printf("\n"); could be done with a putchar, which is not defined for some reasons.

scsi_id/Makefile 2003-12-07 15:14:09.000000000 +0100 renamed from scsi_id/Makefile.orig 2003-12-07 15:05:33.000000000 +0100 +1 -1
@@ -27,7 +27,7 @@ INSTALL_DATA  = ${INSTALL} -m 644
 # Note some of the variables used here are set when built under udev, and
 # otherwise might not be set.
 
-override CFLAGS+=-DSCSI_ID_VERSION=\"$(SCSI_ID_VERSION)\" $(DEBUG) -Wall
+override CFLAGS+=-DSCSI_ID_VERSION=\"$(SCSI_ID_VERSION)\" -Wall -fno-builtin
 
 PROG=scsi_id
 SYSFS=-lsysfs

Greg has the new scsi_id already merged into the bk repo.

Signature · 14 lines
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG


-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
#3 lore raw
In reply to Olaf Hering
Quoted 5 lines · Olaf Hering
Quoted 1 line · Patrick Mansfield

Is it breaking your build? If so I'll just remove it.

Yes, just try to build a udev debug binary.

It worked fine for me, something must be different in our build environments. I have:

[elm3b79 udev-bk]$ gcc -v
Reading specs from /usr/lib/gcc-lib/i386-linux/2.95.4/specs gcc version 2.95.4 20011002 (Debian prerelease)

I should probably upgrade.

But in any case I applied your patch to my view, thanks.

-- Patrick Mansfield

-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

#4 lore raw
In reply to Olaf Hering
Quoted 2 lines · Olaf Hering

I need also this patch because gcc decides that a printf("\n"); could be done with a putchar, which is not defined for some reasons.

#include <stdio.h>

must be missing somewhere.

Signature · 13 lines
Regards,
Rask Ingemann Lambertsen


-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel