Skip to contentSkip to conversation

small parser fix

PATCH Marco d'Itri 2 participants 2 messages Dec 17, 2003

lore
Share & tools
lore

Marco d'Itri

author
#0 lore raw

The parser will complain if the rules file contains empty lines. BTW, it's a real PITA udev exiting without an output or logging if a single line in a config file cannot be parsed.

Signature · 2 lines
ciao, |
Marco | [3659 anKlt7WQ1y7rw]
namedev_parse.c +1 -1
diff -ruN udev-009.orig/namedev_parse.c udev-009/namedev_parse.c
@@ -159,7 +160,7 @@
 		dbg_parse("read '%s'", temp);
 
 		/* empty line? */
-		if (*temp == 0x00)
+		if (*temp == 0x00 || *temp == '\n')
 			continue;
 
 		/* see if this is a comment */
#1 lore raw
Quoted 1 line · Marco d'Itri

The parser will complain if the rules file contains empty lines.

Thanks, I've fixed this with the other patch sent in.

Quoted 2 lines

BTW, it's a real PITA udev exiting without an output or logging if a single line in a config file cannot be parsed.

What do you suggest we do? We log errors if debugging is enabled. Hm, maybe we should return an error to userspace...

thanks,

greg k-h

-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials. Become an expert in LINUX or just sharpen your skills. Sign up for IBM's Free Linux Tutorials. Learn everything from the bash shell to sys admin. Click now! http://ads.osdn.com/?ad_id78&alloc_id371&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel