Skip to contentSkip to conversation

duplicate #define's in arch/ia64/kernel/minstate.h??

PATCH In review Pat O'Rourke 2 participants 3 messages Sep 1, 2000 – Sep 6, 2000

lore
Share & tools
lore

Pat O'Rourke

author
#0 lore raw

PATCH 1/1 duplicate #define's in arch/ia64/kernel/minstate.h??

It seems that the definition of STOPS, SAVE_MIN_WITH_COVER, SAVE_MIN_WITH_COVER_R19 and SAVE_MIN are duplicated at the end of arch/ia64/kernel/minstate.h. Is this a typo, or am I missing something?

Here's a patch (based on 2.4.0-test7) which removes the duplicates if it's an error.

Pat

Signature · 21 lines
Patrick O'Rourke
[email protected]

--- minstate.h	Thu Jun 22 10:09:44 2000
+++ /homes/orourke/minstate.h	Fri Sep  1 16:37:47 2000
@@ -192,13 +192,3 @@
 #define SAVE_MIN_WITH_COVER	DO_SAVE_MIN(cover;; mov rCRIFS=cr.ifs,) STOPS
 #define SAVE_MIN_WITH_COVER_R19	DO_SAVE_MIN(cover;; mov rCRIFS=cr.ifs, mov 
r15=r19) STOPS
 #define SAVE_MIN		DO_SAVE_MIN(mov rCRIFS=r0,) STOPS
-
-#ifdef CONFIG_ITANIUM_ASTEP_SPECIFIC
-# define STOPS	nop.i 0x0;; nop.i 0x0;; nop.i 0x0;;
-#else
-# define STOPS
-#endif
-
-#define SAVE_MIN_WITH_COVER	DO_SAVE_MIN(cover;; mov rCRIFS=cr.ifs,) STOPS
-#define SAVE_MIN_WITH_COVER_R19	DO_SAVE_MIN(cover;; mov rCRIFS=cr.ifs, mov 
r15=r19) STOPS
-#define SAVE_MIN		DO_SAVE_MIN(mov rCRIFS=r0,) STOPS
author
#1 lore raw

PATCH 1/1 duplicate #define's in arch/ia64/kernel/minstate.h?

It seems the definition of STOPS, SAVE_MIN_WITH_COVER, SAVE_MIN_WITH_COVER_R19 and SAVE_MIN are duplicated at the end of arch/ia64/kernel/minstate.h. Is this a typo, or am I missing something?

Here's a patch (based on 2.4.0-test7) which removes the duplicates if it's an error.

Pat

Signature · 21 lines
Patrick O'Rourke
[email protected]

--- minstate.h	Thu Jun 22 10:09:44 2000
+++ /homes/orourke/minstate.h	Fri Sep  1 16:37:47 2000
@@ -192,13 +192,3 @@
 #define SAVE_MIN_WITH_COVER	DO_SAVE_MIN(cover;; mov rCRIFS=cr.ifs,) STOPS
 #define SAVE_MIN_WITH_COVER_R19	DO_SAVE_MIN(cover;; mov rCRIFS=cr.ifs, mov 
r15=r19) STOPS
 #define SAVE_MIN		DO_SAVE_MIN(mov rCRIFS=r0,) STOPS
-
-#ifdef CONFIG_ITANIUM_ASTEP_SPECIFIC
-# define STOPS	nop.i 0x0;; nop.i 0x0;; nop.i 0x0;;
-#else
-# define STOPS
-#endif
-
-#define SAVE_MIN_WITH_COVER	DO_SAVE_MIN(cover;; mov rCRIFS=cr.ifs,) STOPS
-#define SAVE_MIN_WITH_COVER_R19	DO_SAVE_MIN(cover;; mov rCRIFS=cr.ifs, mov 
r15=r19) STOPS
-#define SAVE_MIN		DO_SAVE_MIN(mov rCRIFS=r0,) STOPS
#2 lore raw
In reply to Pat O'Rourke
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Pat O'Rourke

Pat> It seems that the definition of STOPS, SAVE_MIN_WITH_COVER, Pat> SAVE_MIN_WITH_COVER_R19 and SAVE_MIN are duplicated at the end Pat> of arch/ia64/kernel/minstate.h. Is this a typo, or am I Pat> missing something?

Typo. Thanks for catching it.

	--david