test10 bug on SW IO TLB
Hi,
there seems to be a bug on software IO TLB buffer.
Kernel command line option `swiotlb=' is ignored when the bounce buffer for SW IO TLB is allocated.
Following is a patch to this.
But the call to setup_swiotlb should be in some file in arch/ia64/kernel/ , i guess.
arch/ia64/kernel/setup.c renamed from arch/ia64/kernel/setup.c.org +0 -7
@@ -255,13 +255,6 @@paging_init ();platform_setup (cmdline_p); - -#ifdef CONFIG_SWIOTLB - { -extern void setup_swiotlb (void ); -setup_swiotlb (); - } -#endif }/*
init/main.c renamed from init/main.c.org +6 -0
@@ -527,6 +527,12 @@setup_arch (&command_line);printk ("Kernel command line: %s\n" , saved_command_line);parse_options (command_line); +#ifdef CONFIG_SWIOTLB + { +extern void setup_swiotlb (void ); +setup_swiotlb (); + } +#endif trap_init ();init_IRQ ();sched_init ();
----------------
Hirofumi Fujita
Hitachi, Ltd.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Hirofumi Fujita
Hirofumi> Hi, there seems to be a bug on software IO TLB buffer.
Hirofumi> Kernel command line option `swiotlb=' is ignored when the Hirofumi> bounce buffer for SW IO TLB is allocated.
Hirofumi> Following is a patch to this. But the call to Hirofumi> setup_swiotlb should be in some file in arch/ia64/kernel/ Hirofumi> , i guess.
Good point, though it's too arch-dependent to put it in init/main.c. I moved it to arch/ia64/mm/init.c. It does make some sense to put it there as it's memory related and requires bootmem and should be early enough that no drivers that need the sw I/O TLB are active yet.
--david