Skip to contentSkip to conversation

missing exports of __strlen_user(), __strncpy_from_user()?

Linux-ia64 John Kohl 2 participants 2 messages Dec 5, 2000

lore
Share & tools
lore

John Kohl

author
#0 lore raw

i386 kernels export strnlen_user() and strncpy_from_user(); the former is referenced by the macro for strlen_user().

ia64 does not export either __strlen_user() or __strncpy_from_user() (referenced by strlen_user() and strncpy_from_user() macros functions). We need these symbols to implement some code in our kernel module (ClearCase MVFS).

I presume this is just an oversight, and they should be added to arch/ia64/kernel/ia64_ksyms.c? I'd suggest adding these, as similar to exported symbols in i386, to make copy_{from,to}_user(), strncpy_from_user(), and clear_user() usable by modules.

EXPORT_SYMBOL(__strncpy_from_user);
EXPORT_SYMBOL(__do_clear_user);
EXPORT_SYMBOL(__strlen_user);
EXPORT_SYMBOL(__strnlen_user);
EXPORT_SYMBOL(__copy_user);

Signature · 4 lines
=John Kohl <[email protected]>, Software Engineer
Rational Software, Configuration Management Business Unit
Mark your calendars!  Rational User Conference 2001, July 22-26, 2001
in beautiful Denver, Colorado
#1 lore raw

__copy_user and __do_clear_user were already in the current kernel sources but I added the other three now.

Thanks,

	--david
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · John Kohl

John> i386 kernels export strnlen_user() and strncpy_from_user(); John> the former is referenced by the macro for strlen_user().

John> ia64 does not export either __strlen_user() or John> __strncpy_from_user() (referenced by strlen_user() and John> strncpy_from_user() macros functions). We need these symbols John> to implement some code in our kernel module (ClearCase MVFS).

John> I presume this is just an oversight, and they should be added John> to arch/ia64/kernel/ia64_ksyms.c? I'd suggest adding these, John> as similar to exported symbols in i386, to make John> copy_{from,to}_user(), strncpy_from_user(), and clear_user() John> usable by modules.

  John> EXPORT_SYMBOL(__strncpy_from_user);
  John> EXPORT_SYMBOL(__do_clear_user); EXPORT_SYMBOL(__strlen_user);
  John> EXPORT_SYMBOL(__strnlen_user); EXPORT_SYMBOL(__copy_user);

John> -- =John Kohl <[email protected]>, Software Engineer Rational John> Software, Configuration Management Business Unit Mark your John> calendars! Rational User Conference 2001, July 22-26, 2001 in John> beautiful Denver, Colorado

John> _______________________________________________ Linux-IA64 John> mailing list [email protected]
John> http://lists.linuxia64.org/lists/listinfo/linux-ia64