Skip to contentSkip to conversation

problems with ppp/pppd: put_user/copy_to_user

Linux-ia64 Bill Nottingham 3 participants 5 messages May 23, 2001

lore
Share & tools
lore
#0 lore raw

We've got a report of ppp not working; what happens is that it puts in the log:
Couldn't get channel number: bad address

when it sends the PPPIOCGCHAN ioctl.

However, if we replace the calls to put_user for PPPIOCGCHAN & PPPIOCGFLAGS ioctls with copy_to_user, it works fine. Shouldn't this not make any difference?

Bill

#1 lore raw

Do you have "ppp" compiled as a module? There is a problem with exception handling for modules ... I'm working on a patch now.

-----Original Message-----
From: Bill Nottingham [mailto:[email protected]]
Sent: Wednesday, May 23, 2001 11:57 AM
To: [email protected]
Subject: [Linux-ia64] problems with ppp/pppd: put_user/copy_to_user

We've got a report of ppp not working; what happens is that it puts in the log:
Couldn't get channel number: bad address

when it sends the PPPIOCGCHAN ioctl.

However, if we replace the calls to put_user for PPPIOCGCHAN & PPPIOCGFLAGS ioctls with copy_to_user, it works fine. Shouldn't this not make any difference?

Bill

_______________________________________________
Linux-IA64 mailing list
[email protected]
http://lists.linuxia64.org/lists/listinfo/linux-ia64

#2 lore raw
In reply to Bill Nottingham
Quoted 3 lines · Tony

Do you have "ppp" compiled as a module? There is a problem with exception handling for modules ... I'm working on a patch now.

Yes, but why would that make a difference?

Bill

#3 lore raw
In reply to Bill Nottingham
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Bill Nottingham

Bill> We've got a report of ppp not working; what happens is that it Bill> puts in the log: Couldn't get channel number: bad address

Bill> when it sends the PPPIOCGCHAN ioctl.

Bill> However, if we replace the calls to put_user for PPPIOCGCHAN & Bill> PPPIOCGFLAGS ioctls with copy_to_user, it works Bill> fine. Shouldn't this not make any difference?

It should not make a difference. Is there an easy test case that reproduces the problem?

	--daivd
#4 lore raw
In reply to Bill Nottingham
Quoted 6 lines · David Mosberger

Bill> However, if we replace the calls to put_user for PPPIOCGCHAN & Bill> PPPIOCGFLAGS ioctls with copy_to_user, it works Bill> fine. Shouldn't this not make any difference?

It should not make a difference. Is there an easy test case that reproduces the problem?

Hm, not sure if there's something simpler than having two machines talk ppp over a serial cable. I'll poke around.

Bill