arch/ia64/tools/Makefile

PATCH David N. Lombard 2 participants 2 messages Jul 24, 2002 – Jul 26, 2002

lore

Share & tools

lore

David N. Lombard

author

2002-07-24 14:20 UTC #0 lore raw

sigh... The earlier arch/ia64/tools/Makefile patch replicated the action for both targets -- a redundant action.

Attached is the file I intended to send.

Quoted 5 lines · David N. Lombard

The arch/ia64/tools/Makefile has an empty action for the mrproper target. The result is that arch/ia64/tools/print_offsets.s, arch/ia64/tools/print_offsets, and arch/ia64/tools/offsets.h remain after a "make mrproper". The files are deleted with "make distclean".
So, this could be a (subtle) intended difference between the mrproper and distclean targets, but that seems unlikely.
The attached patch moves the file deletion from the clean target (invoked via distclean) to the mrproper target; the distclean target still results in the files being deleted.

Signature · 2 lines

David N. Lombard
MSC.Software

ia64/tools/Makefile renamed from ia64/tools/Makefile.orig +1 -1

@@ -5,9 +5,9 @@
 all: 
 
 mrproper:
+	rm -f print_offsets.s print_offsets offsets.h
 
 clean:
-	rm -f print_offsets.s print_offsets offsets.h
 
 fastdep: offsets.h
 	@if ! cmp -s offsets.h ${TARGET}; then	\

David Mosberger

2002-07-26 16:25 UTC #1 lore raw

Shouldn't "mrproper" simply have a dependency on "clean"?

	--david

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · David N. Lombard

David.L> sigh... The earlier arch/ia64/tools/Makefile patch David.L> replicated the action for both targets -- a redundant David.L> action.

David.L> Attached is the file I intended to send.

Quoted 6 lines · David.L> David N. Lombard wrote:

Quoted 6 lines
The arch/ia64/tools/Makefile has an empty action for the mrproper target. The result is that arch/ia64/tools/print_offsets.s, arch/ia64/tools/print_offsets, and arch/ia64/tools/offsets.h remain after a "make mrproper". The files are deleted with "make distclean".

Quoted 6 lines

Quoted 6 lines
So, this could be a (subtle) intended difference between the mrproper and distclean targets, but that seems unlikely.
The attached patch moves the file deletion from the clean target (invoked via distclean) to the mrproper target; the distclean target still results in the files being deleted.

David.L> -- David N. Lombard MSC.Software ---
David.L> arch/ia64/tools/Makefile.orig Tue Jul 23 17:01:41 2002 +++ David.L> arch/ia64/tools/Makefile Tue Jul 23 17:01:55 2002 @@ -5,9 David.L> +5,9 @@ all:

David.L> mrproper: + rm -f print_offsets.s print_offsets offsets.h

David.L> clean: - rm -f print_offsets.s print_offsets offsets.h

  David.L>  fastdep: offsets.h @if ! cmp -s offsets.h ${TARGET}; then
  David.L> \