Skip to contentSkip to conversation

fix compares of jiffies

PATCH New Tim Schmielau 1 participant 1 message Sep 22, 2002

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix compares of jiffies

Dear Linux kernel code maintainer,

on rechecking the current stable kernel code, I found some places where jiffies were compared in a way that seems to break when they wrap. For these, I made up patches to use the macros "time_before()" or "time_after()" that are supposed to handle wraparound correctly.

For a small part of the patches, I believe you to be the relevant kernel code maintainer. Appended to this email you will find some lines explaining why I decided to mail or cc: you on this (an extract of the copyright notice or the MAINTAINERS file), followed by the patch itself. If I mailed you in error, please drop me a short note.

I kindly ask you to approve the correctness of the patch, and pass it on to the relevant people for inclusion into the mainline kernel.

Thanks,
Tim Schmielau ([email protected])

IA64 (Itanium) PLATFORM
P: David Mosberger-Tang
M: [email protected]
L: [email protected]
W: http://www.linuxia64.org/
S: Maintained

include/asm-ia64/sn/bte_copy.h +1 -1
@@ -250,7 +250,7 @@
 			 * status register into the notification area.
 			 * This fakes the shub performing the copy.
 			 */
-			if (jiffies > bte->idealTransferTimeout) {
+			if (time_after(jiffies, bte->idealTransferTimeout)) {
 				bte->notify = HUB_L(bte->bte_base_addr);
 				bte->idealTransferTimeoutReached++;
 				bte->idealTransferTimeout = jiffies +