Skip to contentSkip to conversation

Memory leak in 2.5.64

Linux-ia64 David Mosberger 1 participant 1 message Mar 12, 2003

lore
Share & tools
lore
#0 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Peter Chubb

Peter> Hi David, The way that tasks need to be freed has changed Peter> since 2.5.61 --- I think we need to do something like the Peter> attached patch (keep __put_task_struct() in kernel/fork.c; Peter> have ia64-specific free_task_struct() in
Peter> arch/ia64/kernel/process.c) otherwise the user_struct will Peter> never have its reference count deleted and so will not be Peter> freed.

Yes, indeed. The patch basically looks good to me, except it shouldn't say CONFIG_IA64. The choice of whether or not thread_info and task_struct should be allocated in one chunk should be a general platform-choice. There really isn't anything ia64-specific about it.

	--david