Idenitfier clash in read_[un]lock
The read_lock and read_unlock macros should not use such innocent variable names like tmp because they have a high probability to clash with (part of) the argument.
Andreas.
asm-ia64/spinlock.h renamed from asm-ia64/spinlock.h.~1~ +4 -4
@@ -112,7 +112,7 @@ typedef struct {#define read_lock (rw) \ do { \ - int tmp = 0; \ + int __read_lock_tmp = 0; \ __asm__ __volatile__ ("1:\tfetchadd4.acq %0 = [%1], 1\n" \ ";;\n" \ "tbit.nz p6,p0 = %0, 31\n" \
@@ -127,15 +127,15 @@ do { \"br.cond.sptk.few 1b\n" \";;\n" \".previous\n" \ - : "=&r" (tmp) \ + : "=&r" (__read_lock_tmp) \ : "r" (rw) : "p6", "memory"); \ } while(0) #define read_unlock(rw) \ do { \ - int tmp = 0; \ + int __read_unlock_tmp = 0; \ __asm__ __volatile__ ("fetchadd4.rel %0 = [%1], -1\n" \ - :"=r" (tmp) \ + :"=r" (__read_unlock_tmp) \ :"r" (rw) \ :"memory" ); \ }while (0 )
Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected] SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Andreas Schwab
Andreas> The read_lock and read_unlock macros should not use such Andreas> innocent variable names like tmp because they have a high Andreas> probability to clash with (part of) the argument.
Thanks, I applied this patch for 2.5. In the future, it would be nice if you could send patches that apply with "patch -p1" and if you could specify what kernel the patch is relative to.
--david
David Mosberger <[email protected]> writes:
|> >>>>> On Tue, 18 Mar 2003 15:33:42 +0100, Andreas Schwab <[email protected]> said: |> |> Andreas> The read_lock and read_unlock macros should not use such |> Andreas> innocent variable names like tmp because they have a high |> Andreas> probability to clash with (part of) the argument. |> |> Thanks, I applied this patch for 2.5. In the future, it would be nice |> if you could send patches that apply with "patch -p1" and if you could |> specify what kernel the patch is relative to.
Sorry, I'll take more care the next time.
Thanks, Andreas.
Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected] SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."