2.4.20-ia64 mca rendezvous
PATCH 1/1 2.4.20-ia64 mca rendezvous
We are not setting the 'always rendezvous for mca' flag. kdb needs it set to get decent mca debugging on all cpus but I do not want kdb to change sal behaviour. Since we do not recover from mca without a debugger, I see no reason why this flag should not be on for all kernels.
The rendezvous timeout was set to 100 * HZ, but SAL expects the timeout to be in milliseconds, HZ may not be 1 millisecond. The patch makes the timeout an explicit 20 seconds, semi-arbitrary value.
Index: 20.5/arch/ia64/kernel/mca.c
arch/ia64/kernel/mca.c Sat, 22 Mar 2003 14:51:16 +1100 kaos (linux-2.4/s/c/5_mca.c 1.1.3.2.3.1.1.1.1.3 644) renamed from arch/ia64/kernel/mca.c Wed, 11 Dec 2002 20:58:53 +1100 kaos (linux-2.4/s/c/5_mca.c 1.1.3.2.3.1.1.1.1.3 644) +1 -1
@@ -432,7 +432,7 @@ ia64_mca_init(void) SAL_MC_PARAM_MECHANISM_INT, IA64_MCA_RENDEZ_VECTOR, IA64_MCA_RENDEZ_TIMEOUT, - 0))) + SAL_MC_PARAM_RZ_ALWAYS))) { printk("ia64_mca_init: Failed to register rendezvous interrupt " "with SAL. rc = %ld\n", rc);
Index: 20.5/include/asm-ia64/mca.h
include/asm-ia64/mca.h Sat, 22 Mar 2003 14:51:16 +1100 kaos (linux-2.4/t/19_mca.h 1.1.3.1.1.1.1.2 644) renamed from include/asm-ia64/mca.h Wed, 11 Dec 2002 20:58:53 +1100 kaos (linux-2.4/t/19_mca.h 1.1.3.1.1.1.1.2 644) +1 -1
@@ -24,7 +24,7 @@ enum { IA64_MCA_FAILURE = 1 }; -#define IA64_MCA_RENDEZ_TIMEOUT (100 * HZ) /* 1000 milliseconds */ +#define IA64_MCA_RENDEZ_TIMEOUT (20 * 1000) /* value in milliseconds - 20 seconds */ #define IA64_CMC_INT_DISABLE 0 #define IA64_CMC_INT_ENABLE 1
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Keith Owens
Keith> We are not setting the 'always rendezvous for mca' flag. kdb Keith> needs it set to get decent mca debugging on all cpus but I do Keith> not want kdb to change sal behaviour. Since we do not Keith> recover from mca without a debugger, I see no reason why this Keith> flag should not be on for all kernels.
Keith> The rendezvous timeout was set to 100 * HZ, but SAL expects Keith> the timeout to be in milliseconds, HZ may not be 1 Keith> millisecond. The patch makes the timeout an explicit 20 Keith> seconds, semi-arbitrary value.
Applied for 2.5.
Thanks,
--david