Skip to contentSkip to conversation

Unwinder bug

Linux-ia64 Applied Andreas Schwab 3 participants 3 messages Mar 25, 2003 – Apr 16, 2003

lore
Share & tools
lore
#0 lore raw

I've found this by inspecting the code: pt_regs_off returns an offset into struct pt_regs. Relative to latest bk, 2.5 has the same bug.

Andreas.

arch/ia64/kernel/unwind.c renamed from arch/ia64/kernel/unwind.c.~1~ +1 -1
@@ -324,7 +324,7 @@ unw_access_gr (struct unw_frame_info *in
 		} else {
 			/* access a scratch register */
 			pt = get_scratch_regs(info);
-			addr = (unsigned long *) (pt + pt_regs_off(regnum));
+			addr = (unsigned long *) ((unsigned long)pt + pt_regs_off(regnum));
 			if (info->pri_unat_loc)
 				nat_addr = info->pri_unat_loc;
 			else
Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected]
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Andreas Schwab

Andreas> I've found this by inspecting the code: pt_regs_off returns Andreas> an offset into struct pt_regs. Relative to latest bk, 2.5 Andreas> has the same bug.

Yes, indeed. Applied.

Thanks,

	--david
#2 lore raw
In reply to Andreas Schwab
Quoted 2 lines · Andreas Schwab

I've found this by inspecting the code: pt_regs_off returns an offset into struct pt_regs. Relative to latest bk, 2.5 has the same bug.

I applied this to 2.4 as well.

Bjorn