build problems/questions (2.6.0-test3)

Hi,

I'm seeing some build problems and want to see if they are just my problems. Shoule these build OK on ia64 or are they all just dont-cares for ia64?

1. driver/block/floppy.c

2. drivers/char/nvram.c ?? (x86-ism)

3. drivers/char/hangcheck.c ?

4. ISA PNP support?

Thanks,
~Randy

Don't-care. Should be made unselectable in Kconfig. No ia64 boxes have shipped with that kind of floppy drive (ide-floppy on the first boxes).

I doubt anyone put an mc146818rtc chip in an ia64 box.

Do you mean drivers/char/hangcheck-timer.c? This looks x86-specific to me, monotonic_clock() is in arch/i386 and arch/x86_64 only.

Definitely no ISA on these boxes. Shouldn't ISAPNP depend on ISA in Kconfig?

"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

Yes, sorry about that.

OK, that's the answers that I expected. I'll look at the Kconfig changes tomorrow.

Thanks,
~Randy

Randy> Hi, I'm seeing some build problems and want to see if they Randy> are just my problems. Shoule these build OK on ia64 or are Randy> they all just dont-cares for ia64?

Randy> 1. driver/block/floppy.c

No (there are no ia64 machines if AT-style floppy controllers.).

Randy> 2. drivers/char/nvram.c ?? (x86-ism)

Nope.

Randy> 3. drivers/char/hangcheck.c ?

Don't know.

Randy> 4. ISA PNP support?

Nope (there is no ISA on ia64 machines).

	--david

On Fri, 22 Aug 2003 03:25:51 +0100 Matthew Wilcox <[email protected]> wrote:

| > 4.  ISA PNP support?
| 
| Definitely no ISA on these boxes.  Shouldn't ISAPNP depend on ISA in Kconfig?

(Adam, this is for ia64 builds.)

My description on #4 was slightly off. I enabled "Plug and Play support" but no Protocols under it (neither of ISA PNP or PNP BIOS support), so only the PNP core is built. PNP core calls request_dma(), which is an undefined reference at link time.

So the question becomes, is "PNP support" x86-specific, or at least not meant for ia64? Is "PNP support" actually only for ISA and EISA buses? If so, it's help text should say so. As is, it seems to be very broad.

--
~Randy [mantra: Always include kernel version.] 2.6.0-test3
"Everything is relative."

On Fri, 22 Aug 2003 03:25:51 +0100 Matthew Wilcox <[email protected]> wrote:

| On Thu, Aug 21, 2003 at 06:28:50PM -0700, Randy.Dunlap wrote:
| > I'm seeing some build problems and want to see if they are just my
| > problems.  Shoule these build OK on ia64 or are they all just
| > dont-cares for ia64?
| > 
| > 1.  driver/block/floppy.c
| 
| Don't-care.  Should be made unselectable in Kconfig.  No ia64 boxes have
| shipped with that kind of floppy drive (ide-floppy on the first boxes).
| 
| > 2.  drivers/char/nvram.c ?? (x86-ism)
| 
| I doubt anyone put an mc146818rtc chip in an ia64 box.
| 
| > 3.  drivers/char/hangcheck.c ?
| 
| Do you mean drivers/char/hangcheck-timer.c?  This looks x86-specific to me,
| monotonic_clock() is in arch/i386 and arch/x86_64 only.
| 
| > 4.  ISA PNP support?
| 
| Definitely no ISA on these boxes.  Shouldn't ISAPNP depend on ISA in Kconfig?

Will wait for Adam's comments on PNP.

Here's a Kconfig patch for #1-3 (for 2.6.0-test3).

David, do you want to merge it, or want me to send to lkml for more comments?

--
~Randy

patch_name: it_configs.patch
patch_version: 2003-08-22.11:49:52
author: Randy.Dunlap <[email protected]>
description: restrict some config options on IA64
product: Linux
product_versions: 260-test3
diffstat: drivers/block/Kconfig | 2 +-

 drivers/char/Kconfig  |    2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff -Naur ./drivers/char/Kconfig~itcfg ./drivers/char/Kconfig
@@ -744,6 +744,7 @@
 
 config NVRAM
 	tristate "/dev/nvram support"
+	depends on !IA64
 	---help---
 	  If you say Y here and create a character special file /dev/nvram
 	  with major number 10 and minor number 144 using mknod ("man mknod"),

@@ -1000,6 +1001,7 @@
 
 config HANGCHECK_TIMER
 	tristate "Hangcheck timer"
+	depends on X86
 	help
 	  The hangcheck-timer module detects when the system has gone
 	  out to lunch past a certain margin.  It can reboot the system

diff -Naur ./drivers/block/Kconfig~itcfg ./drivers/block/Kconfig
@@ -6,7 +6,7 @@
 
 config BLK_DEV_FD
 	tristate "Normal floppy disk support"
-	depends on !X86_PC9800
+	depends on !X86_PC9800 && !IA64
 	---help---
 	  If you want to use the floppy disk drive(s) of your PC under Linux,
 	  say Y. Information about this driver, especially important for IBM

Randy> David, do you want to merge it, or want me to send to lkml Randy> for more comments?

The patch looks good to me, but since it's touching on stuff outside of arch/ia64 or include/asm-ia64, can you ask the respective maintainer(s) to apply it?

	--david