smpboot: fix printk type warning
PATCH 1/1 smpboot: fix printk type warning
Possibly fallout from cpumask changes (?)....
patch_name: cpus_printk.patchpatch_version: 2003-08-22.22:22:33
author: Randy.Dunlap <[email protected]>
description: fix printk type warning
product: Linuxproduct_versions: 260-test4
diffstat: arch/ia64/kernel/smpboot.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/smpboot.c renamed from arch/ia64/kernel/smpboot.c~cpus +1 -1
@@ -560,7 +560,7 @@if (cpu_online (cpu)) bogosum +=cpu_data (cpu)->loops_per_jiffy; -printk (KERN_INFO "Total of %d processors activated (%lu.%02lu BogoMIPS).\n" , +printk (KERN_INFO "Total of %lu processors activated (%lu.%02lu BogoMIPS).\n" ,num_online_cpus (), bogosum/(500000 /HZ ), (bogosum/(5000 /HZ ))%100 ); }
--
~Randy
Randy> Possibly fallout from cpumask changes (?)....
Probably. The patch looks fine to me and I'll apply it.
However, num_online_cpus() is defined in terms of cpus_weight(), which may expand into hweight32() or hweight64(). hweight32() is declared to return "unsigned int". The return type for hweight64() doesn't appear to be totally consistent. E.g., sparc64 returns "unsigned int" whereas everything else appears to return "unsigned long".
I suspect that, at the lest, cpumask.h should be fixed to return a fixed type.
--david
Randy> patch_name: cpus_printk.patch
Randy> patch_version: 2003-08-22.22:22:33
Randy> author: Randy.Dunlap <[email protected]>
Randy> description: fix printk type warning
Randy> product: Linux
Randy> product_versions: 260-test4
Randy> diffstat: Randy> arch/ia64/kernel/smpboot.c | 2 +-
Randy> 1 files changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/smpboot.c renamed from arch/ia64/kernel/smpboot.c~cpus +1 -1
@@ -560,7 +560,7 @@if (cpu_online (cpu)) bogosum +=cpu_data (cpu)->loops_per_jiffy; -printk (KERN_INFO "Total of %d processors activated (%lu.%02lu BogoMIPS).\n" , +printk (KERN_INFO "Total of %lu processors activated (%lu.%02lu BogoMIPS).\n" ,num_online_cpus (), bogosum/(500000 /HZ ), (bogosum/(5000 /HZ ))%100 ); }
--
~Randy