Skip to contentSkip to conversation

arch/ia64/hp/common/sba_iommu.c should include version.h

PATCH Ian Wienand 2 participants 2 messages Sep 8, 2003

lore
Share & tools
lore
#0 lore raw

As it uses version macros.

This fix allows Linus bk tree to build.

-i
[email protected]
http://www.gelato.unsw.edu.au

===== arch/ia64/hp/common/sba_iommu.c 1.29 vs edited =====

arch/ia64/hp/common/sba_iommu.c +1 -0
@@ -33,6 +33,7 @@
 #include <linux/seq_file.h>
 #include <linux/acpi.h>
 #include <linux/efi.h>
+#include <linux/version.h>
 
 #include <asm/delay.h>		/* ia64_get_itc() */
 #include <asm/io.h>
#1 lore raw

--text follows this line--
Ian> As it uses version macros.
Ian> This fix allows Linus bk tree to build.

I think the proper fix here is to remove the #ifdef alltogether. Version-checks inside the main-line kernel are generally frowned upon.

Unless somebody objects, I'll make that change.

	--david

Ian> === arch/ia64/hp/common/sba_iommu.c 1.29 vs edited == Ian> --- 1.29/arch/ia64/hp/common/sba_iommu.c Mon Sep 1 09:14:08 2003
Ian> +++ edited/arch/ia64/hp/common/sba_iommu.c Mon Sep 8 11:02:04 2003
Ian> @@ -33,6 +33,7 @@
Ian> #include <linux/seq_file.h>
Ian> #include <linux/acpi.h>
Ian> #include <linux/efi.h>
Ian> +#include <linux/version.h>

  Ian> #include <asm/delay.h>		/* ia64_get_itc() */
  Ian> #include <asm/io.h>
  Ian> --text follows this line--