Skip to contentSkip to conversation

kill sn_ksyms.c

PATCH In review Christoph Hellwig 4 participants 6 messages Sep 25, 2003 – Oct 7, 2003

lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 kill sn_ksyms.c

None of the exported symbols is referenced by a module, even more the file doesn't compile shen CONFIG_IA64_SGI_SN_DEBUG is set.

arch/ia64/sn/kernel/Makefile +0 -1
@@ -11,4 +11,3 @@
 
 obj-y				+= probe.o setup.o bte.o irq.o mca.o idle.o sn2/
 obj-$(CONFIG_IA64_GENERIC)      += machvec.o
-obj-$(CONFIG_MODULES)           += sn_ksyms.o
arch/ia64/sn/kernel/sn_ksyms.c +0 -37
@@ -1,37 +0,0 @@
-/* 
- * This file is subject to the terms and conditions of the GNU General Public
- * License.  See the file "COPYING" in the main directory of this archive
- * for more details.
- *
- * Copyright (C) 2000-2003 Silicon Graphics, Inc. All rights reserved.
- */
-
-
-/*
- * Architecture-specific kernel symbols
- */
-
-#include <linux/config.h>
-#include <linux/module.h>
-#include <linux/mm.h>
-#include <asm/machvec.h>
-#include <asm/sn/intr.h>
-#include <asm/sn/sgi.h>
-#include <asm/sn/types.h>
-#include <asm/sn/arch.h>
-#include <asm/sn/bte.h>
-#include <asm/sal.h>
-#include <asm/sn/sn_sal.h>
-
-#ifdef CONFIG_IA64_SGI_SN_DEBUG
-EXPORT_SYMBOL(__pa_debug);
-EXPORT_SYMBOL(__va_debug);
-#endif
-
-EXPORT_SYMBOL(bte_copy);
-EXPORT_SYMBOL(bte_unaligned_copy);
-EXPORT_SYMBOL(ia64_sal);
-EXPORT_SYMBOL(sal_lock);
-EXPORT_SYMBOL(sn_local_partid);
-
-
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christoph" = Christoph Hellwig <[email protected]> writes:

Christoph> None of the exported symbols is referenced by a module, Christoph> even more the file doesn't compile shen Christoph> CONFIG_IA64_SGI_SN_DEBUG is set.

There are some device drivers coming that will depend on some of these symbols so I'd prefer to keep this file in place, at least for now. And yes, said drivers are GPL'ed.

Jes

#2 lore raw
In reply to Christoph Hellwig
Quoted 9 lines · Jes Sorensen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christoph" = Christoph Hellwig <[email protected]> writes:

Christoph> None of the exported symbols is referenced by a module, Christoph> even more the file doesn't compile shen Christoph> CONFIG_IA64_SGI_SN_DEBUG is set.

There are some device drivers coming that will depend on some of these symbols so I'd prefer to keep this file in place, at least for now. And yes, said drivers are GPL'ed.

Or just move that stuff when we submit the drivers. I think Robin looked at this a bit...

Jesse

author
#3 lore raw
In reply to Christoph Hellwig
Quoted 9 lines · Jes Sorensen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christoph" = Christoph Hellwig <[email protected]> writes:

Christoph> None of the exported symbols is referenced by a module, Christoph> even more the file doesn't compile shen Christoph> CONFIG_IA64_SGI_SN_DEBUG is set.

There are some device drivers coming that will depend on some of these symbols so I'd prefer to keep this file in place, at least for now. And yes, said drivers are GPL'ed.

Most of that stuff isn't even used by ioc4 or fetchop and *ksyms.c are on their way out. Add new exports to the files defining the symbols when a new drivers needs them.

#4 lore raw
In reply to Christoph Hellwig
Quoted 7 lines · Jesse Barnes
Quoted 6 lines · Jes Sorensen
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christoph" = Christoph Hellwig <[email protected]> writes:

Christoph> None of the exported symbols is referenced by a module, Christoph> even more the file doesn't compile shen Christoph> CONFIG_IA64_SGI_SN_DEBUG is set.

Quoted 6 lines
Quoted 3 lines

There are some device drivers coming that will depend on some of these symbols so I'd prefer to keep this file in place, at least for now. And yes, said drivers are GPL'ed.

Or just move that stuff when we submit the drivers. I think Robin looked at this a bit...

I thought the sn_ksyms was already gone in 2.6. I would say, go ahead and remove it. We will include our EXPORT_SYMBOLs for the symbols we need at that time.

For 2.4, I guess I would say it isn't worth messing with.

Robin

author
#5 lore raw
In reply to Christoph Hellwig
Quoted 5 lines · Robin Holt

I thought the sn_ksyms was already gone in 2.6. I would say, go ahead and remove it. We will include our EXPORT_SYMBOLs for the symbols we need at that time.

For 2.4, I guess I would say it isn't worth messing with.

All patches I send are for 2.6 only. If you want them for 2.4 aswell feel free to backport it, but I don't even look at 2.4 anymore these days.