Skip to contentSkip to conversation

select EFI partition support by default

PATCH In review John Levon 4 participants 6 messages Oct 11, 2003 – Oct 13, 2003

lore
Share & tools
lore

John Levon

author
#0 lore raw

PATCH 1/1 select EFI partition support by default

This makes the EFI choice look like the others, and makes sure it's selected by default if the user didn't choose Advanced Partition Selection.

I fell foul of this, being an IA-64 newbie.

OK ?

regards
john

Index: linux-cvs/fs/partitions/Kconfig =================================RCS file: /home/cvs/linux-2.5/fs/partitions/Kconfig,v retrieving revision 1.5

fs/partitions/Kconfig +2 -2
diff -u -a -p -r1.5 Kconfig
@@ -225,8 +225,8 @@ config SUN_PARTITION
 	  you don't know what all this is about, say N.
 
 config EFI_PARTITION
-	bool "EFI GUID Partition support"
-	depends on PARTITION_ADVANCED
+	bool "EFI GUID Partition support" if PARTITION_ADVANCED
+	default y if !PARTITION_ADVANCED && IA64
 	select CRC32
 	help
 	  Say Y here if you would like to use hard disks under Linux which
#1 lore raw
Quoted 2 lines

+       bool "EFI GUID Partition support" if PARTITION_ADVANCED +       default y if !PARTITION_ADVANCED && IA64

Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then? -Matt

Signature · 4 lines
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
#2 lore raw
In reply to John Levon
Quoted 4 lines · Matt Domsch
Quoted 2 lines

+       bool "EFI GUID Partition support" if PARTITION_ADVANCED +       default y if !PARTITION_ADVANCED && IA64

Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then?

I know the LBD backport is used with SGI disklabels in production enviroments. In fact that's the only production use I know of at all...

author
#3 lore raw
In reply to John Levon
Quoted 7 lines · Christoph Hellwig
Quoted 4 lines
Quoted 2 lines

+       bool "EFI GUID Partition support" if PARTITION_ADVANCED +       default y if !PARTITION_ADVANCED && IA64

Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then?

I know the LBD backport is used with SGI disklabels in production enviroments. In fact that's the only production use I know of at all...

Besides, unless I'm missing something, current 2.6 doesn't prompt for LBD for IA64 at all ?

So, anybody want the patch :)

regards
john

Signature · 2 lines
Khendon's Law:
If the same point is made twice by the same person, the thread is over.
#4 lore raw
In reply to John Levon
Quoted 7 lines · John Levon
Quoted 5 lines · Christoph Hellwig
Quoted 4 lines

fs/partitions/Kconfig config SUN_PARTITION · line 229

Quoted 2 lines
fs/partitions/Kconfig +2 -0
+       bool "EFI GUID Partition support" if PARTITION_ADVANCED
+       default y if !PARTITION_ADVANCED && IA64

Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then?

Quoted 8 lines
Quoted 2 lines

I know the LBD backport is used with SGI disklabels in production enviroments. In fact that's the only production use I know of at

all...

Besides, unless I'm missing something, current 2.6 doesn't prompt for LBD for IA64 at all ?

So, anybody want the patch :)

Actually, CONFIG_LBD is not necessary on IA-64.

include/linux/types.h:

* The type used for indexing onto a disc or disc partition.
* If required, asm/types.h can override it and define
* HAVE_SECTOR_T
*/
#ifndef HAVE_SECTOR_T
typedef unsigned long sector_t;
#endif

Since HAVE_SECTOR_T isn't ever defined by IA-64, this does the right thing.

Signature · 4 lines
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
#5 lore raw
In reply to John Levon
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"John" = John Levon <[email protected]> writes:

John> On Mon, Oct 13, 2003 at 10:00:47AM +0100, Christoph Hellwig

Quoted 8 lines · John> wrote:
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

+       bool "EFI GUID Partition support" if PARTITION_ADVANCED +       default y if !PARTITION_ADVANCED && IA64

Can we make CONFIG_LBD force on CONFIG_EFI_PARTITION too then?

I know the LBD backport is used with SGI disklabels in production enviroments. In fact that's the only production use I know of at all...

John> Besides, unless I'm missing something, current 2.6 doesn't John> prompt for LBD for IA64 at all ?

John> So, anybody want the patch :)

There's no need to prompt for CONFIG_LBD in 2.6, as all 64-bit architectures use 64-bit variables for sector_t.

It's only on 32-bit architectures that it's necessary.

Under 2.4, however, CONFIG_LBD is (or should be) forced on for IA64.

Peterc