speeding up thread-creation
It occurred to me that at present, we're copying lots of state on a clone2() for absolutely no reason. Not only that, but the large size of the "thread_struct" probably also causes poor cache-locality since the task-structure is effectively split in two, with a large unused gap in between. I think it might make sense to move all the large thread_struct-state (IA-32 registers, pmcs[], pmds[], dbr[], ibr[], and fph[]) into a separate "thread_lazy" structure and then put that structure at a place where it doesn't hurt (perhaps above the thread_info structure). If I counted right, this state accounts for 2KB so not copying it in copy_process() ought to speed up thread-creation significantly and avoid stomping needlessly on the L1 d-cache.
Anyone interested in playing with this idea?
--david
David,
Quoted 4 lines · David Mosberger
It occurred to me that at present, we're copying lots of state on a
clone2()for absolutely no reason. Not only that, but the large size of the "thread_struct" probably also causes poor cache-locality since the task-structure is effectively split in two, with a large unused
Quoted 9 lines
gap in between. I think it might make sense to move all the large thread_struct-state (IA-32 registers, pmcs[], pmds[], dbr[], ibr[], and fph[]) into a separate "
thread_lazy" structure and then put that structure at a place where it doesn't hurt (perhaps above thethread_infostructure). If I counted right, this state accounts for 2KB so not copying it incopy_process()ought to speed up thread-creation significantly and avoid stomping needlessly on the L1 d-cache.
That looks like an good idea.
I assume you want to rely on the thread's flags to determine if it is worth copying the thread_lazy structure during a clone. For perfmon, we may need to have two flags: one that says we are storing information in pmds/pmcs and one that says we need to context switch the PMU state. Today PM_VALID flag is used to mean the latter only.
Signature · 1 line
-Stephane
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Stephane Eranian
Stephane> I assume you want to rely on the thread's flags to Stephane> determine if it is worth copying the thread_lazy structure Stephane> during a clone.
Yup. I'd say "necessary" instead of "worth" though. Also, we know that the fph partition never needs to be copied (it contains scratch registers only).
Stephane> For perfmon, we may need to have two flags: one that says Stephane> we are storing information in pmds/pmcs and one that says Stephane> we need to context switch the PMU state. Today PM_VALID Stephane> flag is used to mean the latter only.
I think that would be fine. In what cases would you want to clone the PMU state when PM_VALID is false?
--david