Skip to contentSkip to conversation

unregister YMH0021 from ad1848

PATCH In review Gerald Teschl 3 participants 3 messages Jun 6, 2002 – Jun 7, 2002 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unregister YMH0021 from ad1848

This is the last of my patches which ensure that an opl3sax based sound card will work out of the box on a fresh linux installation:

Since the main driver for opl3sax cards (YMH0021) is opl3sa2 I have commented the YMH0021 entry in the MODULE_DEVICE_TABLE in ad1848.c. Otherwise both ad1848 and opl3sa2 will be listed in modules.isapnpmap and tools like sndconfig will setup the card using ad1848 instead of opl3sa2.

I have tested this and it causes no problems (this is the output when using all patches together):

isapnp: Scanning for PnP cards...
isapnp: opl3sa4 quirk: Allowing dma 0.
isapnp: Card 'YAMAHA OPL3-SAx Audio System'
isapnp: 1 Plug & Play card detected total
ad1848/cs4248 codec driver Copyright (C) by Hannu Savolainen 1993-1996
ad1848: OPL3-SA2 WSS mode detected
ad1848: ISAPnP reports 'OPL3-SA2 WSS mode' at i/o 0x530, irq 5, dma 0, 1
opl3sa2: chipset version = 0x4
opl3sa2: Found OPL3-SA3 (YMF715E or YMF719E)
opl3sa2: 1 PnP card(s) found.

drivers/sound/ad1848.c +2 -0
@@ -2979,8 +2979,10 @@
 		ISAPNP_VENDOR('C','S','C'), ISAPNP_FUNCTION(0x0000), 0 },
         {       ISAPNP_ANY_ID, ISAPNP_ANY_ID,
 		ISAPNP_VENDOR('C','S','C'), ISAPNP_FUNCTION(0x0100), 0 },
+/*	The main driver for this card is opl3sa2
         {       ISAPNP_ANY_ID, ISAPNP_ANY_ID,
 		ISAPNP_VENDOR('Y','M','H'), ISAPNP_FUNCTION(0x0021), 0 },
+*/
 	{0}
 };
 
#1 lore raw

Hi Gerald,

Quoted 5 lines · Gerald Teschl

Since the main driver for opl3sax cards (YMH0021) is opl3sa2 I have commented the YMH0021 entry in the MODULE_DEVICE_TABLE in ad1848.c. Otherwise both ad1848 and opl3sa2 will be listed in modules.isapnpmap and tools like sndconfig will setup the card using ad1848 instead of opl3sa2.

Can't say i've come across that one before.

Quoted 13 lines

I have tested this and it causes no problems (this is the output when using all patches together):

isapnp: Scanning for PnP cards...
isapnp: opl3sa4 quirk: Allowing dma 0.
isapnp: Card 'YAMAHA OPL3-SAx Audio System'
isapnp: 1 Plug & Play card detected total
ad1848/cs4248 codec driver Copyright (C) by Hannu Savolainen 1993-1996
ad1848: OPL3-SA2 WSS mode detected
ad1848: ISAPnP reports 'OPL3-SA2 WSS mode' at i/o 0x530, irq 5, dma 0, 1
opl3sa2: chipset version = 0x4
opl3sa2: Found OPL3-SA3 (YMF715E or YMF719E)
opl3sa2: 1 PnP card(s) found.

I don't have it uncommented, this is what i get;

ad1848/cs4248 codec driver Copyright (C) by Hannu Savolainen 1993-1996
ad1848: OPL3-SA2 WSS mode detected
ad1848: ISAPnP reports 'OPL3-SA2 WSS mode' at i/o 0xe80, irq 5, dma 1, 3
opl3sa2: chipset version = 0x3
opl3sa2: Found OPL3-SA3 (YMF715B or YMF719B)
<OPL3-SA3> at 0x100 irq 5 dma 1,3
<MS Sound System (CS4231)> at 0xe84 irq 5 dma 1,3
<MPU-401 0.0 Midi interface #1> at 0x300 irq 5
opl3sa2: 1 PnP card(s) found.

Did you try a more recent -ac kernel? Because i sent a patch for this about 2 months back.

Signature · 1 line
http://function.linuxpower.ca
#2 lore raw
In reply to Gerald Teschl
Quoted 15 lines · Zwane Mwaikambo

Hi Gerald,

I don't have it uncommented, this is what i get;

ad1848/cs4248 codec driver Copyright (C) by Hannu Savolainen 1993-1996
ad1848: OPL3-SA2 WSS mode detected
ad1848: ISAPnP reports 'OPL3-SA2 WSS mode' at i/o 0xe80, irq 5, dma 1, 3
opl3sa2: chipset version = 0x3
opl3sa2: Found OPL3-SA3 (YMF715B or YMF719B)
<OPL3-SA3> at 0x100 irq 5 dma 1,3
<MS Sound System (CS4231)> at 0xe84 irq 5 dma 1,3
<MPU-401 0.0 Midi interface #1> at 0x300 irq 5
opl3sa2: 1 PnP card(s) found.

Quoted 5 lines

Did you try a more recent -ac kernel? Because i sent a patch for this about 2 months back.

This is a kernel which has your patch included. Otherwise it will say "ad1848: No ISAPnP card(s) found";-) BTW, everything seems to work fine even without your patch.

Even with your patch, if I just load the ad1848 module (which is what sndconfig
will set up for you -- you can find several users reporting this problem if you search
the mailing lists) sound will not work! So if I understand this correctly, this implies
that the YMH0021 entry should be removed from the MODULE_DEVICE_TABLE in ad1848 since it is not a driver for this device.

Gerald