tst-tzset: raise timeout to 10 seconds
PATCH 1/1 tst-tzset: raise timeout to 10 seconds
On ARC HSDK board even though it operates @ 1GHz this test runs ~7 seconds which gives us failures all the time.
That's what happens now:
| # time .../build/timezone/tst-tzset | Timed out: killed the child process | Command exited with non-zero status 1 | real 0m 5.11s | user 0m 3.59s | sys 0m 1.45s
And that's what happens with longer time-out:
| # time .../build/timezone/tst-tzset | real 0m 6.95s | user 0m 4.97s | sys 0m 1.99s | | # echo $? | 0 --- timezone/tst-tzset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
timezone/tst-tzset.c +1 -1
@@ -25,7 +25,7 @@#include <time.h> #include <unistd.h> -#define TIMEOUT 5 +#define TIMEOUT 10static int do_test (void );#define TEST_FUNCTION do_test ()#include "../test-skeleton.c"
Signature · 1 line
2.17.1
PATCH 1/1 tst-tzset: raise timeout to 10 seconds
timezone/tst-tzset.c line 28
Quoted 10 lines · Alexey Brodkin
timezone/tst-tzset.c +1
-1@@ -25,7 +25,7 @@#include <time.h> #include <unistd.h> -#define TIMEOUT 5 +#define TIMEOUT 10
The timeout was set to 5 in commit 112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2 seconds. That was before the default timeout was changed to 20 seconds in commit a28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we should remove the timeout setting - explicit timeouts less than the default are only appropriate where there is a strong reason to want to *decrease* the default timeout.
Signature · 2 lines
Joseph S. Myers joseph at codesourcery.com
PATCH 1/1 tst-tzset: raise timeout to 10 seconds
Quoted 10 lines · Joseph Myers
Quoted 8 lines · Alexey Brodkin
timezone/tst-tzset.c +0
-0@@ -25,7 +25,7 @@#include <time.h> #include <unistd.h>
Quoted 10 lines
timezone/tst-tzset.c line 28
Quoted 2 lines
timezone/tst-tzset.c +1
-1-#define TIMEOUT 5 +#define TIMEOUT 10The timeout was set to 5 in commit
112f28e88c4ea5afbd6050e71416a23db11e4adcto increase it from a default 2 seconds. That was before the default timeout was changed to 20 seconds in commita28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we should remove the timeout setting - explicit timeouts less than the default are only appropriate where there is a strong reason to want to *decrease* the default timeout.
There are a lot of tests that set TIMEOUT to less than 20.
Andreas.
Signature · 3 lines
Andreas Schwab, SUSE Labs, schwab at suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
PATCH 1/1 tst-tzset: raise timeout to 10 seconds
Quoted 23 lines · Andreas Schwab
Quoted 10 lines · Joseph Myers
Quoted 8 lines · Alexey Brodkin
timezone/tst-tzset.c +0
-0@@ -25,7 +25,7 @@#include <time.h> #include <unistd.h> Quoted 10 lines
timezone/tst-tzset.c line 28
Quoted 2 lines
timezone/tst-tzset.c +1
-1-#define TIMEOUT 5 +#define TIMEOUT 10The timeout was set to 5 in commit
112f28e88c4ea5afbd6050e71416a23db11e4adcto increase it from a default 2 seconds. That was before the default timeout was changed to 20 seconds in commita28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we should remove the timeout setting - explicit timeouts less than the default are only appropriate where there is a strong reason to want to *decrease* the default timeout.
Quoted 1 line
There are a lot of tests that set TIMEOUT to less than 20.
We should fix all of them.
Thanks,
Florian
PATCH 1/1 tst-tzset: raise timeout to 10 seconds
Quoted 3 lines · Florian Weimer
Quoted 1 line
There are a lot of tests that set TIMEOUT to less than 20.
We should fix all of them.
It's conceivable some are deliberately less than 20 (if e.g. the test sleeps for a certain number of seconds and does nothing else that should take a significant amount of time), but certainly in the absence of a reason for a short timeout I think such settings should be removed.
Signature · 2 lines
Joseph S. Myers joseph at codesourcery.com