Skip to contentSkip to conversation

PostgreSQL: bump version to 11.0

PATCH New Adam Duskett 2 participants 6 messages Oct 23, 2018 – Oct 24, 2018

lore
Share & tools
lore

Adam Duskett

author
#0 lore raw

PATCH 1/1 PostgreSQL: bump version to 11.0

Other changes:
- Add --without-llvm to CONF_OPTS as PostgreSQL now comes with an optional JIT.

- Add POSTGRESQL_MAKE_OPTS += MAKELEVEL=0 to the MK file to avoid compiling errors about missing header files.

All test-pkg runs passed:

             br-arm-full [1/6]: OK
  br-arm-cortex-a9-glibc [2/6]: OK
   br-arm-cortex-m4-full [3/6]: SKIPPED
          br-x86-64-musl [4/6]: OK
      br-arm-full-static [5/6]: SKIPPED

armv5-ctng-linux-gnueabi [6/6]: OK

Signed-off-by Adam Duskett <[email protected]>
---
 package/postgresql/postgresql.hash |  4 ++--
 package/postgresql/postgresql.mk   | 11 +++++++++--
 2 files changed, 11 insertions(+), 4 deletions(-)
package/postgresql/postgresql.hash +2 -2
index a9cc93c76c..cfea589040 100644
@@ -1,5 +1,5 @@
-# From https://ftp.postgresql.org/pub/source/v10.5/postgresql-10.5.tar.bz2.sha256
-sha256	6c8e616c91a45142b85c0aeb1f29ebba4a361309e86469e0fb4617b6a73c4011	postgresql-10.5.tar.bz2
+# From https://ftp.postgresql.org/pub/source/v11.0/postgresql-11.0.tar.bz2.sha256
+sha256	bf9bba03d0c3902c188af12e454b35343c4a9bf9e377ec2fe50132efb44ef36b	postgresql-11.0.tar.bz2
 
 # License file, Locally calculated
 sha256	24cfc70cf16b3a23242c49ffce39510683bdd48cbedb8a46fe03976ee5f5c21e	COPYRIGHT
package/postgresql/postgresql.mk +9 -2
index 540e1540ca..2915f5ce59 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-POSTGRESQL_VERSION = 10.5
+POSTGRESQL_VERSION = 11.0
 POSTGRESQL_SOURCE = postgresql-$(POSTGRESQL_VERSION).tar.bz2
 POSTGRESQL_SITE = http://ftp.postgresql.org/pub/source/v$(POSTGRESQL_VERSION)
 POSTGRESQL_LICENSE = PostgreSQL

@@ -15,7 +15,14 @@ POSTGRESQL_CONF_ENV = \
 	ac_cv_type_struct_sockaddr_in6=yes \
 	pgac_cv_snprintf_long_long_int_modifier="ll" \
 	pgac_cv_snprintf_size_t_support=yes
-POSTGRESQL_CONF_OPTS = --disable-rpath
+
+POSTGRESQL_CONF_OPTS = \
+	--disable-rpath \
+	--without-llvm
+
+# This has to be set because Postgres' Makefile is being called from another
+# MakeFile in order to avoid rebuilding generated headers in recursive submakes.
+POSTGRESQL_MAKE_OPTS += MAKELEVEL=0
 
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 # PostgreSQL does not build against uClibc with locales
Signature · 1 line
2.17.2
author
#1 lore raw

PATCH 1/1 PostgreSQL: bump version to 11.0

All;

I didn't see that postgresql had already been bumped to 11. Please disregard this patch.

Quoted 66 lines · Adam Duskett

Other changes:
- Add --without-llvm to CONF_OPTS as PostgreSQL now comes with an optional JIT.

- Add POSTGRESQL_MAKE_OPTS += MAKELEVEL=0 to the MK file to avoid compiling errors about missing header files.

All test-pkg runs passed:

             br-arm-full [1/6]: OK
  br-arm-cortex-a9-glibc [2/6]: OK
   br-arm-cortex-m4-full [3/6]: SKIPPED
          br-x86-64-musl [4/6]: OK
      br-arm-full-static [5/6]: SKIPPED

armv5-ctng-linux-gnueabi [6/6]: OK

Signed-off-by Adam Duskett <[email protected]>
---
 package/postgresql/postgresql.hash |  4 ++--
 package/postgresql/postgresql.mk   | 11 +++++++++--
 2 files changed, 11 insertions(+), 4 deletions(-)
package/postgresql/postgresql.hash +2 -2
index a9cc93c76c..cfea589040 100644
@@ -1,5 +1,5 @@
-# From https://ftp.postgresql.org/pub/source/v10.5/postgresql-10.5.tar.bz2.sha256
-sha256 6c8e616c91a45142b85c0aeb1f29ebba4a361309e86469e0fb4617b6a73c4011        postgresql-10.5.tar.bz2
+# From https://ftp.postgresql.org/pub/source/v11.0/postgresql-11.0.tar.bz2.sha256
+sha256 bf9bba03d0c3902c188af12e454b35343c4a9bf9e377ec2fe50132efb44ef36b        postgresql-11.0.tar.bz2
 
 # License file, Locally calculated
 sha256 24cfc70cf16b3a23242c49ffce39510683bdd48cbedb8a46fe03976ee5f5c21e        COPYRIGHT
package/postgresql/postgresql.mk +9 -3
index 540e1540ca..2915f5ce59 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-POSTGRESQL_VERSION = 10.5
+POSTGRESQL_VERSION = 11.0
 POSTGRESQL_SOURCE = postgresql-$(POSTGRESQL_VERSION).tar.bz2
 POSTGRESQL_SITE = http://ftp.postgresql.org/pub/source/v$(POSTGRESQL_VERSION)
 POSTGRESQL_LICENSE = PostgreSQL

@@ -15,7 +15,14 @@ POSTGRESQL_CONF_ENV = \
        ac_cv_type_struct_sockaddr_in6=yes \
        pgac_cv_snprintf_long_long_int_modifier="ll" \
        pgac_cv_snprintf_size_t_support=yes
-POSTGRESQL_CONF_OPTS = --disable-rpath
+
+POSTGRESQL_CONF_OPTS = \
+       --disable-rpath \
+       --without-llvm
+
+# This has to be set because Postgres' Makefile is being called from another
+# MakeFile in order to avoid rebuilding generated headers in recursive submakes.
+POSTGRESQL_MAKE_OPTS += MAKELEVEL=0
 
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 # PostgreSQL does not build against uClibc with locales
--

2.17.2

#2 lore raw

PATCH 1/1 PostgreSQL: bump version to 11.0

In reply to Adam Duskett

Am Tue, 23 Oct 2018 13:15:55 -0400 schrieb Adam Duskett:

Quoted 4 lines

Other changes:
- Add --without-llvm to CONF_OPTS as PostgreSQL now comes with an optional
JIT.

Hi Adam,

besides --without-llvm the bump was already committed:

https://git.buildroot.net/buildroot/commit/?
id=49b9ec7d1c87c63873806bbe8b494d3b1ca99fe1

Is --without-llvm really necessary?
I could not see any problems without this option.

Regards, Bernd

author
#3 lore raw

PATCH 1/1 PostgreSQL: bump version to 11.0

hey Bernd;

Looking into it, I would put it there. If host-llvm is compiled, Postgres will find that
and try to use it to compile the JIT, which can result in build failures.

So either 2 options:

1) Explicitly disable llvm using the flag --without-llvm
2) Fix llvm detection.

What do you think?

Adam

Quoted 24 lines · Bernd Kuhls

Am Tue, 23 Oct 2018 13:15:55 -0400 schrieb Adam Duskett:

Quoted 4 lines

Other changes:
- Add --without-llvm to CONF_OPTS as PostgreSQL now comes with an optional
JIT.

Hi Adam,

besides --without-llvm the bump was already committed:

https://git.buildroot.net/buildroot/commit/?
id=49b9ec7d1c87c63873806bbe8b494d3b1ca99fe1

Is --without-llvm really necessary?
I could not see any problems without this option.

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#4 lore raw

PATCH 1/1 PostgreSQL: bump version to 11.0

Am Wed, 24 Oct 2018 11:34:08 -0400 schrieb Adam Duskett:

Quoted 4 lines

So either 2 options:

1) Explicitly disable llvm using the flag --without-llvm
2) Fix llvm detection.

Hi Adam,

unless 2) is easy to achieve we should go for 1). Personally I prefer 1) because I have no use for JIT.

Regards, Bernd

author
#5 lore raw

PATCH 1/1 PostgreSQL: bump version to 11.0

Hi Bernd;

I am looking into adding JIT support, as it does speed up PG quite a bit. If it proves to be difficult, I will submit a patch that adds the --without-llvm

Quoted 19 lines · Bernd Kuhls

Am Wed, 24 Oct 2018 11:34:08 -0400 schrieb Adam Duskett:

Quoted 4 lines

So either 2 options:

1) Explicitly disable llvm using the flag --without-llvm
2) Fix llvm detection.

Hi Adam,

unless 2) is easy to achieve we should go for 1). Personally I prefer 1) because I have no use for JIT.

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot