Skip to contentSkip to conversation

IOMMU: function flush_iotlb_page is not flushing correct entry

PATCH In review Hiroshi DOYU 2 participants 4 messages Jun 15, 2009 – Jun 18, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IOMMU: function flush_iotlb_page is not flushing correct entry

From: Fernando Guzman Lugo <[email protected]>

From: Fernando Guzman Lugo <[email protected]>

The function flush_iotlb_page is not loading the CAM register with the correct entry to be flushed, so it is flushing other entry

---
 arch/arm/plat-omap/iommu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 mode change 100644 => 100755 arch/arm/plat-omap/iommu.c
arch/arm/plat-omap/iommu.c +1 -1
old mode 100644
new mode 100755
index 4cf449f..4a03013
@@ -298,7 +298,7 @@ void flush_iotlb_page(struct iommu *obj, u32 da)
 		if ((start <= da) && (da < start + bytes)) {
 			dev_dbg(obj->dev, "%s: %08x<=%08x(%x)\n",
 				__func__, start, da, bytes);
-
+			iotlb_load_cr(obj, &cr);
 			iommu_write_reg(obj, 1, MMU_FLUSH_ENTRY);
 		}
 	}
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 IOMMU: function flush_iotlb_page is not flushing

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): aef217b87726a17282c975e9281e9f698ff2b8e6

PatchWorks
http://patchwork.kernel.org/patch/30288/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=aef217b87726a17282c975e9281e9f698ff2b8e6

#2 lore raw
In reply to Hiroshi DOYU

arch/arm/plat-omap/iommu.c

Quoted 17 lines · Hiroshi DOYU

From: Fernando Guzman Lugo <[email protected]>

From: Fernando Guzman Lugo <[email protected]>

The function flush_iotlb_page is not loading the CAM register with the correct entry to be flushed, so it is flushing other entry

---
 arch/arm/plat-omap/iommu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 mode change 100644 => 100755 arch/arm/plat-omap/iommu.c
arch/arm/plat-omap/iommu.c +0 -0
old mode 100644
new mode 100755

This made some bad mode changes as noted by Paul, will fix in l-o master and in omap-fixes. But please check your repos too!

Tony

Quoted 19 lines

index 4cf449f..4a03013

arch/arm/plat-omap/iommu.c +1 -1
@@ -298,7 +298,7 @@ void flush_iotlb_page(struct iommu *obj, u32 da)
 		if ((start <= da) && (da < start + bytes)) {
 			dev_dbg(obj->dev, "%s: %08x<=%08x(%x)\n",
 				__func__, start, da, bytes);
-
+			iotlb_load_cr(obj, &cr);
 			iommu_write_reg(obj, 1, MMU_FLUSH_ENTRY);
 		}
 	}
Signature · 6 lines
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

From: ext Tony Lindgren <[email protected]>
Subject: Re: [PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing correct entry
Date: Thu, 18 Jun 2009 07:05:56 +0200

Quoted 15 lines · Hiroshi DOYU
Quoted 14 lines

From: Fernando Guzman Lugo <[email protected]>

From: Fernando Guzman Lugo <[email protected]>

The function flush_iotlb_page is not loading the CAM register with the correct entry to be flushed, so it is flushing other entry

---
 arch/arm/plat-omap/iommu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 mode change 100644 => 100755 arch/arm/plat-omap/iommu.c
Quoted 6 lines

arch/arm/plat-omap/iommu.c

Quoted 3 lines
arch/arm/plat-omap/iommu.c +0 -0
old mode 100644
new mode 100755

This made some bad mode changes as noted by Paul, will fix in l-o master and in omap-fixes. But please check your repos too!

Will check. Maybe I did something wrong in my emacs dired-mode...:(

Quoted 26 lines

Tony

Quoted 19 lines

index 4cf449f..4a03013

arch/arm/plat-omap/iommu.c +1 -1
@@ -298,7 +298,7 @@ void flush_iotlb_page(struct iommu *obj, u32 da)
 		if ((start <= da) && (da < start + bytes)) {
 			dev_dbg(obj->dev, "%s: %08x<=%08x(%x)\n",
 				__func__, start, da, bytes);
-
+			iotlb_load_cr(obj, &cr);
 			iommu_write_reg(obj, 1, MMU_FLUSH_ENTRY);
 		}
 	}
Signature · 6 lines
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html