OMAP2: Zoom2: Pass irqflags to 8250 driver

PATCH In review Vikram Pandita 2 participants 6 messages Jun 22, 2009 – Aug 12, 2009

Subsystems (3)

Arm (32-bit) Arm sub-architectures OMAP2+ support

lore

Share & tools

lore

Vikram Pandita

author

2009-06-22 23:29 UTC #0 lore raw

PATCH v2 1/1 OMAP2: Zoom2: Pass irqflags to 8250 driver

Pass irqflags to 8250 driver from zoom2 board file Zoom2 has IRQF_TRIGGER_RISING requirement for the 8250 GPIO irq

This patch is dependent on 8250 driver changes getting accepted upstream:
Refer: http://patchwork.kernel.org/patch/31884/

Signed-off-by Vikram Pandita <[email protected]>

---

Warning:
could cause compilation break if 8250 patch is not integrated first

 arch/arm/mach-omap2/board-zoom-debugboard.c |    2 ++
 arch/arm/mach-omap2/serial.c                |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

arch/arm/mach-omap2/board-zoom-debugboard.c +2 -0

index bac5c43..f546063 100644
@@ -12,6 +12,7 @@
 #include <linux/gpio.h>
 #include <linux/serial_8250.h>
 #include <linux/smsc911x.h>
+#include <linux/interrupt.h>
 
 #include <mach/gpmc.h>

@@ -84,6 +85,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
 		.mapbase	= 0x10000000,
 		.irq		= OMAP_GPIO_IRQ(102),
 		.flags		= UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ,
+		.irqflags	= IRQF_SHARED | IRQF_TRIGGER_RISING,
 		.iotype		= UPIO_MEM,
 		.regshift	= 1,
 		.uartclk	= QUART_CLK,

arch/arm/mach-omap2/serial.c +1 -1

index b094c15..45d4884 100644
@@ -429,7 +429,7 @@ static void omap_uart_idle_init(struct omap_uart_state *uart)
 		omap_ctrl_writew(v, uart->padconf);
 	}
 
-	p->flags |= UPF_SHARE_IRQ;
+	p->irqflags |= IRQF_SHARED;
 	ret = request_irq(p->irq, omap_uart_interrupt, IRQF_SHARED,
 			  "serial idle", (void *)uart);
 	WARN_ON(ret);

Signature · 1 line

1.6.0.3.613.g9f8f13

Tony Lindgren

maintainer Acked-by on v2 1/1

2009-08-10 16:39 UTC #1 lore raw

Quoted 5 lines · Vikram Pandita

Pass irqflags to 8250 driver from zoom2 board file Zoom2 has IRQF_TRIGGER_RISING requirement for the 8250 GPIO irq
This patch is dependent on 8250 driver changes getting accepted upstream:
Refer: http://patchwork.kernel.org/patch/31884/

FYI, I'll archive this for now, please resubmit once the related changes are integrated. Or if resubmitting the related changes, please submit this too via the serial list.

Acked-by Tony Lindgren <[email protected]>

Quoted 50 lines

Signed-off-by Vikram Pandita <[email protected]>

---

Warning:
could cause compilation break if 8250 patch is not integrated first

 arch/arm/mach-omap2/board-zoom-debugboard.c |    2 ++
 arch/arm/mach-omap2/serial.c                |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

arch/arm/mach-omap2/board-zoom-debugboard.c +2 -0

index bac5c43..f546063 100644
@@ -12,6 +12,7 @@
 #include <linux/gpio.h>
 #include <linux/serial_8250.h>
 #include <linux/smsc911x.h>
+#include <linux/interrupt.h>
 
 #include <mach/gpmc.h>

@@ -84,6 +85,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
 		.mapbase	= 0x10000000,
 		.irq		= OMAP_GPIO_IRQ(102),
 		.flags		= UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ,
+		.irqflags	= IRQF_SHARED | IRQF_TRIGGER_RISING,
 		.iotype		= UPIO_MEM,
 		.regshift	= 1,
 		.uartclk	= QUART_CLK,

arch/arm/mach-omap2/serial.c +1 -1

index b094c15..45d4884 100644
@@ -429,7 +429,7 @@ static void omap_uart_idle_init(struct omap_uart_state *uart)
 		omap_ctrl_writew(v, uart->padconf);
 	}
 
-	p->flags |= UPF_SHARE_IRQ;
+	p->irqflags |= IRQF_SHARED;
 	ret = request_irq(p->irq, omap_uart_interrupt, IRQF_SHARED,
 			  "serial idle", (void *)uart);
 	WARN_ON(ret);

Signature · 6 lines

1.6.0.3.613.g9f8f13

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Pandita, Vikram

author

2009-08-10 16:44 UTC #2 lore raw

Quoted 13 lines

-----Original Message-----
From: Tony Lindgren [mailto:[email protected]]
Sent: Monday, August 10, 2009 11:39 AM
To: Pandita, Vikram
Cc: [email protected]
Subject: Re: [PATCH v2] OMAP2: Zoom2: Pass irqflags to 8250 driver
Quoted 3 lines · Vikram Pandita
Pass irqflags to 8250 driver from zoom2 board file Zoom2 has IRQF_TRIGGER_RISING requirement for the 8250 GPIO irq

Quoted 6 lines

Quoted 2 lines
This patch is dependent on 8250 driver changes getting accepted upstream:
Refer: http://patchwork.kernel.org/patch/31884/
FYI, I'll archive this for now, please resubmit once the related changes are integrated. Or if resubmitting the related changes, please submit this too via the serial list.

Looks like the dependency patch is already in linux-next tree at [1]. The dependency patch is already lined up stream.

So looks like you can line this irqflag change for zoom2.

[1] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commit;h=7053133124d5cdf207c1168c7a0c582a18e12ea7

Quoted 55 lines

Acked-by Tony Lindgren <[email protected]>
arch/arm/mach-omap2/board-zoom-
Quoted 11 lines
Signed-off-by Vikram Pandita <[email protected]>
---
Warning:
could cause compilation break if 8250 patch is not integrated first
 arch/arm/mach-omap2/board-zoom-debugboard.c |    2 ++
 arch/arm/mach-omap2/serial.c                |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-zoom- renamed from arch/arm/mach-omap2/board-zoom-debugboard.c +0 -0
debugboard.c
Quoted 39 lines
index bac5c43..f546063 100644
arch/arm/mach-omap2/board-zoom-debugboard.c +2 -0
@@ -12,6 +12,7 @@
 #include <linux/gpio.h>
 #include <linux/serial_8250.h>
 #include <linux/smsc911x.h>
+#include <linux/interrupt.h>
 
 #include <mach/gpmc.h>
 
@@ -84,6 +85,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
 		.mapbase	= 0x10000000,
 		.irq		= OMAP_GPIO_IRQ(102),
 		.flags		= UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ,
+		.irqflags	= IRQF_SHARED | IRQF_TRIGGER_RISING,
 		.iotype		= UPIO_MEM,
 		.regshift	= 1,
 		.uartclk	= QUART_CLK,
arch/arm/mach-omap2/serial.c +1 -2
index b094c15..45d4884 100644
@@ -429,7 +429,7 @@ static void omap_uart_idle_init(struct omap_uart_state *uart)
 		omap_ctrl_writew(v, uart->padconf);
 	}
 
-	p->flags |= UPF_SHARE_IRQ;
+	p->irqflags |= IRQF_SHARED;
 	ret = request_irq(p->irq, omap_uart_interrupt, IRQF_SHARED,
 			  "serial idle", (void *)uart);
 	WARN_ON(ret);
--
1.6.0.3.613.g9f8f13
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Tony Lindgren

maintainer

2009-08-11 11:59 UTC #3 lore raw

Quoted 16 lines · Pandita, Vikram

Quoted 16 lines
-----Original Message-----
From: Tony Lindgren [mailto:[email protected]]
Sent: Monday, August 10, 2009 11:39 AM
To: Pandita, Vikram
Cc: [email protected]
Subject: Re: [PATCH v2] OMAP2: Zoom2: Pass irqflags to 8250 driver
Quoted 5 lines · Vikram Pandita
Pass irqflags to 8250 driver from zoom2 board file Zoom2 has IRQF_TRIGGER_RISING requirement for the 8250 GPIO irq
This patch is dependent on 8250 driver changes getting accepted upstream:
Refer: http://patchwork.kernel.org/patch/31884/

Quoted 8 lines

Quoted 3 lines
FYI, I'll archive this for now, please resubmit once the related changes are integrated. Or if resubmitting the related changes, please submit this too via the serial list.
Looks like the dependency patch is already in linux-next tree at [1]. The dependency patch is already lined up stream.
So looks like you can line this irqflag change for zoom2.

OK, thanks, will queue to omap3-upstream queue.

Tony

Quoted 59 lines

[1] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commit;h=7053133124d5cdf207c1168c7a0c582a18e12ea7
Quoted 55 lines
Acked-by Tony Lindgren <[email protected]>
arch/arm/mach-omap2/board-zoom-
Quoted 11 lines
Signed-off-by Vikram Pandita <[email protected]>
---
Warning:
could cause compilation break if 8250 patch is not integrated first
 arch/arm/mach-omap2/board-zoom-debugboard.c |    2 ++
 arch/arm/mach-omap2/serial.c                |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-zoom- renamed from arch/arm/mach-omap2/board-zoom-debugboard.c +0 -0
debugboard.c
Quoted 39 lines
index bac5c43..f546063 100644
arch/arm/mach-omap2/board-zoom-debugboard.c +2 -0
@@ -12,6 +12,7 @@
 #include <linux/gpio.h>
 #include <linux/serial_8250.h>
 #include <linux/smsc911x.h>
+#include <linux/interrupt.h>
 
 #include <mach/gpmc.h>
 
@@ -84,6 +85,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
 		.mapbase	= 0x10000000,
 		.irq		= OMAP_GPIO_IRQ(102),
 		.flags		= UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ,
+		.irqflags	= IRQF_SHARED | IRQF_TRIGGER_RISING,
 		.iotype		= UPIO_MEM,
 		.regshift	= 1,
 		.uartclk	= QUART_CLK,
arch/arm/mach-omap2/serial.c +1 -2
index b094c15..45d4884 100644
@@ -429,7 +429,7 @@ static void omap_uart_idle_init(struct omap_uart_state *uart)
 		omap_ctrl_writew(v, uart->padconf);
 	}
 
-	p->flags |= UPF_SHARE_IRQ;
+	p->irqflags |= IRQF_SHARED;
 	ret = request_irq(p->irq, omap_uart_interrupt, IRQF_SHARED,
 			  "serial idle", (void *)uart);
 	WARN_ON(ret);
--
1.6.0.3.613.g9f8f13
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Pandita, Vikram

author

2009-08-12 19:31 UTC #4 lore raw

In reply to Tony Lindgren

tony

Quoted 17 lines

-----Original Message-----
From: Pandita, Vikram
Quoted 8 lines
-----Original Message-----
From: Tony Lindgren [mailto:[email protected]]
Subject: Re: [PATCH v2] OMAP2: Zoom2: Pass irqflags to 8250 driver
Quoted 3 lines · Vikram Pandita
Pass irqflags to 8250 driver from zoom2 board file Zoom2 has IRQF_TRIGGER_RISING requirement for the 8250 GPIO irq
Quoted 6 lines
Quoted 2 lines
This patch is dependent on 8250 driver changes getting accepted upstream:
Refer: http://patchwork.kernel.org/patch/31884/
FYI, I'll archive this for now, please resubmit once the related changes are integrated. Or if resubmitting the related changes, please submit this too via the serial list.

Quoted 10 lines

Looks like the dependency patch is already in linux-next tree at [1]. The dependency patch is already lined up stream.
So looks like you can line this irqflag change for zoom2.
[1] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-
next.git;a=commit;h=7053133124d5cdf207c1168c7a0c582a18e12ea7
Quoted 2 lines
Acked-by Tony Lindgren <[email protected]>

Would you be able to line this zoom2 patch as well in your omap3-boards branch? This patch is missing from your branch.

Quoted 53 lines

Quoted 53 lines
arch/arm/mach-omap2/board-zoom-
Quoted 13 lines
Signed-off-by Vikram Pandita <[email protected]>
---
Warning:
could cause compilation break if 8250 patch is not integrated first
 arch/arm/mach-omap2/board-zoom-debugboard.c |    2 ++
 arch/arm/mach-omap2/serial.c                |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-zoom- renamed from arch/arm/mach-omap2/board-zoom-debugboard.c +0 -0
debugboard.c
Quoted 39 lines
index bac5c43..f546063 100644
arch/arm/mach-omap2/board-zoom-debugboard.c +2 -0
@@ -12,6 +12,7 @@
 #include <linux/gpio.h>
 #include <linux/serial_8250.h>
 #include <linux/smsc911x.h>
+#include <linux/interrupt.h>
 
 #include <mach/gpmc.h>
 
@@ -84,6 +85,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
 		.mapbase	= 0x10000000,
 		.irq		= OMAP_GPIO_IRQ(102),
 		.flags		= UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ,
+		.irqflags	= IRQF_SHARED | IRQF_TRIGGER_RISING,
 		.iotype		= UPIO_MEM,
 		.regshift	= 1,
 		.uartclk	= QUART_CLK,
arch/arm/mach-omap2/serial.c +1 -2
index b094c15..45d4884 100644
@@ -429,7 +429,7 @@ static void omap_uart_idle_init(struct omap_uart_state *uart)
 		omap_ctrl_writew(v, uart->padconf);
 	}
 
-	p->flags |= UPF_SHARE_IRQ;
+	p->irqflags |= IRQF_SHARED;
 	ret = request_irq(p->irq, omap_uart_interrupt, IRQF_SHARED,
 			  "serial idle", (void *)uart);
 	WARN_ON(ret);
--
1.6.0.3.613.g9f8f13
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Tony Lindgren

maintainer

2009-08-11 12:57 UTC #5 lore raw

PATCH v2 1/1 OMAP2: Zoom2: Pass irqflags to 8250 driver

In reply to Vikram Pandita

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap3-upstream

Initial commit ID (Likely to change): 577736be2190198b88c9f3868b75f8de3b98e3e6

PatchWorks
http://patchwork.kernel.org/patch/31888/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=577736be2190198b88c9f3868b75f8de3b98e3e6