Skip to contentSkip to conversation

omap mailbox: flush posted write when acking mailbox irq

PATCH New Hiroshi DOYU 2 participants 2 messages Aug 25, 2009 – Sep 22, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap mailbox: flush posted write when acking mailbox irq

From: Hiroshi DOYU <[email protected]>

The only way to flush posted write to L4 bus is to do a read back of the same register right after the write.

This seems to be mostly needed in interrupt handlers to avoid causing spurious interrupts.

The earlier fix has been to mark the L4 bus as strongly ordered memory, which solves the problem, but causes performance penalties.

Similar to the fix, 03803a71041e3bc3c077f4e7b92f6ceaa9426df3

---
 arch/arm/mach-omap2/mailbox.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/mailbox.c +3 -0
index 6f71f37..934dae5 100644
@@ -156,6 +156,9 @@ static void omap2_mbox_ack_irq(struct omap_mbox *mbox,
 	u32 bit = (irq == IRQ_TX) ? p->notfull_bit : p->newmsg_bit;
 
 	mbox_write_reg(bit, p->irqstatus);
+
+	/* Flush posted write for irq status to avoid spurious interrupts */
+	mbox_read_reg(p->irqstatus);
 }
 
 static int omap2_mbox_is_irq(struct omap_mbox *mbox,
Signature · 1 line
1.6.0.4
maintainer
#1 lore raw

PATCH 1/1 omap mailbox: flush posted write when acking mailbox irq

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): bc60fc7b5b36b8ec1c24914070348f7f596df1ef

PatchWorks
http://patchwork.kernel.org/patch/43740/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=bc60fc7b5b36b8ec1c24914070348f7f596df1ef