Skip to contentSkip to conversation

omap iommu: fix wrong condition check for SUPERSECTION

PATCH New Hiroshi DOYU 2 participants 2 messages Oct 12, 2009 – Oct 20, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap iommu: fix wrong condition check for SUPERSECTION

From: Hiroshi DOYU <[email protected]>

A bit (2 << 0) is set both on SECTION and SUPERSECTION. To identify SUPERSECTION correctly, other bits should be compared too.

---
 arch/arm/plat-omap/iommu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/iommu.c +1 -1
index 4b60127..94584f1 100644
@@ -664,7 +664,7 @@ static size_t iopgtable_clear_entry_core(struct iommu *obj, u32 da)
 		nent = 1; /* for the next L1 entry */
 	} else {
 		bytes = IOPGD_SIZE;
-		if (*iopgd & IOPGD_SUPER) {
+		if ((*iopgd & IOPGD_SUPER) == IOPGD_SUPER) {
 			nent *= 16;
 			/* rewind to the 1st entry */
 			iopgd = (u32 *)((u32)iopgd & IOSUPER_MASK);
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 omap iommu: fix wrong condition check for SUPERSECTION

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 49086e551006a9fe84667edbc867cdf80095787e

PatchWorks
http://patchwork.kernel.org/patch/53067/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=49086e551006a9fe84667edbc867cdf80095787e